-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix upgrade guide link #12693
Merged
Merged
Fix upgrade guide link #12693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 6897a60.
github-actions
bot
added
area/frontend
area/platform
issues related to the platform
labels
May 9, 2022
teallarson
force-pushed
the
teal/fix-upgrade-link
branch
from
May 9, 2022 07:45
4884d5d
to
a428be7
Compare
github-actions
bot
added
area/frontend
area/platform
issues related to the platform
and removed
area/frontend
area/platform
issues related to the platform
labels
May 9, 2022
timroes
approved these changes
May 9, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me. Validated all changed links exist as well.
teallarson
force-pushed
the
teal/fix-upgrade-link
branch
from
May 9, 2022 07:55
4d1a7f5
to
01df6e4
Compare
It seems now there are more changes in the PR than there were meant to be? |
yes, bad job trying to squash a commit. cleaned up now. |
teallarson
force-pushed
the
teal/fix-upgrade-link
branch
from
May 9, 2022 08:12
01df6e4
to
4884d5d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes link to upgrade guide from the web app. Checked that other links are still valid as well.
Closes #12447
How
Uses the correct url