Add secrets handling in UI #1313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michel-tricot
approved these changes
Dec 14, 2020
cgardens
approved these changes
Dec 16, 2020
There was a problem hiding this comment.
were we going to do something where you had to click on something in order to be able to edit the secret, so that people didn't accidentally do it? I think we talked about that originally but maybe that was replaced by your suggestion in slack here:
when we try to modify password field - do we expect input to be cleared on every focus + key press? Or some other behaviour
if so that's fine for now.
|
@jamakase can we merge this? |
|
@cgardens I was investigating a bit how to handle it from UX point of view in a more appropriate form. Need to have small fix and then we can merge. |
jamakase
force-pushed
the
jamakase/handle-secrest-in-ui
branch
from
2b353aa
to
3bc142c
Compare
davydov-d
added a commit
that referenced
this pull request
Jan 18, 2023
davydov-d
added a commit
that referenced
this pull request
Jan 18, 2023
davydov-d
added a commit
that referenced
this pull request
Jan 18, 2023
davydov-d
added a commit
that referenced
this pull request
Jan 19, 2023
davydov-d
added a commit
that referenced
this pull request
Jan 19, 2023
davydov-d
added a commit
that referenced
this pull request
Jan 20, 2023
davydov-d
added a commit
that referenced
this pull request
Jan 20, 2023
davydov-d
added a commit
that referenced
this pull request
Jan 20, 2023
davydov-d
added a commit
that referenced
this pull request
Jan 20, 2023
davydov-d
added a commit
that referenced
this pull request
Jan 20, 2023
davydov-d
added a commit
that referenced
this pull request
Jan 20, 2023
davydov-d
added a commit
that referenced
this pull request
Jan 23, 2023
davydov-d
added a commit
that referenced
this pull request
Jan 23, 2023
* #1313 source google ads: write less logs * #1313 source google ads: upd changelog * #1313 source google ads: fix expected records * #1313 source google ads: rm unused call to init * #1313 source google ads: fix expected records * #1313 source google ads - bump sieve outside the loop * auto-bump connector version Co-authored-by: Octavia Squidington III <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1055
What
adds
type=passwordfor secrets