Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BigQuery destination : Enable DAT tests #13155

Merged
merged 11 commits into from
May 27, 2022
Merged

BigQuery destination : Enable DAT tests #13155

merged 11 commits into from
May 27, 2022

Conversation

DoNotPanicUA
Copy link
Contributor

@DoNotPanicUA DoNotPanicUA commented May 24, 2022 •
edited
Loading

What

Enable DAT tests for BigQuery Destination where it's possible.
Found issues:

@DoNotPanicUA DoNotPanicUA self-assigned this May 24, 2022
@github-actions github-actions bot added the area/connectors Connector related issues label May 24, 2022
@DoNotPanicUA
Copy link
Contributor Author

#9444

@DoNotPanicUA
Copy link
Contributor Author

DoNotPanicUA commented May 24, 2022 •
edited by github-actions bot
Loading

/test connector=connectors/destination-bigquery

🕑 connectors/destination-bigquery https://github.com/airbytehq/airbyte/actions/runs/2380594789
✅ connectors/destination-bigquery https://github.com/airbytehq/airbyte/actions/runs/2380594789
Python tests coverage:

Name                                                              Stmts   Miss  Cover
-------------------------------------------------------------------------------------
normalization/transform_config/__init__.py                            2      0   100%
normalization/transform_catalog/reserved_keywords.py                 13      0   100%
normalization/transform_catalog/__init__.py                           2      0   100%
normalization/destination_type.py                                    13      0   100%
normalization/__init__.py                                             4      0   100%
normalization/transform_catalog/destination_name_transformer.py     155      8    95%
normalization/transform_config/transform.py                         159     31    81%
normalization/transform_catalog/table_name_registry.py              174     34    80%
normalization/transform_catalog/utils.py                             38      9    76%
normalization/transform_catalog/dbt_macro.py                         22      7    68%
normalization/transform_catalog/catalog_processor.py                147     80    46%
normalization/transform_catalog/transform.py                         61     38    38%
normalization/transform_catalog/stream_processor.py                 543    352    35%
-------------------------------------------------------------------------------------
TOTAL                                                              1333    559    58%

Build Passed

Test summary info:

All Passed

@DoNotPanicUA DoNotPanicUA marked this pull request as ready for review May 25, 2022 09:23
@DoNotPanicUA

This comment was marked as outdated.

Sign in to view
@DoNotPanicUA

This comment was marked as outdated.

Sign in to view
@DoNotPanicUA
Revert "fix emitted_at"
4bc6509 
This reverts commit e752a24.
@DoNotPanicUA
Revert "DON"T MERGE"
670d633 
This reverts commit dc2806b.
@DoNotPanicUA
Copy link
Contributor Author

DoNotPanicUA commented May 26, 2022 •
edited by github-actions bot
Loading

/test connector=connectors/destination-bigquery

🕑 connectors/destination-bigquery https://github.com/airbytehq/airbyte/actions/runs/2392043608
✅ connectors/destination-bigquery https://github.com/airbytehq/airbyte/actions/runs/2392043608
Python tests coverage:

Name                                                              Stmts   Miss  Cover
-------------------------------------------------------------------------------------
normalization/transform_config/__init__.py                            2      0   100%
normalization/transform_catalog/reserved_keywords.py                 13      0   100%
normalization/transform_catalog/__init__.py                           2      0   100%
normalization/destination_type.py                                    13      0   100%
normalization/__init__.py                                             4      0   100%
normalization/transform_catalog/destination_name_transformer.py     155      8    95%
normalization/transform_config/transform.py                         159     31    81%
normalization/transform_catalog/table_name_registry.py              174     34    80%
normalization/transform_catalog/utils.py                             38      9    76%
normalization/transform_catalog/dbt_macro.py                         22      7    68%
normalization/transform_catalog/catalog_processor.py                147     80    46%
normalization/transform_catalog/transform.py                         61     38    38%
normalization/transform_catalog/stream_processor.py                 543    352    35%
-------------------------------------------------------------------------------------
TOTAL                                                              1333    559    58%

Build Passed

Test summary info:

All Passed

@DoNotPanicUA DoNotPanicUA merged commit 87847ba into master May 27, 2022
@DoNotPanicUA DoNotPanicUA deleted the aleonets/DAT-bigquery branch May 27, 2022 11:43
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request May 27, 2022
Merged
jscottpolevault pushed a commit to jscottpolevault/airbyte that referenced this pull request Jun 1, 2022
@DoNotPanicUA @grubberr
BigQuery destination : Enable DAT tests (airbytehq#13155)
41740c5 
* Enable basic DAT tests

* adopt basic tests + avoid DateTime issue #13123

* disable array tests due to issue airbytehq#13154

* format

* DON"T MERGE

* fix emitted_at

Signed-off-by: Sergey Chvalyuk <[email protected]>

* Revert "fix emitted_at"

This reverts commit e752a24.

* Revert "DON"T MERGE"

This reverts commit dc2806b.

* google format

Co-authored-by: Sergey Chvalyuk <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sashaNeshcheret sashaNeshcheret sashaNeshcheret approved these changes

@Tr1985 Tr1985 Tr1985 approved these changes

@alexandr-shegeda alexandr-shegeda Awaiting requested review from alexandr-shegeda

Assignees

@DoNotPanicUA DoNotPanicUA

Labels
area/connectors Connector related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DoNotPanicUA @sashaNeshcheret @Tr1985 @grubberr