Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎉 New Source Timely #13292

Closed
wants to merge 3 commits into from
Closed

🎉 New Source Timely #13292

wants to merge 3 commits into from

Conversation

makyash
Copy link
Contributor

@makyash makyash commented May 27, 2022 •
edited by marcosmarxm
Loading

What

Describe what the change is solving
It helps to add screenshots if it affects the frontend.
We at Pliancy, have created this python custom connector, that interacts with the API and pulls the data from the source. This connector helps in time tracking and is used by many companies like ours. Everything is explained properly on how to work this connector locally as well in the readme.md file.

How

Describe the solution

Recommended reading order

  1. x.java
  2. y.python

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • docs/SUMMARY.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the connector is published, connector added to connector index as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here
Connector Generator
  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

Screen Shot 2022-05-27 at 3 49 46 PM
Screen Shot 2022-05-27 at 3 53 24 PM
Screen Shot 2022-05-27 at 3 53 53 PM

@CLAassistant
Copy link

CLAassistant commented May 27, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the area/connectors Connector related issues label May 27, 2022
@marcosmarxm marcosmarxm self-assigned this May 29, 2022
@marcosmarxm
Copy link
Member

@makyash can you post the output from ./gradlew airbyte-integrations:connectors:source-timely:integrationTest

@harshithmullapudi harshithmullapudi changed the title Added Timely source python connector 🎉 New Source Timely May 31, 2022
@alafanechere alafanechere added bounty bounty-L Maintainer program: claimable large bounty PR waiting-for-cred Waiting for CI credentials labels Jun 2, 2022
@alafanechere alafanechere mentioned this pull request Jun 2, 2022
Closed
@alafanechere alafanechere removed bounty bounty-L Maintainer program: claimable large bounty PR labels Jun 2, 2022
@harshithmullapudi harshithmullapudi marked this pull request as draft June 2, 2022 14:00
@harshithmullapudi
Copy link
Contributor

Hey @makyash I am moving this to draft until we figure out the test cases

@ycherniaiev
Copy link
Contributor

ycherniaiev commented Jun 3, 2022 •
edited
Loading

@makyash is your organization is a customer of Timely?We need it for partnership and sandbox.What I see you work for Pilancy.Could you give your gmail in order to meet with Timely

@makyash
Copy link
Contributor Author

makyash commented Jun 3, 2022

@ycherniaiev Yes, our organization is the customer of Timely! email: [email protected]

@harshithmullapudi
Copy link
Contributor

I am taking over this for testcases

@harshithmullapudi harshithmullapudi marked this pull request as ready for review June 27, 2022 17:31
@harshithmullapudi harshithmullapudi mentioned this pull request Jul 1, 2022
Merged
@harshithmullapudi
Copy link
Contributor

closing this in favour of #14335

harshithmullapudi added a commit that referenced this pull request Jul 15, 2022
@harshithmullapudi @makyash @octavia-squidington-iii
🎉 New source: Timely #13292 (#14335)
bf9bfd1 
* Added Timely source python connector

* Added Pagination

* fix: linting

* fix: tests, linting and naming

* chore: added connector to definitions

* fix: icon is blank

* auto-bump connector version

Co-authored-by: Yashkumar Makwana <[email protected]>
Co-authored-by: Octavia Squidington III <[email protected]>
jsrcodes added a commit to jsrcodes/airbyte that referenced this pull request Jul 15, 2022
@jsrcodes
Merge branch 'master' of https://github.com/airbytehq/airbyte into ai…
755e0d7 
…rbytehq-master

* 'master' of https://github.com/airbytehq/airbyte: (1141 commits)
  pass USE_STREAM_CAPABLE_STATE env var to containers/deployments (airbytehq#14737)
  Bump mqtt connector (airbytehq#14648)
  Add error code to ManualOperationResult (airbytehq#14657)
  Bump elasticsearch version (airbytehq#14640)
  Ryan/sync oracle version number (airbytehq#14736)
  Fixed linter issue with add_fields.py comments (airbytehq#14742)
  🎉Redshift, Databricks, Snowflake, S3 Destinations: Make S3 output filename configurable (airbytehq#14494)
  🐛Source-mssql: aligned regular and cdc syncs and its datatype tests (airbytehq#14379)
  🎉 Source Amazon Seller Partner: Add new streams (airbytehq#13604)
  bump source-file-secure (airbytehq#14704)
  🎉 New source: Timely airbytehq#13292 (airbytehq#14335)
  🪟🔧 Refactor feature service (airbytehq#14559)
  [low code cdk] add a transformation for adding fields into an outgoing record (airbytehq#14638)
  Bump destination-postgres to 0.3.21 (airbytehq#14479)
  Remove `additionalProperties: false` from JDBC destination connectors (airbytehq#14618)
  🎉 Source Notion: add OAuth authorization for source-notion connector (airbytehq#14706)
  Use the configuration diff calculation in the update endpoint (airbytehq#14626)
  🪟 🐛 Fix input validation on blur and cleanup signup error handling (airbytehq#14724)
  lower sleep after wait for successful job (airbytehq#14725)
  Add configuration diff (airbytehq#14603)
  ...
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Jul 23, 2022
Merged
@makyash makyash deleted the Timely branch October 7, 2022 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@harshithmullapudi harshithmullapudi

Labels
area/connectors Connector related issues bounty community connectors/source/timely waiting-for-cred Waiting for CI credentials
Projects
No open projects
Community Contributed PRs
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@makyash @CLAassistant @marcosmarxm @harshithmullapudi @ycherniaiev @bleonard @alafanechere @octavia-squidington-iii