Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix confirmation modal appearing when adding a transformation while creating or saving a connection #13426

Merged
merged 4 commits into from
Jun 10, 2022
Merged

Fix confirmation modal appearing when adding a transformation while creating or saving a connection #13426

merged 4 commits into from
Jun 10, 2022

Commits on Jun 3, 2022

  1. Update form tracker to track TransformationForm instead of parent form

    @edmundito
    edmundito committed Jun 3, 2022
    Configuration menu
    Copy the full SHA
    937910e View commit details
    Browse the repository at this point in the history

  2. Update Setup connection icon to be disabled while creating or editing… 

    … a transformation

* Add properties to track start/end editing in TransformationField
* Bubble up prop tracking to ConnectionForm
* Update CreateControls submit button to disable when form is not valid or a transformation is editing
    @edmundito
    edmundito committed Jun 3, 2022
    Configuration menu
    Copy the full SHA
    a3cc9e4 View commit details
    Browse the repository at this point in the history

  3. Update TransformationForm to clear form tracking when canceling edit.

    @edmundito
    edmundito committed Jun 3, 2022
    Configuration menu
    Copy the full SHA
    f29b8f4 View commit details
    Browse the repository at this point in the history

  4. Disable save button while adding or editing a custom transformation i… 

    …n transformation page

* Update FormCard to be able to disable submit button and disable if form is not valid
* Update TransformationView to track if transformation is edited to enable and disable submit button
    @edmundito
    edmundito committed Jun 3, 2022
    Configuration menu
    Copy the full SHA
    ba38b0a View commit details
    Browse the repository at this point in the history