Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Connectors Base Build: CDK tests fail after requests update #13652

Merged
merged 1 commit into from
Jun 9, 2022
Merged

Fix Connectors Base Build: CDK tests fail after requests update #13652

merged 1 commit into from
Jun 9, 2022

Conversation

pedroslopez
Copy link
Contributor

What

requests v2.28.0 was just released, which changed some things around how the JSONDecodeError exception was initialized. This broke one of our tests in the CDK, and in turn the Connectors Base build started failing.

How

Fix the failing test by using a real response instead of a half-mocked one.

@github-actions github-actions bot added the CDK Connector Development Kit label Jun 9, 2022
@pedroslopez pedroslopez changed the title fix Connectors Build: CDK json error tests Fix Connectors Base Build: CDK tests fail after requests update Jun 9, 2022
@pedroslopez pedroslopez marked this pull request as ready for review June 9, 2022 18:49
evantahler
evantahler approved these changes Jun 9, 2022
View reviewed changes
Copy link
Contributor

@evantahler evantahler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. I guess there's no way to test a connector until we publish this, right?

@girarda
Copy link
Contributor

girarda commented Jun 9, 2022 •
edited
Loading

Cool. I guess there's no way to test a connector until we publish this, right?

we can test this locally by running the read command or the acceptance tests for a connector
python -m pytest integration_tests -p integration_tests.acceptance

@pedroslopez
Copy link
Contributor Author

Cool. I guess there's no way to test a connector until we publish this, right?

we can test this locally by running the read command or the acceptance tests for a connector python -m pytest integration_tests -p integration_tests.acceptance

Note that this particular fix doesn't change anything within the CDK itself that would affect connectors, just a unit test for the python CDK

@pedroslopez pedroslopez merged commit 4f8f979 into master Jun 9, 2022
@pedroslopez pedroslopez deleted the pedroslopez/fix-cdk-test branch June 9, 2022 20:05
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Jun 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evantahler evantahler evantahler approved these changes

@girarda girarda girarda approved these changes

Assignees
No one assigned
Labels
CDK Connector Development Kit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pedroslopez @girarda @evantahler