Fix empty airbyte source check #14509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/platform
alovew
commented
Jul 7, 2022
| @@ -302,8 +302,10 @@ public void testPerStreamWithMissingState() throws Exception { | |||
| Assertions.assertThat(emptyAirbyteSource.isFinished()).isTrue(); | |||
| } | |||
|
|
|||
| // In the LEGACY state, if the list of streams passed in to be reset does not include every stream | |||
There was a problem hiding this comment.
let me know if these comments are confusingly written. just thought the tests should have some explanation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are doing a check for resets with LEGACY state to ensure that all streams in a Catalog are being reset. The existing check just checked that streams_to_reset == streams_in_catalog. But since it's ok for streams that are NOT in the catalog to be reset, what we actually want is streams_to_reset.containsAll(streams_in_catalog).
This PR updates the logic, renames a few things, and adds an extra test for this case.