Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Source Google Ads: Fix wrong schema for ad_group_criterion.topic.path and shifted Campaigns stream to non-managers stream list #15084

Merged
merged 3 commits into from
Jul 28, 2022
Merged

🐛 Source Google Ads: Fix wrong schema for ad_group_criterion.topic.path and shifted Campaigns stream to non-managers stream list #15084

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2372f00
Fix wrong schema for ad_group_criterion.topic.path
lazebnyi Jul 27, 2022
952138b
Shifted campaingns stream to non-manager streams
lazebnyi Jul 27, 2022
12e5079
auto-bump connector version [ci skip]
octavia-squidington-iii Jul 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion airbyte-config/init/src/main/resources/seed/source_definitions.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,7 +327,7 @@
- name: Google Ads
sourceDefinitionId: 253487c0-2246-43ba-a21f-5116b20a2c50
dockerRepository: airbyte/source-google-ads
dockerImageTag: 0.1.43
dockerImageTag: 0.1.44
documentationUrl: https://docs.airbyte.io/integrations/sources/google-ads
icon: google-adwords.svg
sourceType: api
Expand Down
2 changes: 1 addition & 1 deletion airbyte-config/init/src/main/resources/seed/source_specs.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2798,7 +2798,7 @@
supportsNormalization: false
supportsDBT: false
supported_destination_sync_modes: []
- dockerImage: "airbyte/source-google-ads:0.1.43"
- dockerImage: "airbyte/source-google-ads:0.1.44"
spec:
documentationUrl: "https://docs.airbyte.com/integrations/sources/google-ads"
connectionSpecification:
Expand Down
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-google-ads/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,5 @@ COPY main.py ./

ENTRYPOINT ["python", "/airbyte/integration_code/main.py"]

LABEL io.airbyte.version=0.1.43
LABEL io.airbyte.version=0.1.44
LABEL io.airbyte.name=airbyte/source-google-ads
5 changes: 4 additions & 1 deletion ...ectors/source-google-ads/source_google_ads/schemas/display_topics_performance_report.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,10 @@
"type": ["null", "string"]
},
"ad_group_criterion.topic.path": {
"type": ["null", "string"]
"type": ["null", "array"],
"items": {
"type": "string"
}
},
"metrics.cross_device_conversions": {
"type": ["null", "number"]
Expand Down
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-google-ads/source_google_ads/source.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,14 +121,14 @@ def streams(self, config: Mapping[str, Any]) -> List[Stream]:
AdGroups(**incremental_config),
AdGroupLabels(google_api, customers=customers),
Accounts(**incremental_config),
Campaigns(**incremental_config),
CampaignLabels(google_api, customers=customers),
ClickView(**incremental_config),
]
# Metrics streams cannot be requested for a manager account.
if non_manager_accounts:
streams.extend(
[
Campaigns(**non_manager_incremental_config),
UserLocationReport(**non_manager_incremental_config),
AccountPerformanceReport(**non_manager_incremental_config),
DisplayTopicsPerformanceReport(**non_manager_incremental_config),
Expand Down
Loading