-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Destination S3 - connector check ignores the s3_bucket_path #15207
Conversation
@sashaNeshcheret can you review this contribution? |
/test connector=connectors/destination-s3
Build FailedTest summary info:
|
Hey @sashaNeshcheret, could you review this PR please? |
/test connector=connectors/destination-s3
Build PassedTest summary info:
|
@sashaNeshcheret can you do the final approval here? |
Hi @haithem-souala, sorry i've not a chance to make review earlier. |
/publish connector=connectors/destination-s3
if you have connectors that successfully published but failed definition generation, follow step 4 here |
) * fix: use correct var for s3 bucket path * typo * fix - use bucket path instead of bucket name * fix: use correct var for s3 bucket path * typo * fix - use bucket path instead of bucket name * add fix to changelog * solve conflict * solve conflict * fix - use bucket path instead of bucket name * solve md file conflict * solve dockerfile conflict * auto-bump connector version [ci skip] * add eof Co-authored-by: Marcos Marx <[email protected]> Co-authored-by: marcosmarxm <[email protected]> Co-authored-by: Octavia Squidington III <[email protected]>
) * fix: use correct var for s3 bucket path * typo * fix - use bucket path instead of bucket name * fix: use correct var for s3 bucket path * typo * fix - use bucket path instead of bucket name * add fix to changelog * solve conflict * solve conflict * fix - use bucket path instead of bucket name * solve md file conflict * solve dockerfile conflict * auto-bump connector version [ci skip] * add eof Co-authored-by: Marcos Marx <[email protected]> Co-authored-by: marcosmarxm <[email protected]> Co-authored-by: Octavia Squidington III <[email protected]>
Fix for #15195 & #11871