-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle invalid numeric values in JDBC source #1588
Conversation
airbyte-scheduler/src/main/java/io/airbyte/scheduler/client/DefaultSchedulerJobClient.java
Outdated
Show resolved
Hide resolved
…faultSchedulerJobClient.java
I am afraid that this is adding transformation logic to the source. What would be another option? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's unfortunate that NaN/null/infinity will look the same on the destination, but I can't think of a better way right now.
This behavior should be added to our data types documentation.
What
NaN and infinity are not supported in JSON schema, but are allowed values in various Postgres numeric types . So we force them into null at the DB level.
Releasing this now to fix a bug that a user is having. But we'll want to have tests like this for every data type's edge cases. This is coming in a later PR.