Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 Source Zendesk Chat: increase unit_test coverage up to 90% #15958

Merged
merged 4 commits into from
Aug 25, 2022

Conversation

bazarnov
Copy link
Collaborator

What

Resolving: #15715

How

  • added test_streams.py unit tests
  • added test_source.py unit_tests

@bazarnov
Copy link
Collaborator Author

bazarnov commented Aug 25, 2022

/test connector=connectors/source-zendesk-chat

🕑 connectors/source-zendesk-chat https://github.com/airbytehq/airbyte/actions/runs/2925866299
✅ connectors/source-zendesk-chat https://github.com/airbytehq/airbyte/actions/runs/2925866299
Python tests coverage:

Name                              Stmts   Miss  Cover
-----------------------------------------------------
source_zendesk_chat/__init__.py       2      0   100%
source_zendesk_chat/source.py        26      1    96%
source_zendesk_chat/streams.py      151     13    91%
-----------------------------------------------------
TOTAL                               179     14    92%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          10      4    60%   15-18
	 source_acceptance_test/config.py                        83      6    93%   78-80, 84-86
	 source_acceptance_test/conftest.py                     164    164     0%   6-282
	 source_acceptance_test/plugin.py                        48     48     0%   6-104
	 source_acceptance_test/tests/test_core.py              329    111    66%   39, 50-58, 63-70, 74-75, 79-80, 164, 202-219, 228-236, 240-245, 251, 284-289, 327-334, 374-376, 379, 439-448, 477-478, 484, 487, 520-530, 543-568, 573-577
	 source_acceptance_test/tests/test_full_refresh.py       52      2    96%   34, 65
	 source_acceptance_test/tests/test_incremental.py       121     25    79%   21-23, 29-31, 36-43, 48-61, 208-216
	 source_acceptance_test/utils/asserts.py                 37      2    95%   57-58
	 source_acceptance_test/utils/common.py                  77     17    78%   15-16, 24-30, 47-54, 64, 67
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       110     48    56%   23-26, 32, 36, 39-64, 67-69, 72-74, 77-79, 82-84, 87-89, 92-110, 144-146
	 source_acceptance_test/utils/json_schema_helper.py     105     13    88%   30-31, 38, 41, 65-68, 96, 120, 190-192
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1322    463    65%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_incremental.py:23: `future_state_path` not specified, skipping
================== 50 passed, 1 skipped in 448.71s (0:07:28) ===================

@bazarnov bazarnov merged commit ed9ee4a into master Aug 25, 2022
@bazarnov bazarnov deleted the baz/source-zendesk-chat-unit-tests branch August 25, 2022 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🎉 Source Zendesk Chat: increase unit_test coverage up to 90%
3 participants