Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: helm. Revert imagePullSecrets changes #15967

Merged
merged 8 commits into from
Aug 25, 2022
Merged

Conversation

xpuska513
Copy link
Contributor

What

  • revert changes made to imagePullSecrets

@github-actions github-actions bot added area/platform issues related to the platform kubernetes labels Aug 25, 2022
Copy link
Contributor

@supertopher supertopher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@xpuska513 xpuska513 merged commit f8ba211 into master Aug 25, 2022
@xpuska513 xpuska513 deleted the update-oss-charts branch August 25, 2022 14:48
rodireich pushed a commit that referenced this pull request Aug 25, 2022
* fix: revert extraEnv. Move updated extraEnv to env_vars

* fix: Add node pool selector feature for gke deployments

* fix: hotfix. Fix webapp values and imagepullsecrets

* fix: remove nodeSelector duplicate

* fix: revert imagePullSecrets changes

* fix nit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/platform issues related to the platform kubernetes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants