Upgrade OpenAPI Generator to 6.1.0-SNAPSHOT #16026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/api
cgardens
approved these changes
Aug 26, 2022
airbyte-server/src/main/java/io/airbyte/server/handlers/WebBackendConnectionsHandler.java
Outdated
Show resolved
Hide resolved
davinchia
reviewed
Aug 27, 2022
| @@ -22,7 +24,7 @@ task generateApiServerLegacy(type: GenerateTask) { | |||
| invokerPackage = "io.airbyte.api.invoker.generated" | |||
| modelPackage = "io.airbyte.api.model.generated" | |||
|
|
|||
| importMappings = [ | |||
| schemaMappings = [ | |||
There was a problem hiding this comment.
is this a change in the plugin syntax?
davinchia
approved these changes
Aug 27, 2022
There was a problem hiding this comment.
Thanks @pmossman ! Great stuff getting this in!
Just to make sure I understand, the non-api related generation code here is adjusting things to conform to our new behaviour of a null field = not set, and an empty field = set to empty. Is that right?
|
Yes @davinchia that's right! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Upgrade our version of openapi-generator to the latest, so that we can take advantage of the fix we sponsored here: OpenAPITools/openapi-generator#13025
The core change in this version of openapi-generator is that schemas with optional array fields are now instantiated in Java as
nullinstead ofnew ArrayList<>(). We need this new behavior to implement PATCH update requests, so that clients can leave array fields asnullto indicate that they should be left unchanged.This unblocks our issue to make the Connection Update endpoint use PATCH semantics: https://github.com/airbytehq/airbyte-cloud/issues/2064
How
Note to reviewers:
config.yamluntouched, but there are some cases where I could see an argument for marking an array field asrequired, which would force it to be generated as an emptyArrayListlike before. For example, ourConnectionReadcurrently specifiesoperationIdsas an optional array field. Does this make sense? Or would it be clearer to actually specifyoperationIdsasrequired, since it isn't really clear whatnullmeans when reading aConnection. Perhaps it would always be clearer to have an explicit empty array unless otherwise specified.