Source DB2: Add custom jdbc params #16354

yurii-bidiuk · 2022-09-06T11:38:18Z

What

Fixes #10725

How

Added jdbc_url_params to the spec

🚨 User Impact 🚨

No impact

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

github-actions · 2022-09-06T11:39:09Z

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to run corresponding integration tests:

source-db2
source-db2-strict-encrypt

github-actions · 2022-09-06T11:40:04Z

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to run corresponding integration tests:

source-db2
source-db2-strict-encrypt

yurii-bidiuk · 2022-09-06T11:41:48Z

/test connector=connectors/source-db2

🕑 connectors/source-db2 https://github.com/airbytehq/airbyte/actions/runs/2999868387
❌ connectors/source-db2 https://github.com/airbytehq/airbyte/actions/runs/2999868387
🐛 https://gradle.com/s/tare5zvws6ea6

Build Failed

Test summary info:

Could not find result summary

github-actions · 2022-09-06T11:42:06Z

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to run corresponding integration tests:

source-db2
source-db2-strict-encrypt

yurii-bidiuk · 2022-09-06T11:42:33Z

/test connector=connectors/source-db2-strict-encrypt

🕑 connectors/source-db2-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/2999873257
❌ connectors/source-db2-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/2999873257
🐛

alexandr-shegeda

LGTM. please make sure that the tests pass and then we can proceed with publishing and merging.

yurii-bidiuk · 2022-09-06T14:28:33Z

/test connector=connectors/source-db2

🕑 connectors/source-db2 https://github.com/airbytehq/airbyte/actions/runs/3000980983
✅ connectors/source-db2 https://github.com/airbytehq/airbyte/actions/runs/3000980983
No Python unittests run

Build Passed

Test summary info:

All Passed

yurii-bidiuk · 2022-09-06T14:28:41Z

/test connector=connectors/source-db2-strict-encrypt

🕑 connectors/source-db2-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/3000982442
✅ connectors/source-db2-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/3000982442
No Python unittests run

Build Passed

Test summary info:

All Passed

github-actions · 2022-09-06T14:29:24Z

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to run corresponding integration tests:

source-db2-strict-encrypt
source-db2

github-actions · 2022-09-06T17:29:43Z

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to run corresponding integration tests:

source-db2
source-db2-strict-encrypt

yurii-bidiuk · 2022-09-06T17:30:26Z

/publish connector=connectors/source-db2

🕑 Publishing the following connectors:
connectors/source-db2
https://github.com/airbytehq/airbyte/actions/runs/3002172700

Connector	Did it publish?	Were definitions generated?
connectors/source-db2	✅	✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

yurii-bidiuk · 2022-09-06T17:30:42Z

/publish connector=connectors/source-db2-strict-encrypt

🕑 Publishing the following connectors:
connectors/source-db2-strict-encrypt
https://github.com/airbytehq/airbyte/actions/runs/3002174241

Connector	Did it publish?	Were definitions generated?
connectors/source-db2-strict-encrypt	✅	❌

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

* DB2 add custom jdbc params * bump version * auto-bump connector version [ci skip] Co-authored-by: Octavia Squidington III <[email protected]>

github-actions bot added the area/connectors Connector related issues label Sep 6, 2022

octavia-squidington-iii added the connectors/source/db2 label Sep 6, 2022

yurii-bidiuk force-pushed the bidiuk/10725-db2-jdbc-params branch from 5259f1a to fb0c3d2 Compare September 6, 2022 11:39

yurii-bidiuk force-pushed the bidiuk/10725-db2-jdbc-params branch from fb0c3d2 to f5d96cb Compare September 6, 2022 11:41

octavia-squidington-iii added the connectors/source/db2-strict-encrypt label Sep 6, 2022

yurii-bidiuk requested review from alexandr-shegeda, DoNotPanicUA and kimerinn September 6, 2022 11:43

alexandr-shegeda marked this pull request as ready for review September 6, 2022 12:44

alexandr-shegeda requested a review from a team as a code owner September 6, 2022 12:44

alexandr-shegeda approved these changes Sep 6, 2022

View reviewed changes

DB2 add custom jdbc params

24c42a9

yurii-bidiuk force-pushed the bidiuk/10725-db2-jdbc-params branch from f5d96cb to 24c42a9 Compare September 6, 2022 14:28

bump version

35ae68e

github-actions bot added the area/documentation Improvements or additions to documentation label Sep 6, 2022

auto-bump connector version [ci skip]

b0aa2d5

yurii-bidiuk merged commit dd6baf9 into master Sep 6, 2022

yurii-bidiuk deleted the bidiuk/10725-db2-jdbc-params branch September 6, 2022 18:44

octavia-squidington-iii mentioned this pull request Sep 12, 2022

Bump Airbyte version from 0.40.4 to 0.40.5 #16610

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Source DB2: Add custom jdbc params #16354

Source DB2: Add custom jdbc params #16354

yurii-bidiuk commented Sep 6, 2022 •

edited by alexandr-shegeda

Loading

github-actions bot commented Sep 6, 2022

github-actions bot commented Sep 6, 2022

yurii-bidiuk commented Sep 6, 2022 •

edited by github-actions bot

Loading

github-actions bot commented Sep 6, 2022

yurii-bidiuk commented Sep 6, 2022 •

edited by github-actions bot

Loading

alexandr-shegeda left a comment

yurii-bidiuk commented Sep 6, 2022 •

edited by github-actions bot

Loading

yurii-bidiuk commented Sep 6, 2022 •

edited by github-actions bot

Loading

github-actions bot commented Sep 6, 2022

github-actions bot commented Sep 6, 2022

yurii-bidiuk commented Sep 6, 2022 •

edited by github-actions bot

Loading

yurii-bidiuk commented Sep 6, 2022 •

edited by github-actions bot

Loading

Source DB2: Add custom jdbc params #16354

Source DB2: Add custom jdbc params #16354

Conversation

yurii-bidiuk commented Sep 6, 2022 • edited by alexandr-shegeda Loading

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

Tests

github-actions bot commented Sep 6, 2022

github-actions bot commented Sep 6, 2022

yurii-bidiuk commented Sep 6, 2022 • edited by github-actions bot Loading

Build Failed

github-actions bot commented Sep 6, 2022

yurii-bidiuk commented Sep 6, 2022 • edited by github-actions bot Loading

alexandr-shegeda left a comment

Choose a reason for hiding this comment

yurii-bidiuk commented Sep 6, 2022 • edited by github-actions bot Loading

Build Passed

yurii-bidiuk commented Sep 6, 2022 • edited by github-actions bot Loading

Build Passed

github-actions bot commented Sep 6, 2022

github-actions bot commented Sep 6, 2022

yurii-bidiuk commented Sep 6, 2022 • edited by github-actions bot Loading

yurii-bidiuk commented Sep 6, 2022 • edited by github-actions bot Loading

yurii-bidiuk commented Sep 6, 2022 •

edited by alexandr-shegeda

Loading

yurii-bidiuk commented Sep 6, 2022 •

edited by github-actions bot

Loading

yurii-bidiuk commented Sep 6, 2022 •

edited by github-actions bot

Loading

yurii-bidiuk commented Sep 6, 2022 •

edited by github-actions bot

Loading

yurii-bidiuk commented Sep 6, 2022 •

edited by github-actions bot

Loading

yurii-bidiuk commented Sep 6, 2022 •

edited by github-actions bot

Loading

yurii-bidiuk commented Sep 6, 2022 •

edited by github-actions bot

Loading