-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛Source Amazon Seller Partner: Implement slicing for report streams #16430
🐛Source Amazon Seller Partner: Implement slicing for report streams #16430
Conversation
/test connector=connectors/source-amazon-seller-partner
Build FailedTest summary info:
|
...te-integrations/connectors/source-amazon-seller-partner/source_amazon_seller_partner/spec.py
Outdated
Show resolved
Hide resolved
/test connector=connectors/source-amazon-seller-partner
Build FailedTest summary info:
|
/test connector=connectors/source-amazon-seller-partner
Build FailedTest summary info:
|
Are you sure that it can't be more than 30 days? Some reports can requested with 60 day period. For example you can find https://developer-docs.amazon.com/sp-api/docs/report-type-values So please do not restrict period_in_days. |
@animer3009 well I can't be sure of anything since this is Amazon API 😅 |
…-implement-slicing
/test connector=connectors/source-amazon-seller-partner
Build FailedTest summary info:
|
@lazebnyi @bazarnov |
Yes, we saw your comments. Thanks for that🙏 We will try implement different rages for different streams. That's not final version of PR. Just draft 😊 |
/test connector=connectors/source-amazon-seller-partner
Build PassedTest summary info:
|
/test connector=connectors/source-amazon-seller-partner
|
…-implement-slicing
/test connector=connectors/source-amazon-seller-partner
Build PassedTest summary info:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The acceptance-test-config.yml
file looks good to me now that the test_strictness_level
is not set to high
.
You are introducing a small backward incompatible change:
Users with configuration with the period_in_days
to a value > 30 will likely get a check command failure.
Please sync up with @airbytehq/cloud-support before merging to make sure outreach is sent to the customer using this connector.
@alafanechere I just checked and there is only one workspace on Cloud that has this connector setup and it is internal (@amaliaroye) so there is no outreach necessary from TCS. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No outreach necessary as there are no Cloud users impacted by this update.
Guys,
So the main question is: |
@animer3009 Thanks! We decide increase max value for |
/test connector=connectors/source-amazon-seller-partner
Build PassedTest summary info:
Build PassedTest summary info:
|
…-implement-slicing
/test connector=connectors/source-amazon-seller-partner
Build PassedTest summary info:
|
/publish connector=connectors/source-amazon-seller-partner
if you have connectors that successfully published but failed definition generation, follow step 4 here |
Airbyte Code Coverage
|
What
https://github.com/airbytehq/alpha-beta-issues/issues/257
GET_FBA_INVENTORY_AGED_DATA
andGET_VENDOR_INVENTORY_HEALTH_AND_PLANNING_REPORT
as deprecated - https://github.com/amzn/selling-partner-api-docs/discussions/2165