feat: Update release workflow #16642
Conversation
github-actions
bot
added
area/platform
| - name: Commit and push changes | ||
| uses: EndBug/add-and-commit@v9 | ||
| with: | ||
| message: 'Bump subchart version to ${{ steps.release_airbyte.outputs.NEW_VERSION }}' | ||
| add: '.' | ||
| cwd: './github/helm-charts' | ||
|
|
||
| - name: Release main helm chart | ||
| shell: bash | ||
| run: | | ||
| cd ./charts/airbyte && helm dep update && cd - | ||
| helm package ./charts/airbyte -d ./.github/helm-charts --version ${{ steps.release_airbyte.outputs.NEW_VERSION }} | ||
| helm repo index ./.github/helm-charts/ | ||
|
|
||
| - name: Commit and push changes | ||
| uses: EndBug/add-and-commit@v9 | ||
| with: | ||
| message: 'Bump main chart version to ${{ steps.release_airbyte.outputs.NEW_VERSION }}' | ||
| add: '.' | ||
| cwd: './github/helm-charts' |
There was a problem hiding this comment.
should all of this happen in an action?
in that way we can reuse this in the publish for Cloud workflow as well as the individual Helm publish workflow
There was a problem hiding this comment.
Makes sense, let me update it and put it into separate action then
tools/bin/release_version.sh
Outdated
| @@ -37,3 +37,12 @@ VERSION=$NEW_VERSION SUB_BUILD=PLATFORM ./gradlew publish | |||
| docker run --rm --privileged multiarch/qemu-user-static --reset -p yes | |||
| VERSION=$NEW_VERSION ./tools/bin/publish_docker.sh | |||
| echo "Completed building and publishing PLATFORM..." | |||
|
|
|||
| echo "Packaging and publishing HELM CHARTS version $NEW_VERSION for git revision $GIT_REVISION..." | |||
There was a problem hiding this comment.
Curious, why release the subcharts in a spot different from the main helm charts?
There was a problem hiding this comment.
I've already covered it during our call, made it that way since we're packaging main chart using dependencies that were already published, I can make it use local dependencies but don't know how it will work and probably this approach will require clonning of the remote git repo in order to deploy it.
There was a problem hiding this comment.
Yeah. What I'm asking is why do this in this spot instead of in the Github Action? It seems like this can be combined with the above action. It's somewhat confusing today since the subcharts are released at a different spot from the main chart so it's not obvious we have to release the subchart before the main charts.
There was a problem hiding this comment.
I see, already made an action for it, will push updated workflow
There was a problem hiding this comment.
@davinchia updated + added workflow for publishing charts manually(separately from the OSS releases)
What
How
Notes
The hotfix workflow will be disabled(only workflow dispatch will be left), for testing purposes.