🎉 Source Chargebee: add "custom fields" to the relevant data streams #17056

darynaishchenko · 2022-09-22T16:48:52Z

What

Add Chargebee "custom fields" to the relevant Chargebee source data streams.
Resolving:
#14002

How

Added functionality to define a custom fields.

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

CLAassistant · 2022-09-22T16:48:56Z

All committers have signed the CLA.

airbyte-integrations/connectors/source-chargebee/source_chargebee/schemas/addon.json

bazarnov · 2022-09-23T09:53:10Z

Also, please sign this CLA License Agreement.

bazarnov · 2022-09-23T12:53:36Z

/test connector=connectors/source-chargebee

🕑 connectors/source-chargebee https://github.com/airbytehq/airbyte/actions/runs/3112888935
✅ connectors/source-chargebee https://github.com/airbytehq/airbyte/actions/runs/3112888935
Python tests coverage:

Name                                Stmts   Miss  Cover
-------------------------------------------------------
source_chargebee/source.py             25      0   100%
source_chargebee/__init__.py            2      0   100%
source_chargebee/streams.py           161      9    94%
source_chargebee/utils.py               9      3    67%
source_chargebee/rate_limiting.py      19      7    63%
-------------------------------------------------------
TOTAL                                 216     19    91%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          10      4    60%   15-18
	 source_acceptance_test/config.py                        83      6    93%   78-80, 84-86
	 source_acceptance_test/conftest.py                     164    164     0%   6-282
	 source_acceptance_test/plugin.py                        48     48     0%   6-104
	 source_acceptance_test/tests/test_core.py              329    111    66%   39, 50-58, 63-70, 74-75, 79-80, 164, 202-219, 228-236, 240-245, 251, 284-289, 327-334, 374-376, 379, 439-448, 477-478, 484, 487, 520-530, 543-568, 573-577
	 source_acceptance_test/tests/test_full_refresh.py       52      2    96%   34, 65
	 source_acceptance_test/tests/test_incremental.py       121     25    79%   21-23, 29-31, 36-43, 48-61, 208-216
	 source_acceptance_test/utils/asserts.py                 37      2    95%   57-58
	 source_acceptance_test/utils/common.py                  77     17    78%   15-16, 24-30, 47-54, 64, 67
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       110     48    56%   23-26, 32, 36, 39-64, 67-69, 72-74, 77-79, 82-84, 87-89, 92-110, 144-146
	 source_acceptance_test/utils/json_schema_helper.py     105     13    88%   30-31, 38, 41, 65-68, 96, 120, 190-192
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1325    463    65%

Build Passed

Test summary info:

All Passed

bazarnov · 2022-09-23T12:57:49Z

Please do the following in addition:

bump the version of the Dockerfile to 0.1.14
edit the changelog accordingly

darynaishchenko · 2022-09-23T13:39:47Z

/test connector=connectors/source-chargebee

🕑 connectors/source-chargebee https://github.com/airbytehq/airbyte/actions/runs/3113161775
✅ connectors/source-chargebee https://github.com/airbytehq/airbyte/actions/runs/3113161775
Python tests coverage:

Name                                Stmts   Miss  Cover
-------------------------------------------------------
source_chargebee/source.py             25      0   100%
source_chargebee/__init__.py            2      0   100%
source_chargebee/streams.py           161      9    94%
source_chargebee/utils.py               8      1    88%
source_chargebee/rate_limiting.py      19      7    63%
-------------------------------------------------------
TOTAL                                 215     17    92%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          10      4    60%   15-18
	 source_acceptance_test/config.py                        83      6    93%   78-80, 84-86
	 source_acceptance_test/conftest.py                     164    164     0%   6-282
	 source_acceptance_test/plugin.py                        48     48     0%   6-104
	 source_acceptance_test/tests/test_core.py              329    111    66%   39, 50-58, 63-70, 74-75, 79-80, 164, 202-219, 228-236, 240-245, 251, 284-289, 327-334, 374-376, 379, 439-448, 477-478, 484, 487, 520-530, 543-568, 573-577
	 source_acceptance_test/tests/test_full_refresh.py       52      2    96%   34, 65
	 source_acceptance_test/tests/test_incremental.py       121     25    79%   21-23, 29-31, 36-43, 48-61, 208-216
	 source_acceptance_test/utils/asserts.py                 37      2    95%   57-58
	 source_acceptance_test/utils/common.py                  77     17    78%   15-16, 24-30, 47-54, 64, 67
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       110     48    56%   23-26, 32, 36, 39-64, 67-69, 72-74, 77-79, 82-84, 87-89, 92-110, 144-146
	 source_acceptance_test/utils/json_schema_helper.py     105     13    88%   30-31, 38, 41, 65-68, 96, 120, 190-192
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1325    463    65%

Build Passed

Test summary info:

All Passed

bazarnov

Nice!

darynaishchenko · 2022-09-26T07:15:10Z

/publish connector=connectors/source-chargebee

🕑 Publishing the following connectors:
connectors/source-chargebee
https://github.com/airbytehq/airbyte/actions/runs/3125769420

Connector	Did it publish?	Were definitions generated?
connectors/source-chargebee	✅	✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

…a streams. (airbytehq#17056) * Chargebee: added custom fields * Chargebee: added value types json schema * Chargebee: added docs, updated docker label, refactored utils * auto-bump connector version [ci skip] Co-authored-by: Octavia Squidington III <[email protected]>

Chargebee: added custom fields

a29d336

darynaishchenko requested review from bazarnov and roman-yermilov-gl September 22, 2022 16:48

darynaishchenko self-assigned this Sep 22, 2022

github-actions bot added the area/connectors Connector related issues label Sep 22, 2022

darynaishchenko linked an issue Sep 22, 2022 that may be closed by this pull request

Add Chargebee "custom fields" to Chargebee connector data streams #14002

Closed

bazarnov approved these changes Sep 23, 2022

View reviewed changes

airbyte-integrations/connectors/source-chargebee/source_chargebee/schemas/addon.json Outdated Show resolved Hide resolved

Chargebee: added value types json schema

2dc3cb1

bazarnov approved these changes Sep 23, 2022

View reviewed changes

Chargebee: added docs, updated docker label, refactored utils

3d00a69

github-actions bot added the area/documentation Improvements or additions to documentation label Sep 23, 2022

darynaishchenko requested a review from bazarnov September 23, 2022 14:08

bazarnov approved these changes Sep 23, 2022

View reviewed changes

auto-bump connector version [ci skip]

9980e8c

bazarnov changed the title ~~Chargebee: Added "custom fields" to the relevant Chargebee source data streams.~~ 🎉 Source Chargebee: add "custom fields" to the relevant data streams Sep 26, 2022

darynaishchenko merged commit b8a6472 into master Sep 26, 2022

darynaishchenko deleted the daryna/add-chargebee-custom-fields-to-connector-data-streams branch September 26, 2022 08:16

This was referenced Sep 27, 2022

Bump Airbyte version from 0.40.9 to 0.40.10 #17285

Closed

Bump Airbyte version from 0.40.9 to 0.40.10 #17359

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🎉 Source Chargebee: add "custom fields" to the relevant data streams #17056

🎉 Source Chargebee: add "custom fields" to the relevant data streams #17056

darynaishchenko commented Sep 22, 2022

CLAassistant commented Sep 22, 2022 •

edited

Loading

bazarnov commented Sep 23, 2022

bazarnov commented Sep 23, 2022 •

edited by github-actions bot

Loading

bazarnov commented Sep 23, 2022

darynaishchenko commented Sep 23, 2022 •

edited by github-actions bot

Loading

bazarnov left a comment

darynaishchenko commented Sep 26, 2022 •

edited by github-actions bot

Loading

🎉 Source Chargebee: add "custom fields" to the relevant data streams #17056

🎉 Source Chargebee: add "custom fields" to the relevant data streams #17056

Conversation

darynaishchenko commented Sep 22, 2022

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

Tests

CLAassistant commented Sep 22, 2022 • edited Loading

bazarnov commented Sep 23, 2022

bazarnov commented Sep 23, 2022 • edited by github-actions bot Loading

Build Passed

bazarnov commented Sep 23, 2022

darynaishchenko commented Sep 23, 2022 • edited by github-actions bot Loading

Build Passed

bazarnov left a comment

Choose a reason for hiding this comment

darynaishchenko commented Sep 26, 2022 • edited by github-actions bot Loading

CLAassistant commented Sep 22, 2022 •

edited

Loading

bazarnov commented Sep 23, 2022 •

edited by github-actions bot

Loading

darynaishchenko commented Sep 23, 2022 •

edited by github-actions bot

Loading

darynaishchenko commented Sep 26, 2022 •

edited by github-actions bot

Loading