Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🪟 🎨 Improve styling of sidebar #17072

Merged
merged 2 commits into from
Sep 26, 2022
Merged

🪟 🎨 Improve styling of sidebar #17072

merged 2 commits into from
Sep 26, 2022

Conversation

timroes
Copy link
Collaborator

@timroes timroes commented Sep 23, 2022

What

Improve design of the sidebar slightly:

  • Add missing outline for the menu buttons so that they are properly focusable via keyboard.
    screenshot-20220923-052553
  • Give the workspace selector button an outline as well.
  • Darken the hover/active color in the menu a bit, since the current one is barely distinguishable from the regular white color so the active element is very hard to detect:
    screenshot-20220923-052644

@timroes timroes requested a review from a team as a code owner September 23, 2022 03:29
@github-actions github-actions bot added area/platform issues related to the platform area/frontend Related to the Airbyte webapp labels Sep 23, 2022
krishnaglick
krishnaglick approved these changes Sep 23, 2022
View reviewed changes
Copy link
Contributor

@krishnaglick krishnaglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tested in OSS.

@timroes
Copy link
Collaborator Author

timroes commented Sep 26, 2022

Github labeling action failed, ignoring this for merging.

@timroes timroes merged commit 871929d into master Sep 26, 2022
@timroes timroes deleted the tim/sidebar-design-fixes branch September 26, 2022 14:48
This was referenced Sep 27, 2022
Closed
Merged
robbinhan pushed a commit to robbinhan/airbyte that referenced this pull request Sep 29, 2022
@timroes @robbinhan
Improve styling of sidebar (airbytehq#17072)
0adbb98
jhammarstedt pushed a commit to jhammarstedt/airbyte that referenced this pull request Oct 31, 2022
@timroes @jhammarstedt
Improve styling of sidebar (airbytehq#17072)
c99ca83
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krishnaglick krishnaglick krishnaglick approved these changes

Assignees
No one assigned
Labels
area/frontend Related to the Airbyte webapp area/platform issues related to the platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timroes @krishnaglick