Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛Destination-snowflake: added connection string identifier #17115

Merged
merged 4 commits into from
Sep 26, 2022
Merged

🐛Destination-snowflake: added connection string identifier #17115

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
28fbde5
[16767] Destination-snowflake: added connection string identifier
etsybaev Sep 24, 2022
2316f11
Merge branch 'master' into etsybaev/16767-destination-snowflake-added…
etsybaev Sep 26, 2022
98c5d59
bumped version
etsybaev Sep 26, 2022
8189906
auto-bump connector version [ci skip]
octavia-squidington-iii Sep 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion airbyte-config/init/src/main/resources/seed/destination_definitions.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,7 +277,7 @@
- name: Snowflake
destinationDefinitionId: 424892c4-daac-4491-b35d-c6688ba547ba
dockerRepository: airbyte/destination-snowflake
dockerImageTag: 0.4.37
dockerImageTag: 0.4.38
documentationUrl: https://docs.airbyte.io/integrations/destinations/snowflake
icon: snowflake.svg
resourceRequirements:
Expand Down
2 changes: 1 addition & 1 deletion airbyte-config/init/src/main/resources/seed/destination_specs.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4850,7 +4850,7 @@
supported_destination_sync_modes:
- "overwrite"
- "append"
- dockerImage: "airbyte/destination-snowflake:0.4.37"
- dockerImage: "airbyte/destination-snowflake:0.4.38"
spec:
documentationUrl: "https://docs.airbyte.io/integrations/destinations/snowflake"
connectionSpecification:
Expand Down
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/destination-snowflake/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,5 +20,5 @@ RUN tar xf ${APPLICATION}.tar --strip-components=1

ENV ENABLE_SENTRY true

LABEL io.airbyte.version=0.4.37
LABEL io.airbyte.version=0.4.38
LABEL io.airbyte.name=airbyte/destination-snowflake
3 changes: 3 additions & 0 deletions ...wflake/src/main/java/io/airbyte/integrations/destination/snowflake/SnowflakeDatabase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,8 @@ public class SnowflakeDatabase {
public static final String PRIVATE_KEY_FILE_NAME = "rsa_key.p8";
public static final String PRIVATE_KEY_FIELD_NAME = "private_key";
public static final String PRIVATE_KEY_PASSWORD = "private_key_password";
private static final String CONNECTION_STRING_IDENTIFIER_KEY = "application";
private static final String CONNECTION_STRING_IDENTIFIER_VAL = "Airbyte_Connector";

public static HikariDataSource createDataSource(final JsonNode config) {
final HikariDataSource dataSource = new HikariDataSource();
Expand All @@ -78,6 +80,7 @@ public static HikariDataSource createDataSource(final JsonNode config) {
} catch (final IOException e) {
throw new RuntimeException(e);
}
properties.put(CONNECTION_STRING_IDENTIFIER_KEY, CONNECTION_STRING_IDENTIFIER_VAL);
properties.put("client_id", credentials.get("client_id").asText());
properties.put("client_secret", credentials.get("client_secret").asText());
properties.put("refresh_token", credentials.get("refresh_token").asText());
Expand Down
1 change: 1 addition & 0 deletions docs/integrations/destinations/snowflake.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,6 +275,7 @@ Now that you have set up the Snowflake destination connector, check out the foll

| Version | Date | Pull Request | Subject |
|:--------|:-----------|:-----------------------------------------------------------|:----------------------------------------------------------------------------------------------------------------------------------------------------|
| 0.4.38 | 2022-09-26 | [\#17115](https://github.com/airbytehq/airbyte/pull/17115) | Added connection string identifier |
| 0.4.37 | 2022-09-21 | [\#16839](https://github.com/airbytehq/airbyte/pull/16839) | Update JDBC driver for Snowflake to 3.13.19 |
| 0.4.36 | 2022-09-14 | [\#15668](https://github.com/airbytehq/airbyte/pull/15668) | Wrap logs in AirbyteLogMessage |
| 0.4.35 | 2022-09-01 | [\#16243](https://github.com/airbytehq/airbyte/pull/16243) | Fix Json to Avro conversion when there is field name clash from combined restrictions (`anyOf`, `oneOf`, `allOf` fields). |
Expand Down