Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source acceptance test: bugfix #17757

Merged
merged 7 commits into from
Oct 12, 2022

Conversation

davydov-d
Copy link
Collaborator

What

  • change latest_state to stream_name_to_per_stream_state in get_next_state_input so that returned input state is not the same each time the function is called
  • remove latest_state from get_next_state_input args as it is no more used
  • simplify building checkpoint message groups as the record messages are not used as well

@davydov-d
Copy link
Collaborator Author

davydov-d commented Oct 7, 2022

/test connector=connectors/source-iterable

🕑 connectors/source-iterable https://github.com/airbytehq/airbyte/actions/runs/3207014145
✅ connectors/source-iterable https://github.com/airbytehq/airbyte/actions/runs/3207014145
Python tests coverage:

Name                                  Stmts   Miss  Cover
---------------------------------------------------------
source_iterable/source.py                20      0   100%
source_iterable/__init__.py               2      0   100%
source_iterable/slice_generators.py      71      5    93%
source_iterable/streams.py              342     46    87%
---------------------------------------------------------
TOTAL                                   435     51    88%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          10      4    60%   15-18
	 source_acceptance_test/config.py                        83      6    93%   78-80, 84-86
	 source_acceptance_test/conftest.py                     164    164     0%   6-282
	 source_acceptance_test/plugin.py                        48     48     0%   6-104
	 source_acceptance_test/tests/test_core.py              329    111    66%   39, 50-58, 63-70, 74-75, 79-80, 164, 202-219, 228-236, 240-245, 251, 284-289, 327-334, 374-376, 379, 439-448, 477-478, 484, 487, 520-530, 543-568, 573-577
	 source_acceptance_test/tests/test_full_refresh.py       52      2    96%   34, 65
	 source_acceptance_test/tests/test_incremental.py       145     26    82%   21-23, 29-31, 36-43, 48-61, 224, 235-243
	 source_acceptance_test/utils/asserts.py                 37      2    95%   57-58
	 source_acceptance_test/utils/common.py                  77     17    78%   15-16, 24-30, 47-54, 64, 67
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       112     50    55%   23-26, 32, 36, 39-67, 70-72, 75-77, 80-82, 85-87, 90-92, 95-113, 147-149
	 source_acceptance_test/utils/json_schema_helper.py     105     13    88%   30-31, 38, 41, 65-68, 96, 120, 190-192
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1351    466    66%

Build Passed

Test summary info:

All Passed

@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2022

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to run corresponding integration tests:

  • source-confluence
  • source-zendesk-talk
  • source-harvest
  • source-prestashop
  • source-outreach
  • source-mailgun
  • source-freshsales
  • source-instagram
  • source-freshservice
  • source-amazon-sqs
  • source-twilio
  • source-salesforce
  • source-onesignal
  • source-sentry
  • source-gitlab
  • source-youtube-analytics
  • source-pardot
  • source-posthog
  • source-amplitude
  • source-drift
  • source-lever-hiring
  • source-zendesk-sunshine
  • source-cart
  • source-surveymonkey
  • source-commercetools
  • source-quickbooks-singer
  • source-azure-table
  • source-pinterest
  • source-zenloop
  • source-iterable
  • source-tplcentral
  • source-google-search-console
  • source-facebook-pages
  • source-delighted
  • source-recharge
  • source-openweather
  • source-google-ads
  • source-facebook-marketing
  • source-airtable
  • source-lemlist
  • source-appsflyer
  • source-sendgrid
  • source-monday
  • source-freshcaller
  • source-strava
  • source-amazon-seller-partner
  • source-klaviyo
  • source-braintree
  • source-plaid
  • source-github
  • source-paystack
  • source-greenhouse
  • source-amazon-ads
  • source-chargebee
  • source-okta
  • source-notion
  • source-asana
  • source-linnworks
  • source-retently
  • source-salesloft
  • source-mailchimp
  • source-pipedrive

@davydov-d
Copy link
Collaborator Author

davydov-d commented Oct 7, 2022

/test connector=bases/source-acceptance-test

🕑 bases/source-acceptance-test https://github.com/airbytehq/airbyte/actions/runs/3207021120
✅ bases/source-acceptance-test https://github.com/airbytehq/airbyte/actions/runs/3207021120
No Python unittests run

Build Passed

Test summary info:

All Passed

@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2022

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to run corresponding integration tests:

  • source-airtable
  • source-okta
  • source-salesforce
  • source-prestashop
  • source-posthog
  • source-klaviyo
  • source-linnworks
  • source-braintree
  • source-appsflyer
  • source-sentry
  • source-commercetools
  • source-amplitude
  • source-google-search-console
  • source-freshservice
  • source-pipedrive
  • source-amazon-sqs
  • source-mailgun
  • source-chargebee
  • source-strava
  • source-twilio
  • source-tplcentral
  • source-lever-hiring
  • source-pardot
  • source-openweather
  • source-paystack
  • source-delighted
  • source-cart
  • source-facebook-marketing
  • source-freshsales
  • source-amazon-seller-partner
  • source-salesloft
  • source-retently
  • source-plaid
  • source-youtube-analytics
  • source-monday
  • source-mailchimp
  • source-drift
  • source-greenhouse
  • source-freshcaller
  • source-google-ads
  • source-iterable
  • source-azure-table
  • source-recharge
  • source-harvest
  • source-lemlist
  • source-zendesk-sunshine
  • source-quickbooks-singer
  • source-instagram
  • source-gitlab
  • source-asana
  • source-zendesk-talk
  • source-notion
  • source-surveymonkey
  • source-outreach
  • source-sendgrid
  • source-confluence
  • source-amazon-ads
  • source-pinterest
  • source-github
  • source-onesignal
  • source-facebook-pages
  • source-zenloop

Copy link
Contributor

@brianjlai brianjlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look good. but let's run this against a couple more different connector just to verify no regressions. Hubspot is an especially good one because some streams have enough records to result in multiple slices in a sync.

@brianjlai
Copy link
Contributor

brianjlai commented Oct 9, 2022

/test connector=connectors/source-hubspot

🕑 connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/3212802379
✅ connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/3212802379
Python tests coverage:

Name                          Stmts   Miss  Cover
-------------------------------------------------
source_hubspot/errors.py          6      0   100%
source_hubspot/constants.py       3      0   100%
source_hubspot/__init__.py        2      0   100%
source_hubspot/helpers.py        70      7    90%
source_hubspot/source.py         90     19    79%
source_hubspot/streams.py       837    202    76%
-------------------------------------------------
TOTAL                          1008    228    77%
Name                          Stmts   Miss  Cover
-------------------------------------------------
source_hubspot/errors.py          6      0   100%
source_hubspot/constants.py       3      0   100%
source_hubspot/__init__.py        2      0   100%
source_hubspot/helpers.py        70      3    96%
source_hubspot/streams.py       837     77    91%
source_hubspot/source.py         90     18    80%
-------------------------------------------------
TOTAL                          1008     98    90%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          10      4    60%   15-18
	 source_acceptance_test/config.py                        83      6    93%   78-80, 84-86
	 source_acceptance_test/conftest.py                     164    164     0%   6-282
	 source_acceptance_test/plugin.py                        48     48     0%   6-104
	 source_acceptance_test/tests/test_core.py              329    111    66%   39, 50-58, 63-70, 74-75, 79-80, 164, 202-219, 228-236, 240-245, 251, 284-289, 327-334, 374-376, 379, 439-448, 477-478, 484, 487, 520-530, 543-568, 573-577
	 source_acceptance_test/tests/test_full_refresh.py       52      2    96%   34, 65
	 source_acceptance_test/tests/test_incremental.py       145     26    82%   21-23, 29-31, 36-43, 48-61, 224, 235-243
	 source_acceptance_test/utils/asserts.py                 37      2    95%   57-58
	 source_acceptance_test/utils/common.py                  77     17    78%   15-16, 24-30, 47-54, 64, 67
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       112     50    55%   23-26, 32, 36, 39-67, 70-72, 75-77, 80-82, 85-87, 90-92, 95-113, 147-149
	 source_acceptance_test/utils/json_schema_helper.py     105     13    88%   30-31, 38, 41, 65-68, 96, 120, 190-192
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1351    466    66%

Build Passed

Test summary info:

All Passed

@davydov-d
Copy link
Collaborator Author

davydov-d commented Oct 12, 2022

/test connector=connectors/source-tiktok-marketing

🕑 connectors/source-tiktok-marketing https://github.com/airbytehq/airbyte/actions/runs/3233413635
❌ connectors/source-tiktok-marketing https://github.com/airbytehq/airbyte/actions/runs/3233413635
🐛 https://gradle.com/s/to3ckbo4d5j3o

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_incremental.py::TestIncremental::test_read_sequential_slices[inputs1]
================== 1 failed, 92 passed in 5094.45s (1:24:54) ===================

@davydov-d
Copy link
Collaborator Author

davydov-d commented Oct 12, 2022

/test connector=connectors/source-greenhouse

🕑 connectors/source-greenhouse https://github.com/airbytehq/airbyte/actions/runs/3233415696
✅ connectors/source-greenhouse https://github.com/airbytehq/airbyte/actions/runs/3233415696
Python tests coverage:

Name                              Stmts   Miss  Cover
-----------------------------------------------------
source_greenhouse/source.py           4      0   100%
source_greenhouse/__init__.py         2      0   100%
source_greenhouse/components.py      68      5    93%
-----------------------------------------------------
TOTAL                                74      5    93%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          10      4    60%   15-18
	 source_acceptance_test/config.py                        83      6    93%   78-80, 84-86
	 source_acceptance_test/conftest.py                     164    164     0%   6-282
	 source_acceptance_test/plugin.py                        48     48     0%   6-104
	 source_acceptance_test/tests/test_core.py              329    111    66%   39, 50-58, 63-70, 74-75, 79-80, 164, 202-219, 228-236, 240-245, 251, 284-289, 327-334, 374-376, 379, 439-448, 477-478, 484, 487, 520-530, 543-568, 573-577
	 source_acceptance_test/tests/test_full_refresh.py       52      2    96%   34, 65
	 source_acceptance_test/tests/test_incremental.py       145     26    82%   21-23, 29-31, 36-43, 48-61, 224, 235-243
	 source_acceptance_test/utils/asserts.py                 37      2    95%   57-58
	 source_acceptance_test/utils/common.py                  77     17    78%   15-16, 24-30, 47-54, 64, 67
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       112     50    55%   23-26, 32, 36, 39-67, 70-72, 75-77, 80-82, 85-87, 90-92, 95-113, 147-149
	 source_acceptance_test/utils/json_schema_helper.py     105     13    88%   30-31, 38, 41, 65-68, 96, 120, 190-192
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1351    466    66%

Build Passed

Test summary info:

All Passed

@davydov-d
Copy link
Collaborator Author

davydov-d commented Oct 12, 2022

/test connector=connectors/source-snapchat-marketing

🕑 connectors/source-snapchat-marketing https://github.com/airbytehq/airbyte/actions/runs/3233419800
✅ connectors/source-snapchat-marketing https://github.com/airbytehq/airbyte/actions/runs/3233419800
Python tests coverage:

Name                                    Stmts   Miss  Cover
-----------------------------------------------------------
source_snapchat_marketing/__init__.py       2      0   100%
source_snapchat_marketing/source.py       277     22    92%
-----------------------------------------------------------
TOTAL                                     279     22    92%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          10      4    60%   15-18
	 source_acceptance_test/config.py                        83      6    93%   78-80, 84-86
	 source_acceptance_test/conftest.py                     164    164     0%   6-282
	 source_acceptance_test/plugin.py                        48     48     0%   6-104
	 source_acceptance_test/tests/test_core.py              329    111    66%   39, 50-58, 63-70, 74-75, 79-80, 164, 202-219, 228-236, 240-245, 251, 284-289, 327-334, 374-376, 379, 439-448, 477-478, 484, 487, 520-530, 543-568, 573-577
	 source_acceptance_test/tests/test_full_refresh.py       52      2    96%   34, 65
	 source_acceptance_test/tests/test_incremental.py       145     26    82%   21-23, 29-31, 36-43, 48-61, 224, 235-243
	 source_acceptance_test/utils/asserts.py                 37      2    95%   57-58
	 source_acceptance_test/utils/common.py                  77     17    78%   15-16, 24-30, 47-54, 64, 67
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       112     50    55%   23-26, 32, 36, 39-67, 70-72, 75-77, 80-82, 85-87, 90-92, 95-113, 147-149
	 source_acceptance_test/utils/json_schema_helper.py     105     13    88%   30-31, 38, 41, 65-68, 96, 120, 190-192
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1351    466    66%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_incremental.py:23: `future_state_path` not specified, skipping
================== 37 passed, 1 skipped in 266.86s (0:04:26) ===================

@davydov-d
Copy link
Collaborator Author

builds passed, except for tiktok (failed due to timeout), so I'm publishing this change

@davydov-d
Copy link
Collaborator Author

davydov-d commented Oct 12, 2022

/publish connector=bases/source-acceptance-test auto-bump-version=false

🕑 Publishing the following connectors:
bases/source-acceptance-test
https://github.com/airbytehq/airbyte/actions/runs/3234639771


Connector Did it publish? Were definitions generated?
bases/source-acceptance-test

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@davydov-d
Copy link
Collaborator Author

davydov-d commented Oct 12, 2022

/publish connector=bases/source-acceptance-test auto-bump-version=false

🕑 Publishing the following connectors:
bases/source-acceptance-test
https://github.com/airbytehq/airbyte/actions/runs/3234738207


Connector Did it publish? Were definitions generated?
bases/source-acceptance-test

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@github-actions
Copy link
Contributor

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to run corresponding integration tests:

  • source-facebook-marketing
  • source-posthog
  • source-onesignal
  • source-freshcaller
  • source-plaid
  • source-openweather
  • source-confluence
  • source-mailgun
  • source-amazon-seller-partner
  • source-mailchimp
  • source-pinterest
  • source-azure-table
  • source-lever-hiring
  • source-notion
  • source-pipedrive
  • source-paystack
  • source-tplcentral
  • source-appsflyer
  • source-salesforce
  • source-braintree
  • source-greenhouse
  • source-outreach
  • source-klaviyo
  • source-instagram
  • source-harvest
  • source-zendesk-sunshine
  • source-airtable
  • source-lemlist
  • source-amazon-sqs
  • source-surveymonkey
  • source-twilio
  • source-prestashop
  • source-salesloft
  • source-recharge
  • source-amplitude
  • source-strava
  • source-sentry
  • source-retently
  • source-quickbooks-singer
  • source-okta
  • source-commercetools
  • source-zenloop
  • source-amazon-ads
  • source-chargebee
  • source-freshservice
  • source-gitlab
  • source-asana
  • source-delighted
  • source-youtube-analytics
  • source-monday
  • source-zendesk-talk
  • source-pardot
  • source-google-ads
  • source-google-search-console
  • source-freshsales
  • source-drift
  • source-iterable
  • source-linnworks
  • source-cart
  • source-sendgrid
  • source-github
  • source-facebook-pages

@davydov-d
Copy link
Collaborator Author

davydov-d commented Oct 12, 2022

/publish connector=bases/source-acceptance-test auto-bump-version=false

🕑 Publishing the following connectors:
bases/source-acceptance-test
https://github.com/airbytehq/airbyte/actions/runs/3235189309


Connector Did it publish? Were definitions generated?
bases/source-acceptance-test

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@davydov-d
Copy link
Collaborator Author

davydov-d commented Oct 12, 2022

/publish connector=bases/source-acceptance-test auto-bump-version=false

🕑 Publishing the following connectors:
bases/source-acceptance-test
https://github.com/airbytehq/airbyte/actions/runs/3236628853


Connector Did it publish? Were definitions generated?
bases/source-acceptance-test

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@github-actions
Copy link
Contributor

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to run corresponding integration tests:

  • source-appsflyer
  • source-asana
  • source-twilio
  • source-gitlab
  • source-recharge
  • source-zendesk-sunshine
  • source-onesignal
  • source-pardot
  • source-tplcentral
  • source-posthog
  • source-freshcaller
  • source-airtable
  • source-mailchimp
  • source-azure-table
  • source-monday
  • source-confluence
  • source-github
  • source-zendesk-talk
  • source-youtube-analytics
  • source-harvest
  • source-instagram
  • source-pipedrive
  • source-iterable
  • source-cart
  • source-openweather
  • source-notion
  • source-klaviyo
  • source-pinterest
  • source-chargebee
  • source-outreach
  • source-zenloop
  • source-amazon-sqs
  • source-google-ads
  • source-quickbooks-singer
  • source-surveymonkey
  • source-paystack
  • source-amazon-ads
  • source-sentry
  • source-retently
  • source-braintree
  • source-strava
  • source-plaid
  • source-freshsales
  • source-facebook-marketing
  • source-lemlist
  • source-amazon-seller-partner
  • source-google-search-console
  • source-salesloft
  • source-amplitude
  • source-prestashop
  • source-mailgun
  • source-okta
  • source-greenhouse
  • source-drift
  • source-delighted
  • source-freshservice
  • source-salesforce
  • source-linnworks
  • source-sendgrid
  • source-commercetools
  • source-facebook-pages
  • source-lever-hiring

@davydov-d
Copy link
Collaborator Author

davydov-d commented Oct 12, 2022

/publish connector=bases/source-acceptance-test auto-bump-version=false

🕑 Publishing the following connectors:
bases/source-acceptance-test
https://github.com/airbytehq/airbyte/actions/runs/3236695844


Connector Did it publish? Were definitions generated?
bases/source-acceptance-test

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@github-actions
Copy link
Contributor

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to run corresponding integration tests:

  • source-github
  • source-strava
  • source-plaid
  • source-harvest
  • source-freshservice
  • source-openweather
  • source-youtube-analytics
  • source-delighted
  • source-drift
  • source-amazon-sqs
  • source-gitlab
  • source-monday
  • source-salesloft
  • source-recharge
  • source-zenloop
  • source-chargebee
  • source-twilio
  • source-freshsales
  • source-posthog
  • source-pipedrive
  • source-klaviyo
  • source-quickbooks-singer
  • source-airtable
  • source-appsflyer
  • source-lemlist
  • source-okta
  • source-azure-table
  • source-amazon-ads
  • source-google-search-console
  • source-onesignal
  • source-cart
  • source-pinterest
  • source-outreach
  • source-mailchimp
  • source-zendesk-talk
  • source-surveymonkey
  • source-salesforce
  • source-tplcentral
  • source-instagram
  • source-google-ads
  • source-braintree
  • source-amazon-seller-partner
  • source-notion
  • source-amplitude
  • source-commercetools
  • source-zendesk-sunshine
  • source-asana
  • source-sentry
  • source-confluence
  • source-lever-hiring
  • source-iterable
  • source-linnworks
  • source-facebook-marketing
  • source-freshcaller
  • source-greenhouse
  • source-retently
  • source-facebook-pages
  • source-pardot
  • source-prestashop
  • source-mailgun
  • source-paystack
  • source-sendgrid

@davydov-d
Copy link
Collaborator Author

davydov-d commented Oct 12, 2022

/publish connector=bases/source-acceptance-test auto-bump-version=false

🕑 Publishing the following connectors:
bases/source-acceptance-test
https://github.com/airbytehq/airbyte/actions/runs/3237375496


Connector Did it publish? Were definitions generated?
bases/source-acceptance-test

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@github-actions
Copy link
Contributor

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to run corresponding integration tests:

  • source-plaid
  • source-onesignal
  • source-amazon-seller-partner
  • source-mailgun
  • source-iterable
  • source-freshcaller
  • source-greenhouse
  • source-instagram
  • source-harvest
  • source-sendgrid
  • source-linnworks
  • source-zenloop
  • source-posthog
  • source-facebook-marketing
  • source-zendesk-sunshine
  • source-strava
  • source-google-search-console
  • source-recharge
  • source-appsflyer
  • source-amazon-sqs
  • source-outreach
  • source-salesforce
  • source-pardot
  • source-quickbooks-singer
  • source-github
  • source-azure-table
  • source-klaviyo
  • source-google-ads
  • source-monday
  • source-braintree
  • source-lemlist
  • source-tplcentral
  • source-commercetools
  • source-prestashop
  • source-lever-hiring
  • source-pipedrive
  • source-mailchimp
  • source-amazon-ads
  • source-paystack
  • source-salesloft
  • source-sentry
  • source-chargebee
  • source-amplitude
  • source-notion
  • source-surveymonkey
  • source-cart
  • source-pinterest
  • source-zendesk-talk
  • source-airtable
  • source-twilio
  • source-delighted
  • source-gitlab
  • source-freshservice
  • source-drift
  • source-asana
  • source-freshsales
  • source-youtube-analytics
  • source-confluence
  • source-facebook-pages
  • source-openweather
  • source-okta
  • source-retently

@davydov-d davydov-d merged commit eb6a242 into master Oct 12, 2022
@davydov-d davydov-d deleted the ddavydov/#17506-SATs-tune-incremental-tests branch October 12, 2022 19:53
jhammarstedt pushed a commit to jhammarstedt/airbyte that referenced this pull request Oct 31, 2022
* #17506 SATs: bugfix

* #17506 SATs: upd changelog

* SATs: bump version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants