-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source acceptance test: bugfix #17757
Source acceptance test: bugfix #17757
Conversation
/test connector=connectors/source-iterable
Build PassedTest summary info:
|
NOTE
|
/test connector=bases/source-acceptance-test
Build PassedTest summary info:
|
NOTE
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes look good. but let's run this against a couple more different connector just to verify no regressions. Hubspot is an especially good one because some streams have enough records to result in multiple slices in a sync.
/test connector=connectors/source-hubspot
Build PassedTest summary info:
|
/test connector=connectors/source-tiktok-marketing
Build FailedTest summary info:
|
/test connector=connectors/source-greenhouse
Build PassedTest summary info:
|
/test connector=connectors/source-snapchat-marketing
Build PassedTest summary info:
|
builds passed, except for tiktok (failed due to timeout), so I'm publishing this change |
/publish connector=bases/source-acceptance-test auto-bump-version=false
if you have connectors that successfully published but failed definition generation, follow step 4 here |
/publish connector=bases/source-acceptance-test auto-bump-version=false
if you have connectors that successfully published but failed definition generation, follow step 4 here |
NOTE
|
/publish connector=bases/source-acceptance-test auto-bump-version=false
if you have connectors that successfully published but failed definition generation, follow step 4 here |
/publish connector=bases/source-acceptance-test auto-bump-version=false
if you have connectors that successfully published but failed definition generation, follow step 4 here |
NOTE
|
/publish connector=bases/source-acceptance-test auto-bump-version=false
if you have connectors that successfully published but failed definition generation, follow step 4 here |
NOTE
|
/publish connector=bases/source-acceptance-test auto-bump-version=false
if you have connectors that successfully published but failed definition generation, follow step 4 here |
NOTE
|
* #17506 SATs: bugfix * #17506 SATs: upd changelog * SATs: bump version
What
latest_state
tostream_name_to_per_stream_state
inget_next_state_input
so that returned input state is not the same each time the function is calledlatest_state
fromget_next_state_input
args as it is no more used