Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🪟🐛 client side validation of cron expressions #17887

Merged
merged 19 commits into from
Oct 19, 2022
Merged

🪟🐛 client side validation of cron expressions #17887

merged 19 commits into from
Oct 19, 2022

Commits on Oct 11, 2022

  1. add cron-expression-validator for client side validation

    @josephkmh
    josephkmh committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    4988f75 View commit details
    Browse the repository at this point in the history

  2. refactor ScheduleField to validate cron expression

    @josephkmh
    josephkmh committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    f4afaed View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2022

  1. fix rebase mistakes

    @josephkmh
    josephkmh committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    13e5008 View commit details
    Browse the repository at this point in the history

  2. remove validation package in favor of regex

    @josephkmh
    josephkmh committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    b705a5f View commit details
    Browse the repository at this point in the history

  3. display cron validation error

    @josephkmh
    josephkmh committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    3e407d7 View commit details
    Browse the repository at this point in the history

  4. use regex for cron validation

    @josephkmh
    josephkmh committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    dcbc645 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into joey/sync-cron-expression-validation

    @josephkmh
    josephkmh committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    22d0fe6 View commit details
    Browse the repository at this point in the history

  6. disable submit when invalid

    @josephkmh
    josephkmh committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    07730eb View commit details
    Browse the repository at this point in the history

  7. move docs link to utils

    @josephkmh
    josephkmh committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    f4d697e View commit details
    Browse the repository at this point in the history

  8. remove commented code

    @josephkmh
    josephkmh committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    b62fa39 View commit details
    Browse the repository at this point in the history

  9. fix test

    @josephkmh
    josephkmh committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    9f145ff View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2022

  1. Merge branch 'master' into joey/sync-cron-expression-validation

    @josephkmh
    josephkmh committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    cc22d4d View commit details
    Browse the repository at this point in the history

  2. fix snapshot test

    @josephkmh
    josephkmh committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    1e1e19c View commit details
    Browse the repository at this point in the history

  3. refactor: keep validationSchema together in one place

    @josephkmh
    josephkmh committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    846b9c0 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into joey/sync-cron-expression-validation

    @josephkmh
    josephkmh authored Oct 13, 2022
    Configuration menu
    Copy the full SHA
    0448db0 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2022

  1. fix color

    @josephkmh
    josephkmh authored Oct 17, 2022
    Configuration menu
    Copy the full SHA
    bacc1c8 View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2022

  1. refactor: simplify jsx

    @josephkmh
    josephkmh committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    ba958b6 View commit details
    Browse the repository at this point in the history

  2. refactor: move cron validation to utils

    @josephkmh
    josephkmh committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    ab6987e View commit details
    Browse the repository at this point in the history

  3. refactor to avoid typecasting

    @josephkmh
    josephkmh committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    e032865 View commit details
    Browse the repository at this point in the history