Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Destination Clickhouse: Publish normalization after removing native port #17896

Merged
merged 3 commits into from
Oct 12, 2022
Merged

Destination Clickhouse: Publish normalization after removing native port #17896

merged 3 commits into from
Oct 12, 2022

Conversation

edgao
Copy link
Contributor

@edgao edgao commented Oct 12, 2022

Just a pr to publish changes in #17483

@edgao edgao requested a review from a team as a code owner October 12, 2022 16:31
@github-actions github-actions bot added area/documentation Improvements or additions to documentation normalization labels Oct 12, 2022
@github-actions
Copy link
Contributor

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to run corresponding integration tests:

  • destination-oracle
  • destination-mssql-strict-encrypt
  • destination-redshift
  • destination-clickhouse-strict-encrypt
  • destination-bigquery
  • destination-jdbc
  • destination-snowflake
  • destination-oracle-strict-encrypt
  • destination-tidb
  • destination-clickhouse
  • destination-bigquery-denormalized
  • destination-mysql
  • destination-postgres-strict-encrypt
  • destination-mssql
  • destination-postgres
  • destination-mysql-strict-encrypt

@edgao
Copy link
Contributor Author

edgao commented Oct 12, 2022 •
edited by github-actions bot
Loading

/publish connector=bases/base-normalization

🕑 Publishing the following connectors:
bases/base-normalization
https://github.com/airbytehq/airbyte/actions/runs/3236348401


Connector Did it publish? Were definitions generated?
bases/base-normalization ❌ ❌

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@github-actions
Copy link
Contributor

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to run corresponding integration tests:

  • destination-clickhouse
  • destination-snowflake
  • destination-jdbc
  • destination-mssql
  • destination-bigquery-denormalized
  • destination-redshift
  • destination-postgres-strict-encrypt
  • destination-oracle
  • destination-oracle-strict-encrypt
  • destination-tidb
  • destination-clickhouse-strict-encrypt
  • destination-mysql
  • destination-mysql-strict-encrypt
  • destination-postgres
  • destination-mssql-strict-encrypt
  • destination-bigquery

@edgao edgao temporarily deployed to more-secrets October 12, 2022 16:34 Inactive
ryankfu
ryankfu approved these changes Oct 12, 2022
View reviewed changes
Copy link
Contributor

@ryankfu ryankfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@edgao
Copy link
Contributor Author

edgao commented Oct 12, 2022 •
edited by github-actions bot
Loading

/publish connector=bases/base-normalization

🕑 Publishing the following connectors:
bases/base-normalization
https://github.com/airbytehq/airbyte/actions/runs/3236851749


Connector Did it publish? Were definitions generated?
bases/base-normalization ✅ ❌

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@edgao
Copy link
Contributor Author

edgao commented Oct 12, 2022

test failed because our redshift cluster restarted in the middle of the run :/ trying again 🤞

@github-actions
Copy link
Contributor

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to run corresponding integration tests:

  • destination-snowflake
  • destination-bigquery
  • destination-jdbc
  • destination-mssql-strict-encrypt
  • destination-postgres
  • destination-oracle-strict-encrypt
  • destination-oracle
  • destination-clickhouse
  • destination-redshift
  • destination-mysql
  • destination-postgres-strict-encrypt
  • destination-mysql-strict-encrypt
  • destination-bigquery-denormalized
  • destination-clickhouse-strict-encrypt
  • destination-mssql
  • destination-tidb

@edgao edgao temporarily deployed to more-secrets October 12, 2022 20:47 Inactive
@edgao edgao merged commit bd0c238 into master Oct 12, 2022
@edgao edgao deleted the edgao/normalization_publish branch October 12, 2022 20:51
This was referenced Oct 13, 2022
Closed
Merged
jhammarstedt pushed a commit to jhammarstedt/airbyte that referenced this pull request Oct 31, 2022
@edgao @jhammarstedt
Destination Clickhouse: Publish normalization after removing native p…
d5cd80b 
…ort (airbytehq#17896)

* bump version for publish

* add link for publish pr
@grishick grishick added the team/destinations Destinations team's backlog label Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryankfu ryankfu ryankfu approved these changes

Assignees
No one assigned
Labels
area/documentation Improvements or additions to documentation normalization team/destinations Destinations team's backlog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@edgao @ryankfu @grishick