Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Destination GCS: Fix error logs to log 'Gcs' rather than 'AWS' #17901

Merged
merged 6 commits into from
Oct 18, 2022
Merged

Destination GCS: Fix error logs to log 'Gcs' rather than 'AWS' #17901

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
108294f
Fix error logs to log 'Gcs' rather than 'AWS'
zheller Oct 12, 2022
1193203
Merge branch 'master' into zh/fix-gcs-connector-log
zheller Oct 13, 2022
eface1a
Merge branch 'master' into zh/fix-gcs-connector-log
zheller Oct 13, 2022
be62c85
Merge branch 'master' into zh/fix-gcs-connector-log
zheller Oct 14, 2022
80561a3
update connector version
marcosmarxm Oct 18, 2022
d7bc6ce
auto-bump connector version
octavia-squidington-iii Oct 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion airbyte-config/init/src/main/resources/seed/destination_definitions.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@
- name: Google Cloud Storage (GCS)
destinationDefinitionId: ca8f6566-e555-4b40-943a-545bf123117a
dockerRepository: airbyte/destination-gcs
dockerImageTag: 0.2.11
dockerImageTag: 0.2.12
documentationUrl: https://docs.airbyte.com/integrations/destinations/gcs
icon: googlecloudstorage.svg
resourceRequirements:
Expand Down
2 changes: 1 addition & 1 deletion airbyte-config/init/src/main/resources/seed/destination_specs.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1886,7 +1886,7 @@
supported_destination_sync_modes:
- "overwrite"
- "append"
- dockerImage: "airbyte/destination-gcs:0.2.11"
- dockerImage: "airbyte/destination-gcs:0.2.12"
spec:
documentationUrl: "https://docs.airbyte.com/integrations/destinations/gcs"
connectionSpecification:
Expand Down
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/destination-gcs/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,5 @@ ENV APPLICATION destination-gcs

COPY --from=build /airbyte /airbyte

LABEL io.airbyte.version=0.2.11
LABEL io.airbyte.version=0.2.12
LABEL io.airbyte.name=airbyte/destination-gcs
4 changes: 2 additions & 2 deletions ...destination-gcs/src/main/java/io/airbyte/integrations/destination/gcs/GcsDestination.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,14 +57,14 @@ public AirbyteConnectionStatus check(final JsonNode config) {

return new AirbyteConnectionStatus().withStatus(Status.SUCCEEDED);
} catch (final AmazonS3Exception e) {
LOGGER.error("Exception attempting to access the AWS bucket: {}", e.getMessage());
LOGGER.error("Exception attempting to access the Gcs bucket: {}", e.getMessage());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
LOGGER.error("Exception attempting to access the Gcs bucket: {}", e.getMessage());
LOGGER.error("Exception attempting to access the GCS bucket: {}", e.getMessage());

final String message = getErrorMessage(e.getErrorCode(), 0, e.getMessage(), e);
AirbyteTraceMessageUtility.emitConfigErrorTrace(e, message);
return new AirbyteConnectionStatus()
.withStatus(Status.FAILED)
.withMessage(message);
} catch (final Exception e) {
LOGGER.error("Exception attempting to access the AWS bucket: {}. Please make sure you account has all of these roles: {}", e.getMessage(),
LOGGER.error("Exception attempting to access the Gcs bucket: {}. Please make sure you account has all of these roles: {}", e.getMessage(),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
LOGGER.error("Exception attempting to access the Gcs bucket: {}. Please make sure you account has all of these roles: {}", e.getMessage(),
LOGGER.error("Exception attempting to access the GCS bucket: {}. Please make sure you account has all of these roles: {}", e.getMessage(),

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the log message below this it is spelled Gcs, is it blocking to update that string too?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙄 not really

EXPECTED_ROLES);
AirbyteTraceMessageUtility.emitConfigErrorTrace(e, e.getMessage());
return new AirbyteConnectionStatus()
Expand Down
1 change: 1 addition & 0 deletions docs/integrations/destinations/gcs.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,6 +235,7 @@ Under the hood, an Airbyte data stream in Json schema is first converted to an A

| Version | Date | Pull Request | Subject |
|:--------| :--- | :--- | :--- |
| 0.2.12 | 2022-10-18 | [\#17901](https://github.com/airbytehq/airbyte/pull/17901) | Fix logging to GCS |
| 0.2.11 | 2022-09-01 | [\#16243](https://github.com/airbytehq/airbyte/pull/16243) | Fix Json to Avro conversion when there is field name clash from combined restrictions (`anyOf`, `oneOf`, `allOf` fields) |
| 0.2.10 | 2022-08-05 | [\#14801](https://github.com/airbytehq/airbyte/pull/14801) | Fix multiple log bindings |
| 0.2.9 | 2022-06-24 | [\#14114](https://github.com/airbytehq/airbyte/pull/14114) | Remove "additionalProperties": false from specs for connectors with staging |
Expand Down