Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Docker image existence check (normalization) #17908

Merged
merged 2 commits into from
Oct 12, 2022

Conversation

edgao
Copy link
Contributor

@edgao edgao commented Oct 12, 2022

NormalizationRunnerFactory got moved at some point. Update its path. Currently this check always passes for normalization images.

@edgao edgao temporarily deployed to more-secrets October 12, 2022 20:51 Inactive
Copy link
Contributor

@evantahler evantahler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that you have properly changed the path to that file!

@edgao edgao temporarily deployed to more-secrets October 12, 2022 21:02 Inactive
@edgao
Copy link
Contributor Author

edgao commented Oct 12, 2022

waiting for the check to pass and will merge once it turns green

@edgao edgao merged commit 808af16 into master Oct 12, 2022
@edgao edgao deleted the edgao/normalization_image_check_fix branch October 12, 2022 21:08
jhammarstedt pushed a commit to jhammarstedt/airbyte that referenced this pull request Oct 31, 2022
* fix path to NormalizationRunnerFactory

* check for file existence also
@grishick grishick added the team/destinations Destinations team's backlog label Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team/destinations Destinations team's backlog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants