Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Helm Chart: Create service annotations for airbyte-server #17932

Merged
merged 4 commits into from
Oct 17, 2022
Merged

Helm Chart: Create service annotations for airbyte-server #17932

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
250637c
Support annotations for airbyte-server as well, update version and up…
sfc-gh-pkommini Oct 13, 2022
1d39ed2
Fix auto-indent.
sfc-gh-pkommini Oct 13, 2022
d2eee3b
Merge branch 'master' of https://github.com/sfc-gh-pkommini/airbyte i…
sfc-gh-pkommini Oct 13, 2022
4e57963
Merge branch 'master' into create-service-annotations
xpuska513 Oct 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/airbyte-server/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 0.45.2
version: 0.45.3

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
Expand Down
1 change: 1 addition & 0 deletions charts/airbyte-server/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@ Helm chart to deploy airbyte-server
| resources.limits | object | `{}` | |
| resources.requests | object | `{}` | |
| secrets | object | `{}` | |
| service.annotations | object | `{}` | |
| service.port | int | `8001` | |
| service.type | string | `"ClusterIP"` | |
| tolerations | list | `[]` | |
Expand Down
4 changes: 4 additions & 0 deletions charts/airbyte-server/templates/service.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,10 @@ apiVersion: v1
kind: Service
metadata:
name: {{.Release.Name }}-airbyte-server-svc
{{- with .Values.service.annotations }}
annotations:
{{- toYaml . | nindent 4 }}
{{- end }}
labels:
{{- include "airbyte.labels" . | nindent 4 }}
spec:
Expand Down
1 change: 1 addition & 0 deletions charts/airbyte-server/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,7 @@ resources:
service:
type: ClusterIP
port: 8001
annotations: {}

## nodeSelector [object] Node labels for pod assignment
## Ref: https://kubernetes.io/docs/user-guide/node-selection/
Expand Down