Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🪟 🐛 Handle className removal on SVG #17935

Merged
merged 1 commit into from
Oct 13, 2022
Merged

🪟 🐛 Handle className removal on SVG #17935

merged 1 commit into from
Oct 13, 2022

Conversation

timroes
Copy link
Collaborator

@timroes timroes commented Oct 13, 2022

What

This PR adds className removal in tests also on SVG elements, which didn't work so far, due to their className is (sometimes) not of type string, but a SVGAnimatedString. This is now handled in the script as well.

@timroes timroes added area/frontend Related to the Airbyte webapp ui/tests labels Oct 13, 2022
@timroes timroes requested a review from a team as a code owner October 13, 2022 09:23
@github-actions github-actions bot added the area/platform issues related to the platform label Oct 13, 2022
josephkmh
josephkmh approved these changes Oct 13, 2022
View reviewed changes
Copy link
Contributor

@josephkmh josephkmh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@timroes timroes merged commit 2a4a5d3 into master Oct 13, 2022
@timroes timroes deleted the tim/classname-svg branch October 13, 2022 09:41
This was referenced Oct 13, 2022
Closed
Merged
jhammarstedt pushed a commit to jhammarstedt/airbyte that referenced this pull request Oct 31, 2022
@timroes @jhammarstedt
Handle className removal on SVG (airbytehq#17935)
5bf0a18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josephkmh josephkmh josephkmh approved these changes

Assignees
No one assigned
Labels
area/frontend Related to the Airbyte webapp area/platform issues related to the platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timroes @josephkmh