Source File: Handle UnicodeDecodeError in case of incorrect filetype #17994

arsenlosenko · 2022-10-14T10:58:24Z

What

Resolving:
https://github.com/airbytehq/alpha-beta-issues/issues/374

How

The UnicodeDecodeError happens during reading of the file object, which is made from the object provided by the user during source setup, thus the handling of this exception was made during this step.

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

CLAassistant · 2022-10-14T10:58:29Z

All committers have signed the CLA.

arsenlosenko · 2022-10-14T10:58:52Z

/test connector=connectors/source-file

🕑 connectors/source-file https://github.com/airbytehq/airbyte/actions/runs/3249426229
❌ connectors/source-file https://github.com/airbytehq/airbyte/actions/runs/3249426229
🐛 https://gradle.com/s/i73qnkzr4wev2

Build Failed

Test summary info:

	 =========================== short test summary info ============================
	 FAILED integration_tests/client_storage_providers_test.py::test__read_from_private_ssh[ssh-files/test.csv-csv]
	 FAILED integration_tests/client_storage_providers_test.py::test__read_from_private_ssh[scp-files/test.csv-csv]
	 FAILED integration_tests/client_storage_providers_test.py::test__read_from_private_ssh[sftp-files/test.csv-csv]
	 FAILED integration_tests/client_storage_providers_test.py::test__read_from_private_ssh[ssh-files/test.csv.gz-csv]
	 FAILED integration_tests/client_storage_providers_test.py::test__read_from_private_ssh[ssh-files/test.pkl-pickle]
	 FAILED integration_tests/client_storage_providers_test.py::test__read_from_private_ssh[sftp-files/test.pkl.gz-pickle]
	 FAILED integration_tests/client_storage_providers_test.py::test__streams_from_ssh_providers[ssh-files/test.csv-csv]
	 FAILED integration_tests/client_storage_providers_test.py::test__streams_from_ssh_providers[ssh-files/test.pkl-pickle]
	 FAILED integration_tests/client_storage_providers_test.py::test__streams_from_ssh_providers[sftp-files/test.pkl.gz-pickle]
	 FAILED integration_tests/client_storage_providers_test.py::test__read_from_public_provider[HTTPS-https:/storage.googleapis.com/covid19-open-data/v2/latest/epidemiology.csv-10-,-True]
	 FAILED integration_tests/client_storage_providers_test.py::test__read_from_public_provider[HTTPS-storage.googleapis.com/covid19-open-data/v2/latest/epidemiology.csv-10-,-True]
	 FAILED integration_tests/client_storage_providers_test.py::test__read_from_public_provider[local-injected by tests-10-,-True]
	 FAILED integration_tests/client_storage_providers_test.py::test__read_from_public_provider[GCS-gs:/gcp-public-data-landsat/index.csv.gz-18-,-True0]
	 FAILED integration_tests/client_storage_providers_test.py::test__read_from_public_provider[GCS-gs:/gcp-public-data-landsat/index.csv.gz-18-,-True1]
	 FAILED integration_tests/client_storage_providers_test.py::test__read_from_public_provider[S3-s3:/gdelt-open-data/events/20190914.export.csv-58-\\t-False0]
	 FAILED integration_tests/client_storage_providers_test.py::test__read_from_public_provider[S3-s3:/gdelt-open-data/events/20190914.export.csv-58-\\t-False1]
	 FAILED integration_tests/client_storage_providers_test.py::test__read_from_private_gcs
	 FAILED integration_tests/client_storage_providers_test.py::test__read_from_private_aws
	 FAILED integration_tests/client_storage_providers_test.py::test__read_from_public_azblob
	 FAILED integration_tests/client_storage_providers_test.py::test__read_from_private_azblob_shared_key
	 FAILED integration_tests/client_storage_providers_test.py::test__read_from_private_azblob_sas_token
	 FAILED integration_tests/file_formats_test.py::test_local_file_read[csv-csv-8-5000-demo]
	 FAILED integration_tests/file_formats_test.py::test_csv_schema - pandas.error...
	 �[31m============= �[31m�[1m23 failed�[0m, �[32m10 passed�[0m, �[33m1 warning�[0m�[31m in 752.84s (0:12:32)�[0m�[31m =============�[0m

arsenlosenko · 2022-10-17T08:15:49Z

/test connector=connectors/source-file

🕑 connectors/source-file https://github.com/airbytehq/airbyte/actions/runs/3263469797
✅ connectors/source-file https://github.com/airbytehq/airbyte/actions/runs/3263469797
Python tests coverage:

Name                      Stmts   Miss  Cover
---------------------------------------------
source_file/__init__.py       2      0   100%
source_file/client.py       280     45    84%
source_file/source.py        60     35    42%
---------------------------------------------
TOTAL                       342     80    77%
Name                      Stmts   Miss  Cover
---------------------------------------------
source_file/source.py        60      0   100%
source_file/__init__.py       2      0   100%
source_file/client.py       280     37    87%
---------------------------------------------
TOTAL                       342     37    89%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          10      4    60%   15-18
	 source_acceptance_test/config.py                        83      6    93%   78-80, 84-86
	 source_acceptance_test/conftest.py                     164    164     0%   6-282
	 source_acceptance_test/plugin.py                        48     48     0%   6-104
	 source_acceptance_test/tests/test_core.py              329    111    66%   39, 50-58, 63-70, 74-75, 79-80, 164, 202-219, 228-236, 240-245, 251, 284-289, 327-334, 374-376, 379, 439-448, 477-478, 484, 487, 520-530, 543-568, 573-577
	 source_acceptance_test/tests/test_full_refresh.py       52      2    96%   34, 65
	 source_acceptance_test/tests/test_incremental.py       145     20    86%   21-23, 29-31, 36-43, 48-61, 224
	 source_acceptance_test/utils/asserts.py                 37      2    95%   57-58
	 source_acceptance_test/utils/common.py                  77     10    87%   15-16, 24-30, 64, 67
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       112     50    55%   23-26, 32, 36, 39-67, 70-72, 75-77, 80-82, 85-87, 90-92, 95-113, 147-149
	 source_acceptance_test/utils/json_schema_helper.py     105     13    88%   30-31, 38, 41, 65-68, 96, 120, 190-192
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1351    453    66%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:60: Skipping TestIncremental.test_two_sequential_reads because not found in the config
======================== 26 passed, 1 skipped in 59.21s ========================

arsenlosenko · 2022-10-17T08:52:17Z

/test connector=connectors/source-file

🕑 connectors/source-file https://github.com/airbytehq/airbyte/actions/runs/3263712306
✅ connectors/source-file https://github.com/airbytehq/airbyte/actions/runs/3263712306
Python tests coverage:

Name                      Stmts   Miss  Cover
---------------------------------------------
source_file/__init__.py       2      0   100%
source_file/client.py       280     45    84%
source_file/source.py        60     35    42%
---------------------------------------------
TOTAL                       342     80    77%
Name                      Stmts   Miss  Cover
---------------------------------------------
source_file/source.py        60      0   100%
source_file/__init__.py       2      0   100%
source_file/client.py       280     34    88%
---------------------------------------------
TOTAL                       342     34    90%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          10      4    60%   15-18
	 source_acceptance_test/config.py                        83      6    93%   78-80, 84-86
	 source_acceptance_test/conftest.py                     164    164     0%   6-282
	 source_acceptance_test/plugin.py                        48     48     0%   6-104
	 source_acceptance_test/tests/test_core.py              329    111    66%   39, 50-58, 63-70, 74-75, 79-80, 164, 202-219, 228-236, 240-245, 251, 284-289, 327-334, 374-376, 379, 439-448, 477-478, 484, 487, 520-530, 543-568, 573-577
	 source_acceptance_test/tests/test_full_refresh.py       52      2    96%   34, 65
	 source_acceptance_test/tests/test_incremental.py       145     20    86%   21-23, 29-31, 36-43, 48-61, 224
	 source_acceptance_test/utils/asserts.py                 37      2    95%   57-58
	 source_acceptance_test/utils/common.py                  77     10    87%   15-16, 24-30, 64, 67
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       112     50    55%   23-26, 32, 36, 39-67, 70-72, 75-77, 80-82, 85-87, 90-92, 95-113, 147-149
	 source_acceptance_test/utils/json_schema_helper.py     105     13    88%   30-31, 38, 41, 65-68, 96, 120, 190-192
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1351    453    66%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:60: Skipping TestIncremental.test_two_sequential_reads because not found in the config
=================== 26 passed, 1 skipped in 60.16s (0:01:00) ===================

…irbytehq#17994) * Handle UnicodeDecodeError in case of incorrect filetype * Update changelog and Dockerfile * Update changelog with PR number * Move try/except close to the end of method * Add test and test files

Arsen Losenko added 2 commits October 14, 2022 13:53

Handle UnicodeDecodeError in case of incorrect filetype

08425c3

Update changelog and Dockerfile

b2548fe

arsenlosenko requested review from grubberr and lazebnyi October 14, 2022 10:58

arsenlosenko self-assigned this Oct 14, 2022

github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Oct 14, 2022

octavia-squidington-iv added connectors/source/file connectors/source/file-secure labels Oct 14, 2022

Arsen Losenko added 2 commits October 14, 2022 13:59

Update changelog with PR number

ee18fa0

Move try/except close to the end of method

6cfeb98

grubberr approved these changes Oct 17, 2022

View reviewed changes

Add test and test files

38a2d14

arsenlosenko merged commit a28836e into master Oct 17, 2022

arsenlosenko deleted the arsenlosenko/374-source-file-invalid-byte branch October 17, 2022 09:20

octavia-squidington-iii mentioned this pull request Oct 20, 2022

Bump Airbyte version from 0.40.15 to 0.40.16 #18268

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Source File: Handle UnicodeDecodeError in case of incorrect filetype #17994

Source File: Handle UnicodeDecodeError in case of incorrect filetype #17994

arsenlosenko commented Oct 14, 2022

CLAassistant commented Oct 14, 2022 •

edited

Loading

arsenlosenko commented Oct 14, 2022 •

edited by github-actions bot

Loading

arsenlosenko commented Oct 17, 2022 •

edited by github-actions bot

Loading

arsenlosenko commented Oct 17, 2022 •

edited by github-actions bot

Loading

Source File: Handle UnicodeDecodeError in case of incorrect filetype #17994

Source File: Handle UnicodeDecodeError in case of incorrect filetype #17994

Conversation

arsenlosenko commented Oct 14, 2022

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

Tests

CLAassistant commented Oct 14, 2022 • edited Loading

arsenlosenko commented Oct 14, 2022 • edited by github-actions bot Loading

Build Failed

arsenlosenko commented Oct 17, 2022 • edited by github-actions bot Loading

Build Passed

arsenlosenko commented Oct 17, 2022 • edited by github-actions bot Loading

Build Passed

CLAassistant commented Oct 14, 2022 •

edited

Loading

arsenlosenko commented Oct 14, 2022 •

edited by github-actions bot

Loading

arsenlosenko commented Oct 17, 2022 •

edited by github-actions bot

Loading

arsenlosenko commented Oct 17, 2022 •

edited by github-actions bot

Loading