Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removed unused props clickable and wasActive from button component #18124

Merged
merged 10 commits into from
Jan 20, 2023
Merged

removed unused props clickable and wasActive from button component #18124

merged 10 commits into from
Jan 20, 2023

Conversation

bgopikrishna
Copy link
Contributor

What

Fixes #17719.
Removed the following unused properties from the button component

  • clickable
  • wasActive

@bgopikrishna bgopikrishna requested a review from a team as a code owner October 18, 2022 17:56
@CLAassistant
Copy link

CLAassistant commented Oct 18, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added area/platform issues related to the platform area/frontend Related to the Airbyte webapp labels Oct 18, 2022
@marcosmarxm
Copy link
Member

Thanks for the contribution @bgopikrishna
@airbytehq/frontend can you check this community contribution and add to next sprint to review?

@natalyjazzviolin
Copy link
Contributor

@edmundito looks like a community member has contributed a frontend fix :) would you be able to give this a review?

natalyjazzviolin
natalyjazzviolin approved these changes Nov 1, 2022
View reviewed changes
Copy link
Contributor

@natalyjazzviolin natalyjazzviolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for your contribution!

@timroes
Copy link
Collaborator

timroes commented Nov 1, 2022

@natalyjazzviolin @marcosmarxm Could either of you fork this into the repo as a PR, so we can have CI run on this?

@marcosmarxm
Copy link
Member

Hello 👋, first thank you for this amazing contribution.

We really appreciate the effort you've made to improve the project.
We ask you patience for the code review. Last month our team was focused on Hacktoberfest event and that probably left some PR without the proper feedback. And this week, due to the Thanksgiving US Holiday, most our team is out of office with their families. Another important piece of information why code won't be merge this week is: as a safety measure the core team has decided to freeze merging code to main branch to keep the release stable. Next week we'll return to you with the proper code review and update the status of your contribution.

If you have any questions feel free to send me a message in Slack!
Thanks!

krishnaglick
krishnaglick approved these changes Dec 1, 2022
View reviewed changes
Copy link
Contributor

@krishnaglick krishnaglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not test locally but Typescript would catch any errors from this.

@marcosmarxm
Copy link
Member

Hello 👋:skin-tone-2: and thank you for your contribution!

Airbyte has instituted a code freeze between 19 and 30 December, to make sure there are no disruptions during the holidays.
Because of this, reviewing and merging your contribution may take longer than usual.
We apologize for the delay, but we want everyone to have a quiet and happy holiday.

If you have any questions or need further clarification, please don't hesitate to ping via Slack.

@krishnaglick
Copy link
Contributor

Heya! Our code freeze is over. Would you mind resolving conflicts with the current branch? Thanks so much!

@octavia-squidington-iv octavia-squidington-iv removed the area/platform issues related to the platform label Jan 10, 2023
@bgopikrishna
Copy link
Contributor Author

Heya! Our code freeze is over. Would you mind resolving conflicts with the current branch? Thanks so much!

Done

krishnaglick
krishnaglick approved these changes Jan 10, 2023
View reviewed changes
Copy link
Contributor

@krishnaglick krishnaglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming CI passes! 👍
Thank you for your contribution!

@krishnaglick krishnaglick mentioned this pull request Jan 19, 2023
Closed
@krishnaglick
Copy link
Contributor

Since #21624 is green I am going to merge this. Sorry about the wait and thank you again!

@krishnaglick krishnaglick merged commit 8a95c5c into airbytehq:master Jan 20, 2023
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Jan 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krishnaglick krishnaglick krishnaglick approved these changes

@natalyjazzviolin natalyjazzviolin natalyjazzviolin approved these changes

Assignees

@natalyjazzviolin natalyjazzviolin

Labels
area/frontend Related to the Airbyte webapp community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove unused properties from Button
8 participants
@bgopikrishna @CLAassistant @marcosmarxm @natalyjazzviolin @timroes @krishnaglick @octavia-squidington-iv @perangel