Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use constructor injection for singleton #18163

Merged
merged 1 commit into from
Oct 19, 2022
Merged

Use constructor injection for singleton #18163

merged 1 commit into from
Oct 19, 2022

Conversation

jdpgrailsdev
Copy link
Contributor

What

  • Use recommended approaches for singleton injection

How

  • Use constructor based injection for singleton
  • Remove references to deprecated EnvConfigs class.

Recommended reading order

  1. DefinitionsUpdater.java
  2. ApplicationBeanFactory.java
  3. application.yml

Tests

  • All tests pass
  • Application starts locally via docker-compose without issue

@benmoriceau
Copy link
Contributor

We will need a follow up review in cloud for that

@jdpgrailsdev jdpgrailsdev merged commit eed3257 into master Oct 19, 2022
@jdpgrailsdev jdpgrailsdev deleted the jonathan/cron-cleanup branch October 19, 2022 15:59
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Oct 20, 2022
Merged
jhammarstedt pushed a commit to jhammarstedt/airbyte that referenced this pull request Oct 31, 2022
@jdpgrailsdev @jhammarstedt
Use constructor injection for singleton (airbytehq#18163)
b970a27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gosusnp gosusnp gosusnp approved these changes

@benmoriceau benmoriceau benmoriceau approved these changes

@colesnodgrass colesnodgrass Awaiting requested review from colesnodgrass

@alovew alovew Awaiting requested review from alovew

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jdpgrailsdev @benmoriceau @gosusnp