Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark the sendgrid api key secret in the spec #18182

Merged
merged 5 commits into from
Oct 19, 2022

Conversation

mfsiega-airbyte
Copy link
Contributor

What

Mark the sendgrid api key secret in the connector spec.

How

Apply airbyte_secret annotation.

@pedroslopez
Copy link
Contributor

pedroslopez commented Oct 19, 2022

/test connector=connectors/source-sendgrid

🕑 connectors/source-sendgrid https://github.com/airbytehq/airbyte/actions/runs/3284683638
✅ connectors/source-sendgrid https://github.com/airbytehq/airbyte/actions/runs/3284683638
Python tests coverage:

Name                          Stmts   Miss  Cover
-------------------------------------------------
source_sendgrid/__init__.py       2      0   100%
source_sendgrid/streams.py      161     18    89%
source_sendgrid/source.py        26      3    88%
-------------------------------------------------
TOTAL                           189     21    89%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          10      4    60%   15-18
	 source_acceptance_test/config.py                        83      6    93%   78-80, 84-86
	 source_acceptance_test/conftest.py                     164    164     0%   6-282
	 source_acceptance_test/plugin.py                        48     48     0%   6-104
	 source_acceptance_test/tests/test_core.py              329    111    66%   39, 50-58, 63-70, 74-75, 79-80, 164, 202-219, 228-236, 240-245, 251, 284-289, 327-334, 374-376, 379, 439-448, 477-478, 484, 487, 520-530, 543-568, 573-577
	 source_acceptance_test/tests/test_incremental.py       145     20    86%   21-23, 29-31, 36-43, 48-61, 224
	 source_acceptance_test/utils/asserts.py                 37      2    95%   57-58
	 source_acceptance_test/utils/common.py                  77     10    87%   15-16, 24-30, 64, 67
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       112     50    55%   23-26, 32, 36, 39-67, 70-72, 75-77, 80-82, 85-87, 90-92, 95-113, 147-149
	 source_acceptance_test/utils/json_schema_helper.py     105     13    88%   30-31, 38, 41, 65-68, 96, 120, 190-192
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1351    451    67%

Build Passed

Test summary info:

All Passed

Copy link
Contributor

@pedroslopez pedroslopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but we should release a new version of the connector with this change. Please remember to bump the version, update the changelog and publish the connector.

@mfsiega-airbyte mfsiega-airbyte changed the title mark the sendgrid api key secret in the connector spec Mark the sendgrid api key secret in the spec Oct 19, 2022
@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Oct 19, 2022
@mfsiega-airbyte
Copy link
Contributor Author

mfsiega-airbyte commented Oct 19, 2022

/publish connector=connectors/source-sendgrid

🕑 Publishing the following connectors:
connectors/source-sendgrid
https://github.com/airbytehq/airbyte/actions/runs/3284956091


Connector Did it publish? Were definitions generated?
connectors/source-sendgrid

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets October 19, 2022 21:24 Inactive
@mfsiega-airbyte mfsiega-airbyte temporarily deployed to more-secrets October 19, 2022 21:28 Inactive
@mfsiega-airbyte mfsiega-airbyte merged commit 388810c into master Oct 19, 2022
@mfsiega-airbyte mfsiega-airbyte deleted the msiega/sendgrid-connector-spec branch October 19, 2022 22:08
jhammarstedt pushed a commit to jhammarstedt/airbyte that referenced this pull request Oct 31, 2022
* mark the sendgrid api key secret in the connector spec

* bump veresion on sendgrid source connector

* update changelog with sendgrid release notes

* auto-bump connector version

Co-authored-by: Octavia Squidington III <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/sendgrid
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants