add a span interceptor to treat expected errors as non-errors #18192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colesnodgrass
requested review from
jdpgrailsdev,
gosusnp,
benmoriceau and
alovew
github-actions
bot
added
area/platform
jhammarstedt
pushed a commit
to jhammarstedt/airbyte
that referenced
this pull request
Oct 31, 2022
…ehq#18192) * wip; tracer interceptor * fix span check * update logs for testing * more debugging * more debugging * more debugging * more debugging * remove debugging; add test * address one pmd error and ignore another
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
How
Create an interceptor that looks for specific error spans and marks them as non-errors. This is necessary as the google storage client automatically marks any 404 response from their api as an error on the span they create. As we don't have any ability to directly influence how they create their span or what they consider to be an error, we have to do this afterwards via this interceptor.