Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🪟 🎉 Use Google business mails by default for login #18462

Merged
merged 2 commits into from
Oct 26, 2022
Merged

🪟 🎉 Use Google business mails by default for login #18462

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
995c194
Use Google business mails by default for login
timroes Oct 25, 2022
477092f
Merge branch 'master' into tim/google-business-mails
timroes Oct 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion airbyte-webapp/src/packages/cloud/lib/auth/GoogleAuthService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,11 @@ export class GoogleAuthService {
}

async loginWithOAuth(provider: OAuthProviders) {
await signInWithPopup(this.auth, provider === "github" ? new GithubAuthProvider() : new GoogleAuthProvider());
// Instantiate the appropriate auth provider. For Google we're specifying the `hd` parameter, to only show
// Google accounts in the selector that are linked to a business (GSuite) account.
const authProvider =
provider === "github" ? new GithubAuthProvider() : new GoogleAuthProvider().setCustomParameters({ hd: "*" });
await signInWithPopup(this.auth, authProvider);
}

async login(email: string, password: string): Promise<UserCredential> {
Expand Down