Bmoric/extract jobs api #18524
Merged
Bmoric/extract jobs api #18524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vert-server-to-micronaut
…tehq/airbyte into bmoric/extract-connection-api
…tehq/airbyte into bmoric/extract-connection-api
…ract-connection-api
…ract-connection-api
…airbyte into bmoric/extract-db-migration-api
…ract-db-migration-api
…ract-db-migration-api
…q/airbyte into bmoric/extract-destination-definition-api
…m:airbytehq/airbyte into bmoric/extract-destination-definition-specification-api
benmoriceau
requested review from
jdpgrailsdev,
alovew,
colesnodgrass and
gosusnp
|
@benmoriceau There are failing tests in |
@jdpgrailsdev It was probably because it was not rebase on the health check api PR. I had to switch to improving the error message yesterday. the PR should be good now. |
gosusnp
approved these changes
Nov 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
In order to be prepared for a smoother migration to Micronaut for the server, an effort must be made to break the ConfigurationApi into multiple classes. This PR is the first one of a series of PR to come.
How
Extract the JobsApi into its own class
Recommended reading order
No specific order