Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up build.gradle. #18555

Merged
merged 6 commits into from
Oct 28, 2022
Merged

Clean up build.gradle. #18555

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
36c0773
We no longer need this since this upstream has fixed this bug so it i…
davinchia Oct 27, 2022
37a460a
Merge branch 'master' into davinchia/clean-up-repositories
davinchia Oct 27, 2022
b77dcfd
Merge branch 'master' into davinchia/clean-up-repositories
davinchia Oct 27, 2022
da3ed90
Merge branch 'master' into davinchia/clean-up-repositories
davinchia Oct 27, 2022
7f7e3e8
Format.
davinchia Oct 27, 2022
f182b2d
Merge branch 'master' into davinchia/clean-up-repositories
davinchia Oct 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions airbyte-cdk/python/airbyte_cdk/models/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
# generated by generate-protocol-files
from .airbyte_protocol import *
from .well_known_types import *
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this line for?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sherifnada I'm not sure - this was breaking here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran it locally to see the diff and this popped up. Wanted to see if fixes the build.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like master is also breaking: https://github.com/airbytehq/airbyte/actions/runs/3341634147/jobs/5533051500

4 changes: 0 additions & 4 deletions build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,10 +283,6 @@ subprojects { subproj ->

repositories {
mavenCentral()
maven {
// TODO(Issue-4915): Remove this when upstream is merged in.
url 'https://airbyte.mycloudrepo.io/public/repositories/airbyte-public-jars/'
}
maven {
url 'https://jitpack.io'
}
Expand Down