🎉 New source: Partnerstack [low-code CDK] #18603

elliottrabac · 2022-10-28T12:23:17Z

What

Describe what the change is solving
It helps to add screenshots if it affects the frontend.

Hacktoberfest: airbytehq/connector-contest#207

How

Describe the solution

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

marcosmarxm

A few comments but the connector looks solid. Please move request my review again when this is ready :)

airbyte-integrations/connectors/source-partnerstack/source_partnerstack/spec.yaml

marcosmarxm · 2022-10-28T19:02:18Z

airbyte-integrations/connectors/source-partnerstack/source_partnerstack/partnerstack.yaml

+      type: DefaultPaginator
+      pagination_strategy:
+        type: "CursorPagination"
+        cursor_value: "{{ last_records[-1]['key'] }}"


Just curious about the usage of this option.

Which option are you referring to?

the cursor field, this is the first connector using this feature interpolation

Not sure I'm getting your point, but cursor_value: "{{ last_records[-1]['key'] }}" is mandatory for the pagination here.

The API returns the objects ordered by creation date, and the pagination is possible by adding the last object key of the last batch of records in the next request.

@elliottrabac I saw this connector supports incremental syncs. Are you interested in implementing this sync mode for this connector? I'm askng because the incremental sync is much more interesting to users where you can retrieve only new records.

Yes sure! Curious to see how it goes with the low code CDK 👍

I'll ping you once done.

marcosmarxm · 2022-10-31T20:25:13Z

@elliottrabac do you have a test account to share?

marcosmarxm

@elliottrabac can you share the output of ./gradlew airbyte-integrations:connectors:source-partnerstack:integrationTest?

elliottrabac · 2022-11-01T18:45:07Z

@elliottrabac do you have a test account to share?

Unfortunately no :/

I tried all the streams locally and on the VM, working well:

marcosmarxm · 2022-11-01T23:01:30Z

airbyte-integrations/connectors/source-partnerstack/source_partnerstack/partnerstack.yaml

+      type: DefaultPaginator
+      pagination_strategy:
+        type: "CursorPagination"
+        cursor_value: "{{ last_records[-1]['key'] }}"


@elliottrabac I saw this connector supports incremental syncs. Are you interested in implementing this sync mode for this connector? I'm askng because the incremental sync is much more interesting to users where you can retrieve only new records.

marcosmarxm · 2022-11-02T20:29:53Z

@elliottrabac please request my review again when you finish the to solve the comments.

marcosmarxm · 2022-11-04T08:52:19Z

Hello! I'm going to be out of the office this Friday and won't be able to review your contribution again today, I return next Monday. So far, most contributions look solid and are almost done to be approved. As said in Chris' comment all contributions made before 2-November are eligible to receive the prize and have 2 weeks to merge the contributions. But I ensure next week we're going to have your contribution merged. If you have questions about the implementation you can send them in #hacktoberfest-2022 in Airbyte's Slack.

Sorry the inconvenience and see you again next week, thank you so much for your contribution!

elliottrabac · 2022-11-07T13:35:57Z

Hi @marcosmarxm I tried to implement the incremental sync for this connector but I'm struggling with datetimeformat with the low-code CDK because the format in Partnerstack is epoch timestamp (in ms).

Do you think there is a workaround for this?
Do I need to create a custom component for this?

I'm not sure I'll have time to wrap it up in the coming days. As the full refresh connector is working well, do you think we could merge it like that to meet the hacktoberfest deadline and iterate on the incremental sync after?

elliottrabac · 2022-11-07T19:54:42Z

@marcosmarxm I implemented a custom stream slice similar to the GreenHouse one.

Acceptance tests with incremental sync:

marcosmarxm

Thanks @elliottrabac I'll publish the connector during the week.

marcosmarxm · 2022-11-09T00:04:56Z

/publish connector=connectors/source-partnerstack run-tests=false

🕑 Publishing the following connectors:
connectors/source-partnerstack
https://github.com/airbytehq/airbyte/actions/runs/3424208022

Connector	Did it publish?	Were definitions generated?
connectors/source-partnerstack	✅	✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

* add boilerplate * configure schemas * add connector doc * update airbyte docs * edit spec * configure incremental sync * use custom components * add incremental acceptances tests * add partnerstack to source def * auto-bump connector version Co-authored-by: marcosmarxm <[email protected]> Co-authored-by: Octavia Squidington III <[email protected]>

elliottrabac added 4 commits October 28, 2022 07:21

add boilerplate

afde39e

configure schemas

58ef640

add connector doc

9d2319b

update airbyte docs

263a9f8

github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Oct 28, 2022

octavia-squidington-iv added community connectors/source/partnerstack labels Oct 28, 2022

Merge branch 'master' into elliot/new-partnerstack-connector

f327aad

marcosmarxm added the hacktober label Oct 28, 2022

marcosmarxm requested changes Oct 28, 2022

View reviewed changes

RealChrisSean mentioned this pull request Oct 29, 2022

New source: Parnerstack airbytehq/connector-contest#207

Closed

elliottrabac and others added 3 commits October 30, 2022 14:02

Merge branch 'master' into elliot/new-partnerstack-connector

b84a426

edit spec

713a66f

Merge branch 'master' into elliot/new-partnerstack-connector

396dd63

elliottrabac marked this pull request as ready for review October 31, 2022 00:50

octavia-squidington-iv added the bounty label Oct 31, 2022

elliottrabac requested a review from marcosmarxm October 31, 2022 00:50

marcosmarxm requested changes Oct 31, 2022

View reviewed changes

Merge branch 'master' into elliot/new-partnerstack-connector

893e828

elliottrabac requested a review from marcosmarxm November 1, 2022 18:45

marcosmarxm requested changes Nov 1, 2022

View reviewed changes

marcosmarxm assigned sajarin Nov 4, 2022

elliottrabac added 2 commits November 7, 2022 11:27

Merge branch 'master' into elliot/new-partnerstack-connector

e6d78d8

configure incremental sync

69ce25c

elliottrabac added 2 commits November 7, 2022 20:35

use custom components

d3a3d92

add incremental acceptances tests

11d28b8

Merge branch 'master' into elliot/new-partnerstack-connector

ca2c8df

elliottrabac requested a review from marcosmarxm November 7, 2022 19:54

add partnerstack to source def

36e53e7

marcosmarxm approved these changes Nov 7, 2022

View reviewed changes

auto-bump connector version

fd796a7

marcosmarxm merged commit 444e6f9 into airbytehq:master Nov 9, 2022

sajarin changed the title ~~🎉 New source: Partnerstack~~ 🎉 New source: Partnerstack [low-code CDK] Nov 9, 2022

RealChrisSean added the low-code label Nov 15, 2022

github-actions bot mentioned this pull request Nov 15, 2022

Bump helm chart version reference to 0.40.43 #19453

Closed

octavia-squidington-iii mentioned this pull request Nov 18, 2022

Bump Airbyte version from 0.40.18 to 0.40.19 #19579

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🎉 New source: Partnerstack [low-code CDK] #18603

🎉 New source: Partnerstack [low-code CDK] #18603

elliottrabac commented Oct 28, 2022 •

edited by RealChrisSean

Loading

marcosmarxm left a comment

marcosmarxm Oct 28, 2022

elliottrabac Oct 31, 2022

marcosmarxm Oct 31, 2022

elliottrabac Nov 1, 2022 •

edited

Loading

marcosmarxm Nov 1, 2022 •

edited

Loading

elliottrabac Nov 2, 2022

marcosmarxm commented Oct 31, 2022

marcosmarxm left a comment

elliottrabac commented Nov 1, 2022

marcosmarxm Nov 1, 2022 •

edited

Loading

marcosmarxm commented Nov 2, 2022

marcosmarxm commented Nov 4, 2022

elliottrabac commented Nov 7, 2022

elliottrabac commented Nov 7, 2022

marcosmarxm left a comment

marcosmarxm commented Nov 9, 2022 •

edited by github-actions bot

Loading

🎉 New source: Partnerstack [low-code CDK] #18603

🎉 New source: Partnerstack [low-code CDK] #18603

Conversation

elliottrabac commented Oct 28, 2022 • edited by RealChrisSean Loading

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

Tests

marcosmarxm left a comment

Choose a reason for hiding this comment

marcosmarxm Oct 28, 2022

Choose a reason for hiding this comment

elliottrabac Oct 31, 2022

Choose a reason for hiding this comment

marcosmarxm Oct 31, 2022

Choose a reason for hiding this comment

elliottrabac Nov 1, 2022 • edited Loading

Choose a reason for hiding this comment

marcosmarxm Nov 1, 2022 • edited Loading

Choose a reason for hiding this comment

elliottrabac Nov 2, 2022

Choose a reason for hiding this comment

marcosmarxm commented Oct 31, 2022

marcosmarxm left a comment

Choose a reason for hiding this comment

elliottrabac commented Nov 1, 2022

marcosmarxm Nov 1, 2022 • edited Loading

Choose a reason for hiding this comment

marcosmarxm commented Nov 2, 2022

marcosmarxm commented Nov 4, 2022

elliottrabac commented Nov 7, 2022

elliottrabac commented Nov 7, 2022

marcosmarxm left a comment

Choose a reason for hiding this comment

marcosmarxm commented Nov 9, 2022 • edited by github-actions bot Loading

elliottrabac commented Oct 28, 2022 •

edited by RealChrisSean

Loading

elliottrabac Nov 1, 2022 •

edited

Loading

marcosmarxm Nov 1, 2022 •

edited

Loading

marcosmarxm Nov 1, 2022 •

edited

Loading

marcosmarxm commented Nov 9, 2022 •

edited by github-actions bot

Loading