Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AirbyteEstimateTraceMessage and UI sync Estimates - Progress Bars #18630

Closed
wants to merge 24 commits into from

Conversation

evantahler
Copy link
Contributor

@evantahler evantahler commented Oct 28, 2022

HACK THE PLANET!

Closes https://github.com/airbytehq/airbyte-internal-issues/issues/1095

Connector Notes

  • Since we didn't really publish a new version of the CDK, we can't use the built-in types to generate our new message... so we are hacking by building up the AirbyteEstimateTraceMessage dict manually
  • For this to run, we needed to publish a hacky release of the source-faker connector. Here are the steps:
docker buildx build . --platform "linux/amd64,linux/arm64" --tag airbyte/source-faker:hack-day-2022  --push

The image to use is airbyte/source-faker:hack-day-2022

Logging Notes:

You can have the worker log all AirbyteMessages it gets to the console with LOG_CONNECTOR_MESSAGES=true, e.g.

LOG_CONNECTOR_MESSAGES=true VERSION=dev docker-compose -f docker-compose.yaml -f docker-compose.debug.yaml up

@evantahler evantahler requested review from a team as code owners October 28, 2022 20:41
@evantahler evantahler marked this pull request as draft October 28, 2022 20:42
@github-actions github-actions bot added area/documentation Improvements or additions to documentation area/platform issues related to the platform area/protocol CDK Connector Development Kit labels Oct 28, 2022
@evantahler evantahler temporarily deployed to more-secrets October 28, 2022 20:43 Inactive
@evantahler evantahler changed the title AirbyteEstimateTraceMessage AirbyteEstimateTraceMessage and UI sync Estimates Oct 28, 2022
@evantahler evantahler temporarily deployed to more-secrets October 28, 2022 20:46 Inactive
@github-actions github-actions bot added the area/connectors Connector related issues label Oct 28, 2022
@evantahler evantahler temporarily deployed to more-secrets October 28, 2022 22:07 Inactive
@evantahler evantahler temporarily deployed to more-secrets October 28, 2022 22:18 Inactive
@sherifnada
Copy link
Contributor

@evantahler do you want a review on this?

@evantahler
Copy link
Contributor Author

@sherifnada not yet!

@evantahler evantahler removed request for a team October 28, 2022 23:41
@github-actions github-actions bot added area/api Related to the api area/server labels Oct 28, 2022
@davinchia davinchia temporarily deployed to more-secrets October 28, 2022 23:52 Inactive
@davinchia davinchia temporarily deployed to more-secrets October 29, 2022 00:36 Inactive
@github-actions github-actions bot added the area/frontend Related to the Airbyte webapp label Oct 29, 2022
@evantahler evantahler temporarily deployed to more-secrets November 1, 2022 18:40 Inactive
@evantahler evantahler temporarily deployed to more-secrets November 1, 2022 18:54 Inactive
- introduce and implement save_stats route
- add estimated columns to sync_stats table
- all intermediate persistence layer changes to support this
- job persistence tests for general sanity check
- job/list and get_debug_info now returns totalStats
- per-stream stats to be implement as follow up
@davinchia davinchia temporarily deployed to more-secrets November 2, 2022 00:15 Inactive
@evantahler evantahler temporarily deployed to more-secrets November 2, 2022 00:42 Inactive
@evantahler evantahler temporarily deployed to more-secrets November 2, 2022 00:57 Inactive
* Add the streamStats variable to the api route and implement replication worker sending of stream stats.

* Implement migration to add JSONB streamStats column to SyncStats table.

* Implement writing of stream stats to db.

* Implement this for per-stream.
@davinchia davinchia temporarily deployed to more-secrets November 2, 2022 01:18 Inactive
@evantahler evantahler temporarily deployed to more-secrets November 2, 2022 01:25 Inactive
@evantahler evantahler temporarily deployed to more-secrets November 2, 2022 01:47 Inactive
@evantahler evantahler added the Epic label Nov 9, 2022
@evantahler evantahler changed the title AirbyteEstimateTraceMessage and UI sync Estimates AirbyteEstimateTraceMessage and UI sync Estimates - Progress Bars Nov 9, 2022
@evantahler evantahler changed the title AirbyteEstimateTraceMessage and UI sync Estimates - Progress Bars [EPIC] AirbyteEstimateTraceMessage and UI sync Estimates - Progress Bars Nov 9, 2022
@evantahler evantahler changed the title [EPIC] AirbyteEstimateTraceMessage and UI sync Estimates - Progress Bars AirbyteEstimateTraceMessage and UI sync Estimates - Progress Bars Nov 9, 2022
@evantahler evantahler removed the Epic label Nov 9, 2022
@evantahler
Copy link
Contributor Author

@davinchia think we should close this PR now that the "real" PRs are almost done?

@davinchia
Copy link
Contributor

Yeap. Let's close this for cleanliness.

I have 2 more PRs after https://github.com/airbytehq/airbyte/pull/19814/files. However can still use this as a reference as we close.

@evantahler evantahler closed this Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api Related to the api area/connectors Connector related issues area/documentation Improvements or additions to documentation area/frontend Related to the Airbyte webapp area/platform issues related to the platform area/protocol area/server CDK Connector Development Kit connectors/source/faker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants