-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AirbyteEstimateTraceMessage
and UI sync Estimates - Progress Bars
#18630
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/documentation
Improvements or additions to documentation
area/platform
issues related to the platform
area/protocol
CDK
Connector Development Kit
labels
Oct 28, 2022
evantahler
changed the title
Oct 28, 2022
AirbyteEstimateTraceMessage
AirbyteEstimateTraceMessage
and UI sync Estimates
@evantahler do you want a review on this? |
@sherifnada not yet! |
- introduce and implement save_stats route - add estimated columns to sync_stats table - all intermediate persistence layer changes to support this - job persistence tests for general sanity check - job/list and get_debug_info now returns totalStats - per-stream stats to be implement as follow up
* Add the streamStats variable to the api route and implement replication worker sending of stream stats. * Implement migration to add JSONB streamStats column to SyncStats table. * Implement writing of stream stats to db. * Implement this for per-stream.
…irbyte into evan-davin/hack-day-progress
evantahler
changed the title
Nov 9, 2022
AirbyteEstimateTraceMessage
and UI sync EstimatesAirbyteEstimateTraceMessage
and UI sync Estimates - Progress Bars
evantahler
changed the title
[EPIC] Nov 9, 2022
AirbyteEstimateTraceMessage
and UI sync Estimates - Progress BarsAirbyteEstimateTraceMessage
and UI sync Estimates - Progress Bars
evantahler
changed the title
[EPIC]
Nov 9, 2022
AirbyteEstimateTraceMessage
and UI sync Estimates - Progress BarsAirbyteEstimateTraceMessage
and UI sync Estimates - Progress Bars
This was referenced Nov 9, 2022
@davinchia think we should close this PR now that the "real" PRs are almost done? |
Yeap. Let's close this for cleanliness. I have 2 more PRs after https://github.com/airbytehq/airbyte/pull/19814/files. However can still use this as a reference as we close. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/api
Related to the api
area/connectors
Connector related issues
area/documentation
Improvements or additions to documentation
area/frontend
Related to the Airbyte webapp
area/platform
issues related to the platform
area/protocol
area/server
CDK
Connector Development Kit
connectors/source/faker
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HACK THE PLANET!
Closes https://github.com/airbytehq/airbyte-internal-issues/issues/1095
Connector Notes
AirbyteEstimateTraceMessage
dict manuallyThe image to use is
airbyte/source-faker:hack-day-2022
Logging Notes:
You can have the worker log all AirbyteMessages it gets to the console with
LOG_CONNECTOR_MESSAGES=true
, e.g.