Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Source Kafka - Add missing record_count increment for JSON #18648

Merged
merged 9 commits into from
Nov 7, 2022
Merged

🐛 Source Kafka - Add missing record_count increment for JSON #18648

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
cb34edb
add missing record_count increment
alexnikitchuk Oct 29, 2022
470161d
bump version
alexnikitchuk Oct 30, 2022
2c4721b
Merge branch 'master' into add_missing_record_count_increment
vincentkoc Nov 3, 2022
1424e9a
Merge branch 'master' into add_missing_record_count_increment
vincentkoc Nov 4, 2022
7d6de43
Update kafka.md
vincentkoc Nov 4, 2022
5058619
update version
vincentkoc Nov 4, 2022
32ff0be
auto-bump connector version
octavia-squidington-iii Nov 4, 2022
7ce32ab
Merge branch 'master' into add_missing_record_count_increment
vincentkoc Nov 6, 2022
39b8a39
Merge branch 'master' into add_missing_record_count_increment
sajarin Nov 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion airbyte-config/init/src/main/resources/seed/source_definitions.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -635,7 +635,7 @@
- name: Kafka
sourceDefinitionId: d917a47b-8537-4d0d-8c10-36a9928d4265
dockerRepository: airbyte/source-kafka
dockerImageTag: 0.2.0
dockerImageTag: 0.2.2
documentationUrl: https://docs.airbyte.com/integrations/sources/kafka
icon: kafka.svg
sourceType: database
Expand Down
2 changes: 1 addition & 1 deletion airbyte-config/init/src/main/resources/seed/source_specs.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5806,7 +5806,7 @@
supportsNormalization: false
supportsDBT: false
supported_destination_sync_modes: []
- dockerImage: "airbyte/source-kafka:0.2.0"
- dockerImage: "airbyte/source-kafka:0.2.2"
spec:
documentationUrl: "https://docs.airbyte.com/integrations/sources/kafka"
connectionSpecification:
Expand Down
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-kafka/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,5 @@ ENV APPLICATION source-kafka

COPY --from=build /airbyte /airbyte

LABEL io.airbyte.version=0.2.0
LABEL io.airbyte.version=0.2.2
LABEL io.airbyte.name=airbyte/source-kafka
1 change: 1 addition & 0 deletions ...rs/source-kafka/src/main/java/io/airbyte/integrations/source/kafka/format/JsonFormat.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,7 @@ public AutoCloseableIterator<AirbyteMessage> read() {
}

consumerRecords.forEach(record -> {
record_count.getAndIncrement();
recordsList.add(record);
});
consumer.commitAsync();
Expand Down
2 changes: 2 additions & 0 deletions docs/integrations/sources/kafka.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,8 @@ The Kafka source connector supports the following [sync modes](https://docs.airb

| Version | Date | Pull Request | Subject |
| :------ | :-------- | :------------------------------------------------------| :---------------------------------------- |
| 0.2.2 | 2022-11-04 | [18648](https://github.com/airbytehq/airbyte/pull/18648) | Add missing record_count increment for JSON|
| 0.2.1 | 2022-11-04 | This version was the same as 0.2.0 and was committed so using 0.2.2 next to keep versions in order|
| 0.2.0 | 2022-08-22 | [13864](https://github.com/airbytehq/airbyte/pull/13864) | Added AVRO format support and Support for maximum records to process|
| 0.1.7 | 2022-06-17 | [13864](https://github.com/airbytehq/airbyte/pull/13864) | Updated stacktrace format for any trace message errors |
| 0.1.6 | 2022-05-29 | [12903](https://github.com/airbytehq/airbyte/pull/12903) | Add Polling Time to Specification (default 100 ms) |
Expand Down