🎉 New Source - Vantage [low-code cdk] #18665

haithem-souala · 2022-10-30T16:14:09Z

What

A new source connector using low-code cdk.

How

https://vantage.readme.io/reference/general

Streams

"*ref(definitions.providers_stream)"
"*ref(definitions.services_stream)"
"*ref(definitions.products_stream)"
"*ref(definitions.reports_stream)"

🚨 User Impact 🚨

N/A

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

vincentkoc · 2022-10-30T16:47:35Z

/test connector=connectors/source-vantage

🕑 connectors/source-vantage https://github.com/airbytehq/airbyte/actions/runs/3356260272
❌ connectors/source-vantage https://github.com/airbytehq/airbyte/actions/runs/3356260272
🐛 https://gradle.com/s/ujto7ve6pa2d6

Build Failed

Test summary info:

=========================== short test summary info ============================
ERROR test_core.py::TestSpec::test_config_match_spec[inputs0] - FileNotFoundE...
ERROR test_core.py::TestConnection::test_check[inputs0] - FileNotFoundError: ...
ERROR test_core.py::TestDiscovery::test_discover[inputs0] - FileNotFoundError...
ERROR test_core.py::TestDiscovery::test_defined_cursors_exist_in_schema[inputs0]
ERROR test_core.py::TestDiscovery::test_defined_refs_exist_in_schema[inputs0]
ERROR test_core.py::TestDiscovery::test_defined_keyword_exist_in_schema[inputs0-allOf]
ERROR test_core.py::TestDiscovery::test_defined_keyword_exist_in_schema[inputs0-not]
ERROR test_core.py::TestDiscovery::test_primary_keys_exist_in_schema[inputs0]
ERROR test_core.py::TestDiscovery::test_streams_has_sync_modes[inputs0] - Fil...
ERROR test_core.py::TestDiscovery::test_additional_properties_is_true[inputs0]
ERROR test_core.py::TestBasicRead::test_read[inputs0] - FileNotFoundError: [E...
ERROR test_core.py::TestBasicRead::test_airbyte_trace_message_on_failure[inputs0]
ERROR test_full_refresh.py::TestFullRefresh::test_sequential_reads[inputs0]
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestIncremental.test_two_sequential_reads: This connector does not implement incremental sync
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:51: The previous connector image could not be retrieved.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:229: The previous connector image could not be retrieved.
================== 11 passed, 3 skipped, 13 errors in 11.90s ===================

marcosmarxm

Hello @haithem-souala, Marcos from Airbyte here 👋 . We received more than 25 new contributions along the weekend. One is yours 🎉 thank so much for! Our team is limited and maybe the review process can take longer than expected. As described in the Airbyte's Hacktoberfest your contribution was submitted before November 2nd and it is eligible to win the prize. The review process will validate other requirements. I ask to you patience until someone from the team review it.

Because I reviewed some contributions for Hacktoberfest so far I saw some common patterns you can check in advance:

Make sure you have added connector documentation to /docs/integrations/
Remove the file catalog from /integration_tests
Edit the sample_config.json inside /integration_tests
For the configured_catalog you can use only json_schema: {}
Add title to all properties in the spec.yaml
Make sure the documentationUrl in the spec.yaml redirect to Airbyte's future connector page, eg: connector Airtable the documentationUrl: https://docs.airbyte.com/integrations/sources/airtable
Review now new line at EOF (end-of-file) for all files.

If possible send to me a DM in Slack with the tests credentials, this process will make easier to us run integration tests and publish your connector. If you only has production keys, make sure to create a bootstrap.md explaining how to get the keys.

marcosmarxm

Thanks for the contribution @haithem-souala I'll publish your connector later this week.

marcosmarxm · 2022-11-04T08:36:03Z

Hello! Your PR is approved but didn't have the time to publish and merge it this week. As you can check in Chris' comment all PRs submitted before 2-nov are eligible to win the prize. I'll be out of the office on Friday and return Monday to start publishing your contribution. Any question you can send a message in #hacktoberfest-2022 channel in Airbyte's Slack.

Have a good weekend and thank you for this amazing contribution for Hacktoberfest 🎉

marcosmarxm · 2022-11-13T21:25:07Z

/test connector=connectors/source-vantage

🕑 connectors/source-vantage https://github.com/airbytehq/airbyte/actions/runs/3456996334
✅ connectors/source-vantage https://github.com/airbytehq/airbyte/actions/runs/3456996334
Python tests coverage:

	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          12      4    67%   16-19
	 source_acceptance_test/config.py                       133      3    98%   87, 93, 230
	 source_acceptance_test/conftest.py                     196     97    51%   35, 41-43, 48, 54, 60, 66, 72-74, 80-95, 100, 105-107, 113-115, 121-122, 127-128, 133, 139, 148-157, 163-168, 232, 238, 244-250, 258-263, 271-284, 289-295, 302-313, 320-336
	 source_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 source_acceptance_test/tests/test_core.py              329    106    68%   39, 50-58, 63-70, 74-75, 79-80, 164, 202-219, 228-236, 240-245, 251, 284-289, 327-334, 377-379, 382, 447-455, 484-485, 491, 494, 530-540, 553-578
	 source_acceptance_test/tests/test_incremental.py       145     20    86%   21-23, 29-31, 36-43, 48-61, 224
	 source_acceptance_test/utils/asserts.py                 37      2    95%   57-58
	 source_acceptance_test/utils/common.py                  77     10    87%   15-16, 24-30, 64, 67
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/config_migration.py        23     23     0%   5-37
	 source_acceptance_test/utils/connector_runner.py       112     50    55%   23-26, 32, 36, 39-68, 71-73, 76-78, 81-83, 86-88, 91-93, 96-114, 148-150
	 source_acceptance_test/utils/json_schema_helper.py     105     13    88%   30-31, 38, 41, 65-68, 96, 120, 190-192
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1479    376    75%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestIncremental.test_two_sequential_reads: This connector does not implement incremental sync
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:51: The previous connector image could not be retrieved.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:229: The previous connector image could not be retrieved.
======================== 24 passed, 3 skipped in 27.40s ========================

marcosmarxm · 2022-11-13T22:13:39Z

/publish connector=connectors/source-vantage

🕑 Publishing the following connectors:
connectors/source-vantage
https://github.com/airbytehq/airbyte/actions/runs/3457147266

Connector	Did it publish?	Were definitions generated?
connectors/source-vantage	✅	❌

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

* init commit * add streams * add docs * test push: * add vantage to source def * generate source spec Co-authored-by: marcosmarxm <[email protected]>

github-actions bot added the area/connectors Connector related issues label Oct 30, 2022

octavia-squidington-iv added bounty community connectors/source/vantage labels Oct 30, 2022

github-actions bot added the area/documentation Improvements or additions to documentation label Oct 30, 2022

haithem-souala mentioned this pull request Oct 30, 2022

New Source - vantage.sh airbytehq/connector-contest#227

Closed

vincentkoc self-requested a review October 30, 2022 16:47

vincentkoc self-assigned this Oct 30, 2022

marcosmarxm added the hacktober label Oct 30, 2022

marcosmarxm requested changes Oct 31, 2022

View reviewed changes

haithem-souala requested review from marcosmarxm and removed request for vincentkoc October 31, 2022 12:37

marcosmarxm unassigned vincentkoc Oct 31, 2022

marcosmarxm changed the title ~~🎉 New Source - Vantage~~ 🎉 New Source - Vantage [low-code cdk] Oct 31, 2022

marcosmarxm approved these changes Nov 2, 2022

View reviewed changes

haithem-souala and others added 5 commits November 13, 2022 19:08

init commit

2639670

add streams

5bddd0f

add docs

4f63a7d

test push:

b74bdda

add vantage to source def

737e485

generate source spec

8056d09

marcosmarxm merged commit 316cd68 into airbytehq:master Nov 13, 2022

RealChrisSean added the low-code label Nov 15, 2022

github-actions bot mentioned this pull request Nov 15, 2022

Bump helm chart version reference to 0.40.43 #19453

Closed

octavia-squidington-iii mentioned this pull request Nov 18, 2022

Bump Airbyte version from 0.40.18 to 0.40.19 #19579

Merged

akashkulk pushed a commit that referenced this pull request Dec 2, 2022

🎉 New Source - Vantage [low-code cdk] (#18665)

ea32b8d

* init commit * add streams * add docs * test push: * add vantage to source def * generate source spec Co-authored-by: marcosmarxm <[email protected]>

sajarin added internal and removed bounty labels Dec 5, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🎉 New Source - Vantage [low-code cdk] #18665

🎉 New Source - Vantage [low-code cdk] #18665

haithem-souala commented Oct 30, 2022 •

edited

Loading

vincentkoc commented Oct 30, 2022 •

edited by github-actions bot

Loading

marcosmarxm left a comment

marcosmarxm left a comment

marcosmarxm commented Nov 4, 2022 •

edited

Loading

marcosmarxm commented Nov 13, 2022 •

edited by github-actions bot

Loading

marcosmarxm commented Nov 13, 2022 •

edited by github-actions bot

Loading

🎉 New Source - Vantage [low-code cdk] #18665

🎉 New Source - Vantage [low-code cdk] #18665

Conversation

haithem-souala commented Oct 30, 2022 • edited Loading

What

How

Streams

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Tests

vincentkoc commented Oct 30, 2022 • edited by github-actions bot Loading

Build Failed

marcosmarxm left a comment

Choose a reason for hiding this comment

marcosmarxm left a comment

Choose a reason for hiding this comment

marcosmarxm commented Nov 4, 2022 • edited Loading

marcosmarxm commented Nov 13, 2022 • edited by github-actions bot Loading

Build Passed

marcosmarxm commented Nov 13, 2022 • edited by github-actions bot Loading

haithem-souala commented Oct 30, 2022 •

edited

Loading

vincentkoc commented Oct 30, 2022 •

edited by github-actions bot

Loading

marcosmarxm commented Nov 4, 2022 •

edited

Loading

marcosmarxm commented Nov 13, 2022 •

edited by github-actions bot

Loading

marcosmarxm commented Nov 13, 2022 •

edited by github-actions bot

Loading