🎉 New Source: Smaily [low-code cdk] #18674
Conversation
github-actions
bot
added
area/connectors
There was a problem hiding this comment.
Hello @dainiussa, Marcos from Airbyte here 👋 . We received more than 25 new contributions along the weekend. One is yours 🎉 thank so much for! Our team is limited and maybe the review process can take longer than expected. As described in the Airbyte's Hacktoberfest your contribution was submitted before November 2nd and it is eligible to win the prize. The review process will validate other requirements. I ask to you patience until someone from the team review it.
Because I reviewed some contributions for Hacktoberfest so far I saw some common patterns you can check in advance:
- Make sure you have added connector documentation to
/docs/integrations/ - Remove the file
catalogfrom/integration_tests - Edit the
sample_config.jsoninside/integration_tests - For the
configured_catalogyou can use onlyjson_schema: {} - Add title to all properties in the
spec.yaml - Make sure the
documentationUrlin thespec.yamlredirect to Airbyte's future connector page, eg: connector Airtable thedocumentationUrl: https://docs.airbyte.com/integrations/sources/airtable - Review now new line at EOF (end-of-file) for all files.
If possible send to me a DM in Slack with the tests credentials, this process will make easier to us run integration tests and publish your connector. If you only has production keys, make sure to create a bootstrap.md explaining how to get the keys.
| retriever: | ||
| record_selector: | ||
| $ref: "*ref(definitions.selector)" | ||
| paginator: |
There was a problem hiding this comment.
Why you didn't implement the pagination to all streams? As example campaign endpoint: https://smaily.com/help/api/campaigns-3/list-campaigns/
There was a problem hiding this comment.
Because it is not necessary. As it is said in this campaigns endpoint documentation: if limit parameter is not provided or has a value of 0, then limit is not applied and all records are returned. It is the case with other endpoints as well.
|
Hello! Your PR is approved but didn't have the time to publish and merge it this week. As you can check in Chris' comment all PRs submitted before 2-nov are eligible to win the prize. I'll be out of the office on Friday and return Monday to start publishing your contribution. Any question you can send a message in Have a good weekend and thank you for this amazing contribution for Hacktoberfest 🎉 |
marcosmarxm
force-pushed
the
add_source_smaily
branch
from
5a3e073
to
cb1a1de
Compare
|
/test connector=connectors/source-smaily
Build PassedTest summary info: |
|
/publish connector=connectors/source-smaily
if you have connectors that successfully published but failed definition generation, follow step 4 here |
* Init source smaily * Added campaigns, templates, automations, ab_tests streams * Added pagination * Added documentation * Updated PR information * Added titles in spec.yaml, formatted json files * add smaily to source def Co-authored-by: marcosmarxm <[email protected]>
What
The following PR adds the new low code CDK-based Smaily Connector. For more context, please refer to this issue.
How
This PR uses the lowcode CDK to create a Smaily connector with the following streams:
Recommended reading order
spec.yamlsmaily.yaml🚨 User Impact 🚨
No changes to existing code.
Pre-merge Checklist
Expand the relevant checklist and delete the others.
New Connector
Community member or Airbyter
airbyte_secret./gradlew :airbyte-integrations:connectors:<name>:integrationTest.README.mdbootstrap.md. See description and examplesdocs/integrations/<source or destination>/<name>.mdincluding changelog. See changelog exampledocs/integrations/README.mdairbyte-integrations/builds.mdAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>command is passing/publishcommand described hereTests
Acceptance