🎉 New Source: Younium [python cdk] #18758

akashpatl · 2022-11-01T09:40:16Z

What

The following PR adds a Python CDK source for Younium.

How

Describe the solution
The PR uses the Python CDK and implements full refresh syncs of the following streams:

Invoices
Products
Subscriptions

🚨 User Impact 🚨

No changes to existing code.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed

Tests

Unit

Put your unit tests output here.

Acceptance

Put your acceptance tests output here.

CLAassistant · 2022-11-01T09:40:25Z

All committers have signed the CLA.

marcosmarxm · 2022-11-01T13:26:24Z

Hello @akashpatl, Marcos from Airbyte here 👋 . We received more than 25 new contributions along the weekend. One is yours 🎉 thank so much for! Our team is limited and maybe the review process can take longer than expected. As described in the Airbyte's Hacktoberfest your contribution was submitted before November 2nd and it is eligible to win the prize. The review process will validate other requirements. I ask to you patience until someone from the team review it.

Because I reviewed some contributions for Hacktoberfest so far I saw some common patterns you can check in advance:

Make sure you have added connector documentation to /docs/integrations/
Remove the file catalog from /integration_tests
Edit the sample_config.json inside /integration_tests
For the configured_catalog you can use only json_schema: {}
Add title to all properties in the spec.yaml
Make sure the documentationUrl in the spec.yaml redirect to Airbyte's future connector page, eg: connector Airtable the documentationUrl: https://docs.airbyte.com/integrations/sources/airtable
Review now new line at EOF (end-of-file) for all files.

If possible send to me a DM in Slack with the tests credentials, this process will make easier to us run integration tests and publish your connector. If you only has production keys, make sure to create a bootstrap.md explaining how to get the keys.

marcosmarxm

@akashpatl please ask my review when you have finish all points from my previous comment.

akashpatl · 2022-11-03T15:37:31Z

@marcosmarxm I think all the checkboxes are resolved now!

marcosmarxm · 2022-11-04T08:55:16Z

Hello! I'm going to be out of the office this Friday and won't be able to review your contribution again today, I return next Monday. So far, most contributions look solid and are almost done to be approved. As said in Chris' comment all contributions made before 2-November are eligible to receive the prize and have 2 weeks to merge the contributions. But I ensure next week we're going to have your contribution merged. If you have questions about the implementation you can send them in #hacktoberfest-2022 in Airbyte's Slack.

Sorry the inconvenience and see you again next week, thank you so much for your contribution!

marcosmarxm

Some comments.

airbyte-integrations/connectors/source-younium/source_younium/schemas/TODO.md

airbyte-integrations/connectors/source-younium/source_younium/spec.yaml

marcosmarxm

Thanks @akashpatl I'll publish later

marcosmarxm · 2022-11-09T14:05:21Z

/publish connector=connectors/source-younium

🕑 Publishing the following connectors:
connectors/source-younium
https://github.com/airbytehq/airbyte/actions/runs/3428824758

Connector	Did it publish?	Were definitions generated?
connectors/source-younium	❌	❌

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

marcosmarxm · 2022-11-09T19:49:15Z

/test connector=connectors/source-younium

🕑 connectors/source-younium https://github.com/airbytehq/airbyte/actions/runs/3431350127
✅ connectors/source-younium https://github.com/airbytehq/airbyte/actions/runs/3431350127
Python tests coverage:

Name                         Stmts   Miss  Cover
------------------------------------------------
source_younium/__init__.py       2      0   100%
source_younium/source.py        72     13    82%
------------------------------------------------
TOTAL                           74     13    82%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          12      4    67%   16-19
	 source_acceptance_test/config.py                       139      5    96%   87, 93, 235, 239-240
	 source_acceptance_test/conftest.py                     196     92    53%   35, 41-43, 48, 54, 60, 66, 72-74, 93, 98-100, 106-108, 114-115, 120-121, 126, 132, 141-150, 156-161, 176, 200, 231, 237, 243-248, 256-261, 269-282, 287-293, 300-311, 318-334
	 source_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 source_acceptance_test/tests/test_core.py              345    110    68%   53, 64-72, 77-84, 88-89, 93-94, 178, 216-233, 242-250, 254-259, 265, 298-303, 341-348, 391-393, 396, 461-469, 481-484, 489, 545-546, 552, 555, 591-601, 614-639
	 source_acceptance_test/tests/test_incremental.py       158     14    91%   52-59, 64-77, 240
	 source_acceptance_test/utils/asserts.py                 37      2    95%   57-58
	 source_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       112     50    55%   23-26, 32, 36, 39-68, 71-73, 76-78, 81-83, 86-88, 91-93, 96-114, 148-150
	 source_acceptance_test/utils/json_schema_helper.py     105     13    88%   30-31, 38, 41, 65-68, 96, 120, 190-192
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1508    348    77%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestIncremental.test_two_sequential_reads: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:65: The previous connector image could not be retrieved.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:243: The previous connector image could not be retrieved.
================= 24 passed, 3 skipped, 27 warnings in 28.43s ==================

marcosmarxm · 2022-11-09T20:14:24Z

/publish connector=connectors/source-younium

🕑 Publishing the following connectors:
connectors/source-younium
https://github.com/airbytehq/airbyte/actions/runs/3431510649

Connector	Did it publish?	Were definitions generated?
connectors/source-younium	✅	✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

* add younium source along with documentation * add documentationUrl * remove newlines eof * remove additional newlines * remove TODO file * add titles to all params in spec.yaml * add younium to source def * run format * auto-bump connector version Co-authored-by: marcosmarxm <[email protected]> Co-authored-by: Octavia Squidington III <[email protected]>

github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Nov 1, 2022

octavia-squidington-iv added bounty community connectors/source/younium labels Nov 1, 2022

marcosmarxm added the hacktober label Nov 1, 2022

marcosmarxm requested changes Nov 2, 2022

View reviewed changes

akashpatl requested a review from marcosmarxm November 3, 2022 15:37

marcosmarxm requested changes Nov 8, 2022

View reviewed changes

airbyte-integrations/connectors/source-younium/source_younium/schemas/TODO.md Outdated Show resolved Hide resolved

airbyte-integrations/connectors/source-younium/source_younium/spec.yaml Show resolved Hide resolved

akashpatl requested a review from marcosmarxm November 8, 2022 09:14

marcosmarxm approved these changes Nov 9, 2022

View reviewed changes

akash-gilion and others added 7 commits November 9, 2022 10:55

add younium source along with documentation

0b2b1f0

add documentationUrl

071a65b

remove newlines eof

f5d42d6

remove additional newlines

f1bae00

remove TODO file

abd6acf

add titles to all params in spec.yaml

229b831

add younium to source def

be0c9a0

marcosmarxm force-pushed the master branch from 8088615 to be0c9a0 Compare November 9, 2022 13:55

run format

172e245

auto-bump connector version

058e175

marcosmarxm merged commit e20773d into airbytehq:master Nov 9, 2022

RealChrisSean added the python Pull requests that update Python code label Nov 15, 2022

github-actions bot mentioned this pull request Nov 15, 2022

Bump helm chart version reference to 0.40.43 #19453

Closed

octavia-squidington-iii mentioned this pull request Nov 18, 2022

Bump Airbyte version from 0.40.18 to 0.40.19 #19579

Merged

sajarin added internal and removed bounty labels Dec 5, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🎉 New Source: Younium [python cdk] #18758

🎉 New Source: Younium [python cdk] #18758

akashpatl commented Nov 1, 2022 •

edited

Loading

CLAassistant commented Nov 1, 2022 •

edited

Loading

marcosmarxm commented Nov 1, 2022

marcosmarxm left a comment

akashpatl commented Nov 3, 2022

marcosmarxm commented Nov 4, 2022

marcosmarxm left a comment

marcosmarxm left a comment

marcosmarxm commented Nov 9, 2022 •

edited by github-actions bot

Loading

marcosmarxm commented Nov 9, 2022 •

edited by github-actions bot

Loading

marcosmarxm commented Nov 9, 2022 •

edited by github-actions bot

Loading

🎉 New Source: Younium [python cdk] #18758

🎉 New Source: Younium [python cdk] #18758

Conversation

akashpatl commented Nov 1, 2022 • edited Loading

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

Tests

CLAassistant commented Nov 1, 2022 • edited Loading

marcosmarxm commented Nov 1, 2022

marcosmarxm left a comment

Choose a reason for hiding this comment

akashpatl commented Nov 3, 2022

marcosmarxm commented Nov 4, 2022

marcosmarxm left a comment

Choose a reason for hiding this comment

marcosmarxm left a comment

Choose a reason for hiding this comment

marcosmarxm commented Nov 9, 2022 • edited by github-actions bot Loading

marcosmarxm commented Nov 9, 2022 • edited by github-actions bot Loading

Build Passed

marcosmarxm commented Nov 9, 2022 • edited by github-actions bot Loading

akashpatl commented Nov 1, 2022 •

edited

Loading

CLAassistant commented Nov 1, 2022 •

edited

Loading

marcosmarxm commented Nov 9, 2022 •

edited by github-actions bot

Loading

marcosmarxm commented Nov 9, 2022 •

edited by github-actions bot

Loading

marcosmarxm commented Nov 9, 2022 •

edited by github-actions bot

Loading