-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Source RD Station Marketing: Fix stream analytics conversions #18826
Conversation
Hi @sarafonseca-123, thanks for the PR. Is there a doc to the RD Station API change that you mentioned? |
@tuanchris there was no announcement on this change, but you can see the new response structure on this link, clicking in response 200 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me @sarafonseca-123.
CC @sajarin.
/test connector=connectors/source-rd-station-marketing
Build PassedTest summary info:
|
/publish connector=connectors/source-rd-station-marketing
if you have connectors that successfully published but failed definition generation, follow step 4 here |
@tuanchris Can you merge this PR? I'm not authorized |
@sarafonseca-123 I also cannot merge. @sajarin can you help merge this? |
Hello 👋, first thank you for this amazing contribution. We really appreciate the effort you've made to improve the project. If you have any questions feel free to send me a message in Slack! |
What
RD Station just deployed a breaking change on endpoint analytics_conversions. The data used to be in an object inside an array inside another object, and now is following other endpoints' patterns as an array inside an object. This code snippet now causes the error
TypeError: 'NoneType' object is not iterable
.How
Removing the old snippet and inheriting the method
parse_response
fromIncrementalRDStationMarketingStream
like all other analytics streams.🚨 User Impact 🚨
Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.
Pre-merge Checklist
Expand the relevant checklist and delete the others.
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing/publish
command described hereTests
Unit
Integration
Building all of Airbyte.
/Users/sarasantos/git-jusbrasil/airbyte/airbyte-integrations/connectors
Type-safe dependency accessors is an incubating feature.
source_rd_station_marketing/init.py 2 0 100%
source_rd_station_marketing/source.py 29 2 93%
source_rd_station_marketing/streams.py 97 17 82%
TOTAL 128 19 85%
checkin catalogs #1 [internal] load build definition from Dockerfile
checkin catalogs #1 sha256:3cde25d5c8941f29d8a6da583c1536f180eaaaee636aef61b3b3133b1e2097e9
checkin catalogs #1 transferring dockerfile: 37B done
checkin catalogs #1 DONE 0.0s
#2 [internal] load .dockerignore
#2 sha256:6e12b2ae605c30c4eb7e2fa2d53bbc2cf892360867277596ce633d79036aeddd
#2 transferring context: 34B done
#2 DONE 0.0s
#3 [internal] load metadata for docker.io/library/python:3.9.11-alpine3.15
#3 sha256:615609793cad3a170d91fb8a37323caa348ca31e0a749e824da4c8c1d8da2aa4
#3 DONE 2.3s
#4 [base 1/1] FROM docker.io/library/python:3.9.11-alpine3.15@sha256:45ddd216e6b4efee0617e15d541e9148ffd6898203fcbe86a9f5bf906ce7837f
#4 sha256:4c436ac5d39299d948ef79080102d272b18d64395fbed9cc821104f1e2bd7d93
#4 DONE 0.0s
#7 [internal] load build context
#7 sha256:9d7854dfb8018b0b6e4271c99a66d1b435bbaddba0c317887cd487b3a64507cc
#7 transferring context: 2.35kB done
#7 DONE 0.0s
#10 [stage-2 2/7] COPY --from=builder /install /usr/local
#10 sha256:6d065ee98d854206be6c0564ad54859ea352146cc62afc75417f453dd7052d38
#10 CACHED
#13 [stage-2 5/7] RUN apk --no-cache add bash
#13 sha256:0026f8f9778dc9251ae2c893eb7f4d0767844d4a6ba578838eef4517b773ba88
#13 CACHED
#8 [builder 3/4] COPY setup.py ./
#8 sha256:b63d6768ba6d8aa5b3739a50a0949705eddbd4ef834b4f208f9817f725434f34
#8 CACHED
#12 [stage-2 4/7] RUN echo "Etc/UTC" > /etc/timezone
#12 sha256:793ac5e47489eb8569885658c1b0ffe170dfb90d34160d9417378ab7b6979f76
#12 CACHED
#9 [builder 4/4] RUN pip install --prefix=/install .
#9 sha256:73fa2c5cabcf28b77262cfea36d4319711f4687d9cb1d52dd9ff714d6bece967
#9 CACHED
#6 [builder 2/4] RUN apk --no-cache upgrade && pip install --upgrade pip && apk --no-cache add tzdata build-base
#6 sha256:fddd1028d4c855a19a9d12c308b03a65954965cf7ce3303f4d640a7d59aba08d
#6 CACHED
#5 [builder 1/4] WORKDIR /airbyte/integration_code
#5 sha256:736c564b6c0d634b064a8145fffebbf56c57a10eea338e59977586dee56a7251
#5 CACHED
#11 [stage-2 3/7] COPY --from=builder /usr/share/zoneinfo/Etc/UTC /etc/localtime
#11 sha256:ffbe6156d291a66819bd4b1683ceaa9007f53f1ef1cd1f065b6c9a62babdc0af
#11 CACHED
#14 [stage-2 6/7] COPY main.py ./
#14 sha256:e2bfbf73e1141954a1c5c1c18ef1816f3612c66687d1309c56a01fadccb044a3
#14 CACHED
#15 [stage-2 7/7] COPY source_rd_station_marketing ./source_rd_station_marketing
#15 sha256:67ea5076290619d486f958f605b96bc8bf3d3a0d34b13d4975ef103915097ec9
#15 DONE 0.0s
#16 exporting to image
#16 sha256:e8c613e07b0b7ff33893b694f7759a10d42e180f2b4dc349fb57dc6b71dcab00
#16 exporting layers 0.0s done
#16 writing image sha256:dfcc2812ab8d44b8ecef4fcd6e4f86aa876ffbfe4bf2c095d7ee8de114ce7922 done
#16 naming to docker.io/airbyte/source-rd-station-marketing:dev done
#16 DONE 0.0s
Use 'docker scan' to run Snyk tests against images to find vulnerabilities and learn how to fix them
Deprecated Gradle features were used in this build, making it incompatible with Gradle 8.0.
You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.
See https://docs.gradle.org/7.4/userguide/command_line_interface.html#sec:command_line_warnings
Execution optimizations have been disabled for 1 invalid unit(s) of work during this build to ensure correctness.
Please consult deprecation warnings for more details.
BUILD SUCCESSFUL in 34s
42 actionable tasks: 21 executed, 21 up-to-date
Acceptance