Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter exit errors by operation name #18850

Merged
merged 3 commits into from
Nov 2, 2022
Merged

Filter exit errors by operation name #18850

merged 3 commits into from
Nov 2, 2022

Conversation

jdpgrailsdev
Copy link
Contributor

What

  • Correctly filter DestroyWorkflowThreadError exceptions from APM traces

How

  • Use the operation name, not the resource name, to identify and filter out the unwanted errors

Recommended reading order

  1. TermporalSdkInterceptor.java

Tests

  • Project builds successfully
  • Tests pass after updates to use operation name in place of resource name

@github-actions github-actions bot added area/platform issues related to the platform area/worker Related to worker labels Nov 2, 2022
@jdpgrailsdev jdpgrailsdev temporarily deployed to more-secrets November 2, 2022 13:08 Inactive
@jdpgrailsdev jdpgrailsdev temporarily deployed to more-secrets November 2, 2022 14:03 Inactive
@jdpgrailsdev jdpgrailsdev temporarily deployed to more-secrets November 2, 2022 15:02 Inactive
@jdpgrailsdev jdpgrailsdev merged commit 87d79f7 into master Nov 2, 2022
@jdpgrailsdev jdpgrailsdev deleted the jonathan/temporal-interceptor-operation-name branch November 2, 2022 16:51
drewrasm pushed a commit to drewrasm/airbyte that referenced this pull request Nov 2, 2022
@jdpgrailsdev @drewrasm
Filter exit errors by operation name (airbytehq#18850)
fd07e43
arsenlosenko pushed a commit that referenced this pull request Nov 8, 2022
@drewrasm @marcosmarxm
@xiaohansong @tuliren @octavia-squidington-iii @grishick @artem1205 @perangel @jdpgrailsdev @github-actions @xpuska513 @lazebnyi @cgardens @josephkmh @darynaishchenko @mfsiega-airbyte @tybernstein @YowanR @timroes @subodh1810 @cuyk @Amruta-Ranade
🎉 Source Pinterest: filters for entity statuses (#15074)
431ed0f 
* solve conflicts

* solve conflict in json schema

* bump to version 0.1.8 for the changes of this pr

* change ad account id in the schemas

* query to include data plane attributes (#18531)

* query to include data plane attributes

* rename functions

* fix java build

* more renaming fix

* Fix unit tests in source relational db (#18789)

* Fix unit tests

* Add extra test case for record count > 1

* Store record count in variable

* ci: use custom test-reporter action to upload job results (#18004)

* ci: use custom action to upload job results

* Correct coinmarket spec (#18790)

* correct coinmarket spec

* remove duplicate support normalization from source spec

* rollback coinmarketcap version in source def seed

* update connector version

* auto-bump connector version

Co-authored-by: Octavia Squidington III <[email protected]>

* Parameterize test_empty_streams and test_stream_with_1_airbyte_column by destination (#18197)

* Remove lines that always add Postgres to list of destinations
* Parameterize all tests in test_ephemeral by destination

* 🐛 Source Facebook Marketing: reduce request limit after specific error (#18734)

* 🐛 Source Facebook Marketing: reduce request limit after specific error

* 🐛 Source Facebook Marketing: bump version; update docs

* 🐛 Source Facebook Marketing: add test

* 🐛 Source Facebook Marketing: increase timeout

* [charts/airbyte-cron] Cleanup env vars (#18787)

* [charts/airbyte-cron] Cleanup env vars

* Remove unused env var

* Use equalsIgnoreCase (#18810)

* Bump helm chart version reference to 0.40.40 (#18815)

Co-authored-by: perangel <[email protected]>
Co-authored-by: Kyryl Skobylko <[email protected]>

* 🐛Destination Google Sheets: Fix empty headers list (#18729)

* Fix empty headers list

* Updated PR number

* Bumped version

* auto-bump connector version

Co-authored-by: Octavia Squidington III <[email protected]>

* 🐛Source Exchange Rates: Fix handling error during check connection (#18726)

* Fix handling error during check connection

* Updated PR number

* auto-bump connector version

Co-authored-by: Octavia Squidington III <[email protected]>

* Add normalization changelog and bump normalization version in platform (#18813)

* Remove ConfigPersistence usage from SecretsMigrator (#18747)

* remove config persistence from seeding logic (#18749)

* Remove the bulk actions from ConfigPersistence (#18800)

* hide ConfigPersistence inside ConfigRepository to discourage use (#18803)

* ci: add job and run id to test reports (#18832)

* Bump Airbyte version from 0.40.17 to 0.40.18 (#18827)

Co-authored-by: grishick <[email protected]>

* 🪟🔧 Remove styled components (round 1) (#18766)

* refactor EditorHeader (untested)

* refactor BaseClearView

* delete unused Subtitle

* refactor ConfirmationModal

* refactor Arrow

* refactor BulkHeader

* refactor CatalogTreeSearch

* refactor StreamFieldTable

* refactor StreamHeader

* refactor ConnectorIcon

* refactor TreeRowWrapper

* refactor DeleteBlock

* refactor EmptyResourceBlock

* revert unintended element change

* fixed acceptance tests (#18699)

* 🪟🔧 Reactor Breadcrumbs component to use anchors (#18764)

* refactor breadcrumbs to use actual links

* PR comments on styles

* increase test timeout for some webapp tests to prevent flakes (#18807)

* Remove "Filters and Segments" from Google Analytics v4 (#18508)

Filters and Segments info was incorrectly added to the Google Analytics v4 connector instead of the Google Analytics (Universal Analytics) Connector.

* Add notes about EU OAUth (#18835)

EU OAuth is not fully tested so adding a note to account for that.

* 🪟🐛 Fix: visual regression in ConnectorIcon (#18849)

* fix visual regression

* remove unused prop

* Add links to demo page (#18828)

* mysql-source:fix tinyint unsigned handling (#18619)

* mysql-source:fix tinyint unsigned handling

* update doc

* format

* upgrade version

* auto-bump connector version

Co-authored-by: Octavia Squidington III <[email protected]>

* 🪟 🎉 Allow environment specific sections in docs (#18829)

* Allow environment specific sections in docs

* Change syntax to lower case

* ci: replace GITHUB_OUTPUT with GITHUB_ENV on multiline variables (#18809)

* ci: replace GITHUB_OUTPUT with GITHUB_ENV on multiline variables

* ci: replace github set-ouput with new syntax in ./tools/bin/

* Add connection ID to span (#18852)

* edited connector docs (#18855)

* 🪟 🔧 Upgrade husky to 8.0.1 (#18719)

* Upgrade Husky

* Upgrade Husky

* Upgrade Husky

* Upgrade Husky

* Upgrade Husky

* ci: replace GITHUB_OUTPUT with GITHUB_ENV for multiline variables (#18857)

* Avoid NPE when adding connection ID to trace (#18856)

* Filter exit errors by operation name (#18850)

* add label

* auto-bump connector version

Co-authored-by: marcosmarxm <[email protected]>
Co-authored-by: Xiaohan Song <[email protected]>
Co-authored-by: Liren Tu <[email protected]>
Co-authored-by: Conor <[email protected]>
Co-authored-by: Marcos Marx <[email protected]>
Co-authored-by: Octavia Squidington III <[email protected]>
Co-authored-by: Greg Solovyev <[email protected]>
Co-authored-by: Artem Inzhyyants <[email protected]>
Co-authored-by: perangel <[email protected]>
Co-authored-by: Jonathan Pearlin <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: perangel <[email protected]>
Co-authored-by: Kyryl Skobylko <[email protected]>
Co-authored-by: Serhii Lazebnyi <[email protected]>
Co-authored-by: Charles <[email protected]>
Co-authored-by: Octavia Squidington III <[email protected]>
Co-authored-by: Joey Marshment-Howell <[email protected]>
Co-authored-by: darynaishchenko <[email protected]>
Co-authored-by: Michael Siega <[email protected]>
Co-authored-by: Tyler B <[email protected]>
Co-authored-by: Yowan Ramchoreeter <[email protected]>
Co-authored-by: Tim Roes <[email protected]>
Co-authored-by: Subodh Kant Chaturvedi <[email protected]>
Co-authored-by: Volodymyr Pochtar <[email protected]>
Co-authored-by: Amruta Ranade <[email protected]>
@github-actions github-actions bot mentioned this pull request Nov 15, 2022
Closed
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Nov 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colesnodgrass colesnodgrass colesnodgrass approved these changes

@gosusnp gosusnp Awaiting requested review from gosusnp

@benmoriceau benmoriceau Awaiting requested review from benmoriceau

@alovew alovew Awaiting requested review from alovew

Assignees
No one assigned
Labels
area/platform issues related to the platform area/worker Related to worker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jdpgrailsdev @colesnodgrass