Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🪟 🐛 🎨 Fix design issues with CatalogDiff modal #18870

Merged
merged 8 commits into from
Nov 15, 2022
Merged

🪟 🐛 🎨 Fix design issues with CatalogDiff modal #18870

merged 8 commits into from
Nov 15, 2022

Commits on Nov 10, 2022

  1. Increase size of CatalogDiff modal 

    Add ModalService to CatalogDiff to fix story
    @edmundito
    edmundito committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    18763af View commit details
    Browse the repository at this point in the history

  2. Fix issues with catalog diff field section styles 

    * Update how icons work
* Rearrange table headings and cells to align correctly
* Add more spacing to the Diff Icon badges
* Remove div from DiffHeader and simplify rendering
* Remove border-spacing from tables
* Move table margins to be set by padding on the panel itself
    @edmundito
    edmundito committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    4018acc View commit details
    Browse the repository at this point in the history

  3. Update spacing on field section to align more closely with design

    @edmundito
    edmundito committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    0aa6785 View commit details
    Browse the repository at this point in the history

  4. Update text color in NumberBadge to be consistent.

    @edmundito
    edmundito committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    a418e10 View commit details
    Browse the repository at this point in the history

  5. Update spacing and alignment in stream row to match design

    @edmundito
    edmundito committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    7ca4490 View commit details
    Browse the repository at this point in the history

  6. Restore text color in NumberBadge

    @edmundito
    edmundito authored Nov 10, 2022
    Configuration menu
    Copy the full SHA
    adf638b View commit details
    Browse the repository at this point in the history

  7. Cleanup onClose fn in CatalogDiff story

    @edmundito
    edmundito committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    0fca961 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2022

  1. Add padding bottoom to DiffAccordion 

    Update CatalogDiff stories to include different use cases
    @edmundito
    edmundito committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    a2ec790 View commit details
    Browse the repository at this point in the history