Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter DestroyWorkflowThreadError from trace #18907

Merged
merged 2 commits into from
Nov 3, 2022
Merged

Filter DestroyWorkflowThreadError from trace #18907

merged 2 commits into from
Nov 3, 2022

Conversation

jdpgrailsdev
Copy link
Contributor

What

  • Remove unwanted error from trace.

How

  • Filter on either the operation name or resource name. I've tried both solutions previously and each has removed some, but not all of the errors from the traces. This latest fix should catch all of them.

Recommended reading order

  1. TemporalSdkInterceptor.java

Tests

  • Project builds locally
  • All tests pass
  • Tests updated for OR logic

@github-actions github-actions bot added area/platform issues related to the platform area/worker Related to worker labels Nov 3, 2022
@jdpgrailsdev jdpgrailsdev temporarily deployed to more-secrets November 3, 2022 14:04 Inactive
@jdpgrailsdev jdpgrailsdev merged commit fcf4758 into master Nov 3, 2022
@jdpgrailsdev jdpgrailsdev deleted the jonathan/filter-apm-errors branch November 3, 2022 15:50
@github-actions github-actions bot mentioned this pull request Nov 15, 2022
Closed
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Nov 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colesnodgrass colesnodgrass colesnodgrass approved these changes

@gosusnp gosusnp Awaiting requested review from gosusnp

@benmoriceau benmoriceau Awaiting requested review from benmoriceau

@alovew alovew Awaiting requested review from alovew

Assignees
No one assigned
Labels
area/platform issues related to the platform area/worker Related to worker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jdpgrailsdev @colesnodgrass