Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix master build failure cause of TiDBDestinationTest #18982

Merged
merged 1 commit into from
Nov 4, 2022
Merged

fix master build failure cause of TiDBDestinationTest #18982

merged 1 commit into from
Nov 4, 2022

Conversation

subodh1810
Copy link
Contributor

Master build is failing cause of this test

TiDBDestinationTest > sanityTest() FAILED
    org.opentest4j.AssertionFailedError: expected: <[***"id":0,"name":"human 0"***, ***"id":1,"name":"human 1"***, ***"id":2,"name":"human 2"***, ***"id":3,"name":"human 3"***, ***"id":4,"name":"human 4"***, ***"id":5,"name":"human 5"***, ***"id":6,"name":"human 6"***, ***"id":7,"name":"human 7"***, ***"id":8,"name":"human 8"***, ***"id":9,"name":"human 9"***]> but was: <[***"id":6,"name":"human 6"***, ***"id":3,"name":"human 3"***, ***"id":0,"name":"human 0"***, ***"id":7,"name":"human 7"***, ***"id":2,"name":"human 2"***, ***"id":1,"name":"human 1"***, ***"id":9,"name":"human 9"***, ***"id":8,"name":"human 8"***, ***"id":4,"name":"human 4"***, ***"id":5,"name":"human 5"***]>
        at app//org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
        at app//org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
        at app//org.junit.jupiter.api.AssertEquals.failNotEqual(AssertEquals.java:197)
        at app//org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:182)
        at app//org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:177)
        at app//org.junit.jupiter.api.Assertions.assertEquals(Assertions.java:1142)
        at app//io.airbyte.integrations.destination.tidb.TiDBDestinationTest.sanityTest(TiDBDestinationTest.java:101)

See https://github.com/airbytehq/airbyte/actions/runs/3396213951/jobs/5647049101

@subodh1810 subodh1810 self-assigned this Nov 4, 2022
@github-actions github-actions bot added the area/connectors Connector related issues label Nov 4, 2022
@subodh1810 subodh1810 changed the title fix master build failure fix master build failure cause of TiDBDestinationTest Nov 4, 2022
@subodh1810 subodh1810 merged commit 87870c4 into master Nov 4, 2022
@subodh1810 subodh1810 deleted the fix-master-55h-november branch November 4, 2022 19:19
@ryankfu
Copy link
Contributor

ryankfu commented Nov 4, 2022

Thanks for fixing this! Was looking into the issue then got pulled aside for issues unrelated

letiescanciano added a commit that referenced this pull request Nov 7, 2022
@letiescanciano
Merge branch 'master' into leti/experiment-add-source-in-signup
c3edfb7 
* master: (69 commits)
  🪟 🐛 Fix wrong geography dropdown type #19021
  SAT: basic read on full catalog when `test_strictness_level == high` (#18937)
  Unhide DynamoDB destination (#18994)
  Fixed tests for destination connectors (#19007)
  🐛 Source Facebook Marketing: handle FacebookBadObjectError (#18971)
  Edit multi-cloud docs (#18972)
  🪟 🎉 Load credits consumption separate (#18986)
  Bmoric/extract source api (#18944)
  Migrating InvalidCursorException -> ConfigErrorException  (#18995)
  🪟 🎨 Fix banner link color (#18978)
  Handling configuration exceptions in IntegrationRunner (#18989)
  Add new workspace api endpoint (#18983)
  Add normalization to destination definition and actor definition table (#18300)
  Fix oauth controller (#18981)
  Fix migration dev center schema dump by run db-specific initialization script (#18984)
  fix master build failure (#18982)
  cleanup: delete debezium 1-4-2 module (#18733)
  Remove unused job persistence methods. (#18952)
  Hash filenames of extracted CSS (#18976)
  Fix typo in source code comment DataDaog ==> Datadog (#18911)
  ...
letiescanciano added a commit that referenced this pull request Nov 7, 2022
@letiescanciano
Merge branch 'master' into leti/move-oauth-to-the-top
6c7a97f 
* master: (73 commits)
  🪟 🐛 Fix wrong geography dropdown type #19021
  SAT: basic read on full catalog when `test_strictness_level == high` (#18937)
  Unhide DynamoDB destination (#18994)
  Fixed tests for destination connectors (#19007)
  🐛 Source Facebook Marketing: handle FacebookBadObjectError (#18971)
  Edit multi-cloud docs (#18972)
  🪟 🎉 Load credits consumption separate (#18986)
  Bmoric/extract source api (#18944)
  Migrating InvalidCursorException -> ConfigErrorException  (#18995)
  🪟 🎨 Fix banner link color (#18978)
  Handling configuration exceptions in IntegrationRunner (#18989)
  Add new workspace api endpoint (#18983)
  Add normalization to destination definition and actor definition table (#18300)
  Fix oauth controller (#18981)
  Fix migration dev center schema dump by run db-specific initialization script (#18984)
  fix master build failure (#18982)
  cleanup: delete debezium 1-4-2 module (#18733)
  Remove unused job persistence methods. (#18952)
  Hash filenames of extracted CSS (#18976)
  Fix typo in source code comment DataDaog ==> Datadog (#18911)
  ...
@github-actions github-actions bot mentioned this pull request Nov 15, 2022
Closed
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Nov 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodireich rodireich rodireich approved these changes

Assignees

@subodh1810 subodh1810

Labels
area/connectors Connector related issues connectors/destination/tidb
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@subodh1810 @ryankfu @rodireich @octavia-squidington-iv