Bmoric/extract source definition specification api #18997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…irbyte into bmoric/extract-scheduler-api
…ract-operation-api
…irbyte into bmoric/extract-scheduler-api
…ract-scheduler-api
github-actions
bot
added
area/platform
benmoriceau
changed the base branch from
master
to
bmoric/extract-workspace-api
…ract-source-definition-specification-api
benmoriceau
requested review from
alovew,
colesnodgrass,
gosusnp and
jdpgrailsdev
gosusnp
approved these changes
Nov 8, 2022
| ConfigurationApiFactory.secretsRepositoryReader = secretsRepositoryReader; | ||
| ConfigurationApiFactory.secretsRepositoryWriter = secretsRepositoryWriter; | ||
| ConfigurationApiFactory.synchronousSchedulerClient = synchronousSchedulerClient; | ||
| final Map<String, String> mdc) { |
benmoriceau
deleted the
bmoric/extract-source-definition-specification-api
branch
akashkulk
pushed a commit
that referenced
this pull request
Dec 2, 2022
* Extract Operation API * Extract scheduler API * Format * extract source api * Extract source definition api * Add path * Extract State API * extract webbackend api * extract webbackend api * extract workspace api * Extract source definition specification api
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
In order to be prepared for a smoother migration to Micronaut for the server, an effort must be made to break the ConfigurationApi into multiple classes. This PR is the first one of a series of PR to come.
How
Extract the SourceDefinitionSpecificationApi into its own class
Recommended reading order
No specific order