#2576 oncall. SAT: test spec against exposed secrets #19124

davydov-d · 2022-11-08T14:41:18Z

What

https://github.com/airbytehq/airbyte-cloud/issues/2576

How

Implement a SAT test:

find all properties in a spec
filter them by name
filter out those properties which can not hold a secret value due to their type
the ones left should be marked with airbyte_secret: true, fail test otherwise

github-actions · 2022-11-08T14:42:45Z

Affected Connector Report

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to do the following as needed:

Run integration tests
Bump connector version
Add changelog
Publish the new version

❌ Sources (64)

Connector	Version	Changelog	Publish
`source-airtable`	`0.1.3`	✅	✅
`source-amazon-ads`	`0.1.25`	✅	✅
`source-amazon-seller-partner`	`0.2.28`	✅	✅
`source-amazon-sqs`	`0.1.0`	✅	✅
`source-amplitude`	`0.1.17`	✅	✅
`source-appsflyer`	`0.1.0`	⚠ (doc not found)	⚠ (not in seed)
`source-asana`	`0.1.4`	✅	✅
`source-azure-table`	`0.1.3`	✅	✅
`source-braintree`	`0.1.3`	✅	✅
`source-cart`	`0.2.0`	❌ (changelog missing)	✅
`source-chargebee`	`0.1.16`	✅	❌ (diff seed version)
`source-commercetools`	`0.1.0`	✅	✅
`source-confluence`	`0.1.1`	✅	✅
`source-datadog`	`0.1.0`	✅	✅
`source-delighted`	`0.1.4`	✅	✅
`source-drift`	`0.2.5`	✅	✅
`source-facebook-marketing`	`0.2.72`	✅	✅
`source-facebook-pages`	`0.1.6`	✅	✅
`source-freshcaller`	`0.1.0`	✅	✅
`source-freshsales`	`0.1.2`	✅	✅
`source-freshservice`	`0.1.1`	✅	✅
`source-github`	`0.3.7`	✅	✅
`source-gitlab`	`0.1.6`	✅	✅
`source-google-ads`	`0.2.4`	✅	✅
`source-google-search-console`	`0.1.18`	✅	✅
`source-greenhouse`	`0.3.0`	✅	✅
`source-harvest`	`0.1.11`	✅	✅
`source-instagram`	`1.0.0`	✅	✅
`source-iterable`	`0.1.21`	✅	✅
`source-klaviyo`	`0.1.10`	✅	✅
`source-lemlist`	`0.1.1`	❌ (changelog missing)	❌ (diff seed version)
`source-lever-hiring`	`0.1.3`	✅	✅
`source-linnworks`	`0.1.5`	❌ (changelog missing)	✅
`source-mailchimp`	`0.2.15`	✅	✅
`source-mailgun`	`0.1.0`	⚠ (doc not found)	✅
`source-monday`	`0.1.4`	✅	✅
`source-notion`	`0.1.10`	✅	✅
`source-okta`	`0.1.13`	✅	✅
`source-onesignal`	`0.1.2`	✅	✅
`source-openweather`	`0.1.6`	✅	✅
`source-outreach`	`0.1.2`	✅	✅
`source-pardot`	`0.1.0`	⚠ (doc not found)	⚠ (not in seed)
`source-paystack`	`0.1.1`	✅	✅
`source-pinterest`	`0.1.9`	✅	✅
`source-pipedrive`	`0.1.13`	✅	✅
`source-plaid`	`0.3.2`	❌ (changelog missing)	✅
`source-posthog`	`0.1.7`	✅	✅
`source-prestashop`	`0.2.0`	⚠ (doc not found)	✅
`source-quickbooks-singer`	`0.1.5`	⚠ (doc not found)	✅
`source-recharge`	`0.2.4`	❌ (changelog missing)	✅
`source-retently`	`0.1.2`	✅	✅
`source-salesforce`	`1.0.24`	✅	✅
`source-salesloft`	`0.1.3`	✅	✅
`source-sendgrid`	`0.2.16`	✅	✅
`source-sentry`	`0.1.7`	✅	✅
`source-strava`	`0.1.2`	✅	✅
`source-surveymonkey`	`0.1.11`	✅	✅
`source-tplcentral`	`0.1.1`	✅	⚠ (not in seed)
`source-twilio`	`0.1.13`	✅	✅
`source-weatherstack`	`0.1.0`	✅	✅
`source-youtube-analytics`	`0.1.3`	✅	✅
`source-zendesk-sunshine`	`0.1.1`	✅	✅
`source-zendesk-talk`	`0.1.5`	✅	✅
`source-zenloop`	`0.1.3`	✅	✅

See "Actionable Items" below for how to resolve warnings and errors.

✅ Destinations (0)

Connector	Version	Changelog	Publish

See "Actionable Items" below for how to resolve warnings and errors.

Actionable Items

(click to expand)

Category	Status	Actionable Item
Version	❌ mismatch	The version of the connector is different from its normal variant. Please bump the version of the connector.
	⚠ doc not found	The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like `source-jdbc` is not published or documented). Please double-check to make sure that it is not a bug.
Changelog	⚠ doc not found	The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like `source-jdbc` is not published or documented). Please double-check to make sure that it is not a bug.
	❌ changelog missing	There is no chnagelog for the current version of the connector. If you are the author of the current version, please add a changelog.
Publish	⚠ not in seed	The connector is not in the seed file (e.g. `source_definitions.yaml`), so its publication status cannot be checked. This can be normal (e.g. some connectors are cloud-specific, and only listed in the cloud seed file). Please double-check to make sure that it is not a bug.
	❌ diff seed version	The connector exists in the seed file, but the latest version is not listed there. This usually means that the latest version is not published. Please use the `/publish` command to publish the latest version.

davydov-d · 2022-11-08T14:44:48Z

/test connector=bases/source-acceptance-test

🕑 bases/source-acceptance-test https://github.com/airbytehq/airbyte/actions/runs/3420438090
✅ bases/source-acceptance-test https://github.com/airbytehq/airbyte/actions/runs/3420438090
No Python unittests run

Build Passed

Test summary info:

All Passed

davydov-d · 2022-11-08T14:45:03Z

/test connector=connectors/source-marketo

🕑 connectors/source-marketo https://github.com/airbytehq/airbyte/actions/runs/3420440213
✅ connectors/source-marketo https://github.com/airbytehq/airbyte/actions/runs/3420440213
Python tests coverage:

Name                         Stmts   Miss  Cover
------------------------------------------------
source_marketo/__init__.py       2      0   100%
source_marketo/utils.py         33      1    97%
source_marketo/source.py       271     29    89%
------------------------------------------------
TOTAL                          306     30    90%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          12      4    67%   16-19
	 source_acceptance_test/config.py                       133      3    98%   87, 93, 230
	 source_acceptance_test/conftest.py                     196     92    53%   35, 41-43, 48, 54, 60, 66, 72-74, 93, 98-100, 106-108, 114-115, 120-121, 126, 132, 141-150, 156-161, 176, 200, 231, 237, 243-248, 256-261, 269-282, 287-293, 300-311, 318-334
	 source_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 source_acceptance_test/tests/test_core.py              382    114    70%   53, 64-72, 77-84, 88-89, 93-94, 207, 213, 218-219, 256, 294-311, 320-328, 332-337, 343, 376-381, 419-426, 469-471, 474, 539-547, 559-562, 567, 623-624, 630, 633, 669-679, 692-717
	 source_acceptance_test/tests/test_incremental.py       145     20    86%   21-23, 29-31, 36-43, 48-61, 224
	 source_acceptance_test/utils/asserts.py                 37      2    95%   57-58
	 source_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/config_migration.py        23     23     0%   5-37
	 source_acceptance_test/utils/connector_runner.py       112     50    55%   23-26, 32, 36, 39-68, 71-73, 76-78, 81-83, 86-88, 91-93, 96-114, 148-150
	 source_acceptance_test/utils/json_schema_helper.py     105     13    88%   30-31, 38, 41, 65-68, 96, 120, 190-192
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1549    379    76%

Build Passed

Test summary info:

All Passed

davydov-d · 2022-11-08T14:45:10Z

/test connector=connectors/source-klaviyo

🕑 connectors/source-klaviyo https://github.com/airbytehq/airbyte/actions/runs/3420441206
✅ connectors/source-klaviyo https://github.com/airbytehq/airbyte/actions/runs/3420441206
Python tests coverage:

Name                         Stmts   Miss  Cover
------------------------------------------------
source_klaviyo/__init__.py       2      0   100%
source_klaviyo/streams.py      136     10    93%
source_klaviyo/source.py        16      3    81%
------------------------------------------------
TOTAL                          154     13    92%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          12      4    67%   16-19
	 source_acceptance_test/config.py                       133      3    98%   87, 93, 230
	 source_acceptance_test/conftest.py                     196     92    53%   35, 41-43, 48, 54, 60, 66, 72-74, 93, 98-100, 106-108, 114-115, 120-121, 126, 132, 141-150, 156-161, 176, 200, 231, 237, 243-248, 256-261, 269-282, 287-293, 300-311, 318-334
	 source_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 source_acceptance_test/tests/test_core.py              382    114    70%   53, 64-72, 77-84, 88-89, 93-94, 207, 213, 218-219, 256, 294-311, 320-328, 332-337, 343, 376-381, 419-426, 469-471, 474, 539-547, 559-562, 567, 623-624, 630, 633, 669-679, 692-717
	 source_acceptance_test/tests/test_incremental.py       145     20    86%   21-23, 29-31, 36-43, 48-61, 224
	 source_acceptance_test/utils/asserts.py                 37      2    95%   57-58
	 source_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/config_migration.py        23     23     0%   5-37
	 source_acceptance_test/utils/connector_runner.py       112     50    55%   23-26, 32, 36, 39-68, 71-73, 76-78, 81-83, 86-88, 91-93, 96-114, 148-150
	 source_acceptance_test/utils/json_schema_helper.py     105     13    88%   30-31, 38, 41, 65-68, 96, 120, 190-192
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1549    379    76%

Build Passed

Test summary info:

All Passed

davydov-d · 2022-11-08T14:45:19Z

/test connector=connectors/source-slack

🕑 connectors/source-slack https://github.com/airbytehq/airbyte/actions/runs/3420442585
❌ connectors/source-slack https://github.com/airbytehq/airbyte/actions/runs/3420442585
🐛 https://gradle.com/s/r7kycnxdf5ama

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestSpec::test_secret_is_properly_marked[inputs0] - Fail...
============ 1 failed, 31 passed, 30 warnings in 146.86s (0:02:26) =============

davydov-d · 2022-11-08T14:45:33Z

/test connector=connectors/source-snapchat-marketing

🕑 connectors/source-snapchat-marketing https://github.com/airbytehq/airbyte/actions/runs/3420445125
✅ connectors/source-snapchat-marketing https://github.com/airbytehq/airbyte/actions/runs/3420445125
Python tests coverage:

Name                                    Stmts   Miss  Cover
-----------------------------------------------------------
source_snapchat_marketing/__init__.py       2      0   100%
source_snapchat_marketing/source.py       277     22    92%
-----------------------------------------------------------
TOTAL                                     279     22    92%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          12      4    67%   16-19
	 source_acceptance_test/config.py                       133      3    98%   87, 93, 230
	 source_acceptance_test/conftest.py                     196     92    53%   35, 41-43, 48, 54, 60, 66, 72-74, 93, 98-100, 106-108, 114-115, 120-121, 126, 132, 141-150, 156-161, 176, 200, 231, 237, 243-248, 256-261, 269-282, 287-293, 300-311, 318-334
	 source_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 source_acceptance_test/tests/test_core.py              382    114    70%   53, 64-72, 77-84, 88-89, 93-94, 207, 213, 218-219, 256, 294-311, 320-328, 332-337, 343, 376-381, 419-426, 469-471, 474, 539-547, 559-562, 567, 623-624, 630, 633, 669-679, 692-717
	 source_acceptance_test/tests/test_incremental.py       145     20    86%   21-23, 29-31, 36-43, 48-61, 224
	 source_acceptance_test/utils/asserts.py                 37      2    95%   57-58
	 source_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/config_migration.py        23     23     0%   5-37
	 source_acceptance_test/utils/connector_runner.py       112     50    55%   23-26, 32, 36, 39-68, 71-73, 76-78, 81-83, 86-88, 91-93, 96-114, 148-150
	 source_acceptance_test/utils/json_schema_helper.py     105     13    88%   30-31, 38, 41, 65-68, 96, 120, 190-192
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1549    379    76%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_incremental.py:23: `future_state_path` not specified, skipping
============ 38 passed, 1 skipped, 30 warnings in 317.21s (0:05:17) ============

alafanechere

Nice work thanks!
I'd appreciate the following:

a bit more documentation through doc strings and inline comments
code split for better readability
unit testing of all the functions you declare

Please also update the reference doc to mention this new test https://github.com/airbytehq/airbyte/blob/master/docs/connector-development/testing-connectors/source-acceptance-tests-reference.md#L99

airbyte-integrations/bases/source-acceptance-test/source_acceptance_test/tests/test_core.py

evantahler

👍 from me, pending @alafanechere's comments

…re-properly-marked-in-spec

davydov-d · 2022-11-10T09:39:38Z

Nice work thanks! I'd appreciate the following:

a bit more documentation through doc strings and inline comments

code split for better readability

unit testing of all the functions you declare

Please also update the reference doc to mention this new test https://github.com/airbytehq/airbyte/blob/master/docs/connector-development/testing-connectors/source-acceptance-tests-reference.md#L99

@alafanechere thanks for the review, I made the changes, please take a look again

davydov-d · 2022-11-10T09:40:07Z

/test connector=bases/source-acceptance-test

🕑 bases/source-acceptance-test https://github.com/airbytehq/airbyte/actions/runs/3435637551
✅ bases/source-acceptance-test https://github.com/airbytehq/airbyte/actions/runs/3435637551
No Python unittests run

Build Passed

Test summary info:

All Passed

davydov-d · 2022-11-10T09:40:23Z

/test connector=connectors/source-snapchat-marketing

🕑 connectors/source-snapchat-marketing https://github.com/airbytehq/airbyte/actions/runs/3435639020
✅ connectors/source-snapchat-marketing https://github.com/airbytehq/airbyte/actions/runs/3435639020
Python tests coverage:

Name                                    Stmts   Miss  Cover
-----------------------------------------------------------
source_snapchat_marketing/__init__.py       2      0   100%
source_snapchat_marketing/source.py       277     22    92%
-----------------------------------------------------------
TOTAL                                     279     22    92%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          12      4    67%   16-19
	 source_acceptance_test/config.py                       139      5    96%   87, 93, 235, 239-240
	 source_acceptance_test/conftest.py                     196     92    53%   35, 41-43, 48, 54, 60, 66, 72-74, 93, 98-100, 106-108, 114-115, 120-121, 126, 132, 141-150, 156-161, 176, 200, 231, 237, 243-248, 256-261, 269-282, 287-293, 300-311, 318-334
	 source_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 source_acceptance_test/tests/test_core.py              394    115    71%   53, 58, 87-95, 100-107, 111-112, 116-117, 243, 250, 255-256, 293, 331-348, 357-365, 369-374, 380, 413-418, 456-463, 506-508, 511, 576-584, 596-599, 604, 660-661, 667, 670, 706-716, 729-754
	 source_acceptance_test/tests/test_incremental.py       158     14    91%   52-59, 64-77, 240
	 source_acceptance_test/utils/asserts.py                 37      2    95%   57-58
	 source_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       112     50    55%   23-26, 32, 36, 39-68, 71-73, 76-78, 81-83, 86-88, 91-93, 96-114, 148-150
	 source_acceptance_test/utils/json_schema_helper.py     105     13    88%   30-31, 38, 41, 65-68, 96, 120, 190-192
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1557    353    77%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_incremental.py:26: `future_state` not specified, skipping.
============ 39 passed, 1 skipped, 31 warnings in 285.91s (0:04:45) ============

davydov-d · 2022-11-10T09:40:31Z

/test connector=connectors/source-slack

🕑 connectors/source-slack https://github.com/airbytehq/airbyte/actions/runs/3435642732
✅ connectors/source-slack https://github.com/airbytehq/airbyte/actions/runs/3435642732
Python tests coverage:

Name                       Stmts   Miss  Cover
----------------------------------------------
source_slack/__init__.py       2      0   100%
source_slack/source.py       218     19    91%
----------------------------------------------
TOTAL                        220     19    91%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          12      4    67%   16-19
	 source_acceptance_test/config.py                       139      5    96%   87, 93, 235, 239-240
	 source_acceptance_test/conftest.py                     196     92    53%   35, 41-43, 48, 54, 60, 66, 72-74, 93, 98-100, 106-108, 114-115, 120-121, 126, 132, 141-150, 156-161, 176, 200, 231, 237, 243-248, 256-261, 269-282, 287-293, 300-311, 318-334
	 source_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 source_acceptance_test/tests/test_core.py              394    115    71%   53, 58, 87-95, 100-107, 111-112, 116-117, 243, 250, 255-256, 293, 331-348, 357-365, 369-374, 380, 413-418, 456-463, 506-508, 511, 576-584, 596-599, 604, 660-661, 667, 670, 706-716, 729-754
	 source_acceptance_test/tests/test_incremental.py       158     14    91%   52-59, 64-77, 240
	 source_acceptance_test/utils/asserts.py                 37      2    95%   57-58
	 source_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       112     50    55%   23-26, 32, 36, 39-68, 71-73, 76-78, 81-83, 86-88, 91-93, 96-114, 148-150
	 source_acceptance_test/utils/json_schema_helper.py     105     13    88%   30-31, 38, 41, 65-68, 96, 120, 190-192
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1557    353    77%

Build Passed

Test summary info:

All Passed

davydov-d · 2022-11-10T09:40:39Z

/test connector=connectors/source-klaviyo

🕑 connectors/source-klaviyo https://github.com/airbytehq/airbyte/actions/runs/3435640926
✅ connectors/source-klaviyo https://github.com/airbytehq/airbyte/actions/runs/3435640926
Python tests coverage:

Name                         Stmts   Miss  Cover
------------------------------------------------
source_klaviyo/__init__.py       2      0   100%
source_klaviyo/streams.py      136     10    93%
source_klaviyo/source.py        16      3    81%
------------------------------------------------
TOTAL                          154     13    92%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          12      4    67%   16-19
	 source_acceptance_test/config.py                       139      5    96%   87, 93, 235, 239-240
	 source_acceptance_test/conftest.py                     196     92    53%   35, 41-43, 48, 54, 60, 66, 72-74, 93, 98-100, 106-108, 114-115, 120-121, 126, 132, 141-150, 156-161, 176, 200, 231, 237, 243-248, 256-261, 269-282, 287-293, 300-311, 318-334
	 source_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 source_acceptance_test/tests/test_core.py              394    115    71%   53, 58, 87-95, 100-107, 111-112, 116-117, 243, 250, 255-256, 293, 331-348, 357-365, 369-374, 380, 413-418, 456-463, 506-508, 511, 576-584, 596-599, 604, 660-661, 667, 670, 706-716, 729-754
	 source_acceptance_test/tests/test_incremental.py       158     14    91%   52-59, 64-77, 240
	 source_acceptance_test/utils/asserts.py                 37      2    95%   57-58
	 source_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       112     50    55%   23-26, 32, 36, 39-68, 71-73, 76-78, 81-83, 86-88, 91-93, 96-114, 148-150
	 source_acceptance_test/utils/json_schema_helper.py     105     13    88%   30-31, 38, 41, 65-68, 96, 120, 190-192
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1557    353    77%

Build Passed

Test summary info:

All Passed

davydov-d · 2022-11-10T09:40:47Z

/test connector=connectors/source-marketo

🕑 connectors/source-marketo https://github.com/airbytehq/airbyte/actions/runs/3435641345
✅ connectors/source-marketo https://github.com/airbytehq/airbyte/actions/runs/3435641345
Python tests coverage:

Name                         Stmts   Miss  Cover
------------------------------------------------
source_marketo/__init__.py       2      0   100%
source_marketo/utils.py         33      1    97%
source_marketo/source.py       271     29    89%
------------------------------------------------
TOTAL                          306     30    90%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          12      4    67%   16-19
	 source_acceptance_test/config.py                       139      5    96%   87, 93, 235, 239-240
	 source_acceptance_test/conftest.py                     196     92    53%   35, 41-43, 48, 54, 60, 66, 72-74, 93, 98-100, 106-108, 114-115, 120-121, 126, 132, 141-150, 156-161, 176, 200, 231, 237, 243-248, 256-261, 269-282, 287-293, 300-311, 318-334
	 source_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 source_acceptance_test/tests/test_core.py              394    115    71%   53, 58, 87-95, 100-107, 111-112, 116-117, 243, 250, 255-256, 293, 331-348, 357-365, 369-374, 380, 413-418, 456-463, 506-508, 511, 576-584, 596-599, 604, 660-661, 667, 670, 706-716, 729-754
	 source_acceptance_test/tests/test_incremental.py       158     14    91%   52-59, 64-77, 240
	 source_acceptance_test/utils/asserts.py                 37      2    95%   57-58
	 source_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       112     50    55%   23-26, 32, 36, 39-68, 71-73, 76-78, 81-83, 86-88, 91-93, 96-114, 148-150
	 source_acceptance_test/utils/json_schema_helper.py     105     13    88%   30-31, 38, 41, 65-68, 96, 120, 190-192
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1557    353    77%

Build Passed

Test summary info:

All Passed

alafanechere

Made additional minor suggestions. Feel free to implement these. Approving not to block you. Thank you! These tests are great.
Do not forget to publish the new SAT image before merging.

airbyte-integrations/bases/source-acceptance-test/source_acceptance_test/tests/test_core.py

airbyte-integrations/bases/source-acceptance-test/unit_tests/test_spec.py

…re-properly-marked-in-spec

davydov-d · 2022-11-10T20:46:48Z

/test connector=bases/source-acceptance-test

🕑 bases/source-acceptance-test https://github.com/airbytehq/airbyte/actions/runs/3440301170
✅ bases/source-acceptance-test https://github.com/airbytehq/airbyte/actions/runs/3440301170
No Python unittests run

Build Passed

Test summary info:

All Passed

davydov-d · 2022-11-10T21:05:00Z

/publish connector=bases/source-acceptance-test auto-bump-version=false

🕑 Publishing the following connectors:
bases/source-acceptance-test
https://github.com/airbytehq/airbyte/actions/runs/3440415241

Connector	Did it publish?	Were definitions generated?
bases/source-acceptance-test	✅	❌

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

* #2576 oncall. SAT: test spec against exposed secrets * #2576 upd changelog * #2576 review fixes * #2576 more test fixes

#2576 oncall. SAT: test spec against exposed secrets

1fb222d

#2576 upd changelog

7170cf7

davydov-d requested review from pedroslopez, alafanechere, evantahler, grubberr and darynaishchenko November 8, 2022 14:46

alafanechere requested a review from a team November 8, 2022 18:42

alafanechere requested changes Nov 8, 2022

View reviewed changes

evantahler reviewed Nov 8, 2022

View reviewed changes

evantahler assigned davydov-d Nov 8, 2022

evantahler added the from/connector-ops label Nov 8, 2022

davydov-d added 2 commits November 10, 2022 10:21

Merge branch 'master' into ddavydov/#2576-oncall-SAT-ensure-secrets-a…

371b28c

…re-properly-marked-in-spec

#2576 review fixes

b91fcfe

github-actions bot added the area/documentation Improvements or additions to documentation label Nov 10, 2022

davydov-d requested a review from alafanechere November 10, 2022 09:39

alafanechere approved these changes Nov 10, 2022

View reviewed changes

#2576 more test fixes

61a883b

Merge branch 'master' into ddavydov/#2576-oncall-SAT-ensure-secrets-a…

58a97e7

…re-properly-marked-in-spec

davydov-d merged commit 459856b into master Nov 10, 2022

davydov-d deleted the ddavydov/#2576-oncall-SAT-ensure-secrets-are-properly-marked-in-spec branch November 10, 2022 21:31

github-actions bot mentioned this pull request Nov 15, 2022

Bump helm chart version reference to 0.40.43 #19453

Closed

octavia-squidington-iii mentioned this pull request Nov 18, 2022

Bump Airbyte version from 0.40.18 to 0.40.19 #19579

Merged

akashkulk pushed a commit that referenced this pull request Dec 2, 2022

#2576 oncall. SAT: test spec against exposed secrets (#19124)

8fdf89c

* #2576 oncall. SAT: test spec against exposed secrets * #2576 upd changelog * #2576 review fixes * #2576 more test fixes

flash1293 mentioned this pull request Jan 13, 2023

SAT: Add tests for all JSON schema features that are not supported by UI #20063

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#2576 oncall. SAT: test spec against exposed secrets #19124

#2576 oncall. SAT: test spec against exposed secrets #19124

davydov-d commented Nov 8, 2022

github-actions bot commented Nov 8, 2022 •

edited

Loading

❌ Sources (64)

✅ Destinations (0)

Actionable Items

davydov-d commented Nov 8, 2022 •

edited by github-actions bot

Loading

davydov-d commented Nov 8, 2022 •

edited by github-actions bot

Loading

davydov-d commented Nov 8, 2022 •

edited by github-actions bot

Loading

davydov-d commented Nov 8, 2022 •

edited by github-actions bot

Loading

davydov-d commented Nov 8, 2022 •

edited by github-actions bot

Loading

alafanechere left a comment

evantahler left a comment

davydov-d commented Nov 10, 2022

davydov-d commented Nov 10, 2022 •

edited by github-actions bot

Loading

davydov-d commented Nov 10, 2022 •

edited by github-actions bot

Loading

davydov-d commented Nov 10, 2022 •

edited by github-actions bot

Loading

davydov-d commented Nov 10, 2022 •

edited by github-actions bot

Loading

davydov-d commented Nov 10, 2022 •

edited by github-actions bot

Loading

alafanechere left a comment

davydov-d commented Nov 10, 2022 •

edited by github-actions bot

Loading

davydov-d commented Nov 10, 2022 •

edited by github-actions bot

Loading

#2576 oncall. SAT: test spec against exposed secrets #19124

#2576 oncall. SAT: test spec against exposed secrets #19124

Conversation

davydov-d commented Nov 8, 2022

What

How

github-actions bot commented Nov 8, 2022 • edited Loading

Affected Connector Report

❌ Sources (64)

✅ Destinations (0)

Actionable Items

davydov-d commented Nov 8, 2022 • edited by github-actions bot Loading

Build Passed

davydov-d commented Nov 8, 2022 • edited by github-actions bot Loading

Build Passed

davydov-d commented Nov 8, 2022 • edited by github-actions bot Loading

Build Passed

davydov-d commented Nov 8, 2022 • edited by github-actions bot Loading

Build Failed

davydov-d commented Nov 8, 2022 • edited by github-actions bot Loading

Build Passed

alafanechere left a comment

Choose a reason for hiding this comment

evantahler left a comment

Choose a reason for hiding this comment

davydov-d commented Nov 10, 2022

davydov-d commented Nov 10, 2022 • edited by github-actions bot Loading

Build Passed

davydov-d commented Nov 10, 2022 • edited by github-actions bot Loading

Build Passed

davydov-d commented Nov 10, 2022 • edited by github-actions bot Loading

Build Passed

davydov-d commented Nov 10, 2022 • edited by github-actions bot Loading

Build Passed

davydov-d commented Nov 10, 2022 • edited by github-actions bot Loading

Build Passed

alafanechere left a comment

Choose a reason for hiding this comment

davydov-d commented Nov 10, 2022 • edited by github-actions bot Loading

Build Passed

davydov-d commented Nov 10, 2022 • edited by github-actions bot Loading

github-actions bot commented Nov 8, 2022 •

edited

Loading

davydov-d commented Nov 8, 2022 •

edited by github-actions bot

Loading

davydov-d commented Nov 8, 2022 •

edited by github-actions bot

Loading

davydov-d commented Nov 8, 2022 •

edited by github-actions bot

Loading

davydov-d commented Nov 8, 2022 •

edited by github-actions bot

Loading

davydov-d commented Nov 8, 2022 •

edited by github-actions bot

Loading

davydov-d commented Nov 10, 2022 •

edited by github-actions bot

Loading

davydov-d commented Nov 10, 2022 •

edited by github-actions bot

Loading

davydov-d commented Nov 10, 2022 •

edited by github-actions bot

Loading

davydov-d commented Nov 10, 2022 •

edited by github-actions bot

Loading

davydov-d commented Nov 10, 2022 •

edited by github-actions bot

Loading

davydov-d commented Nov 10, 2022 •

edited by github-actions bot

Loading

davydov-d commented Nov 10, 2022 •

edited by github-actions bot

Loading