🪟 🎉 Add temporary dropdown component for geography selection #19127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephkmh
changed the title
github-actions
bot
added
area/platform
josephkmh
changed the title
timroes
reviewed
Nov 8, 2022
airbyte-webapp/src/components/common/DataGeographyDropdown/DataGeographyDropdown.tsx
Outdated
Show resolved
Hide resolved
timroes
reviewed
Nov 8, 2022
airbyte-webapp/src/packages/cloud/views/workspaces/DataResidencyView/DataResidencyView.tsx
Outdated
Show resolved
Hide resolved
timroes
approved these changes
Nov 8, 2022
akashkulk
pushed a commit
that referenced
this pull request
Dec 2, 2022
* add temporary data geography dropdown * remove commented code * adjust comment * remove console.log * avoid any type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adds a temporary implementation of a dropdown for selecting a data geography. A more nicely designed version is being implemented here: #18543 but is currently on hold because we may switch away from
react-select. This PR just introduces a simple component that we can discard or alter later.How
<DataGeographyDropdown>componentreact-select'sMenuListto display a link to a Google form where users can request new geographies