Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed checkstyle by running the "./gradlew --no-daemon format --scan". NO changes in logic #19214

Merged
merged 5 commits into from
Nov 9, 2022

Conversation

etsybaev
Copy link
Contributor

@etsybaev etsybaev commented Nov 9, 2022

What

Connectors Base fails at "ensure no file change" step. Someone committed code with improper format

How

Formatted code by running the "./gradlew --no-daemon format --scan" command. No changes in logic, only code format changes

🚨 User Impact 🚨

No user impact

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the connector is published, connector added to connector index as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here
Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub and connector version bumped by running the /publish command described here
Connector Generator
  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 9, 2022

Affected Connector Report

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to do the following as needed:

  • Run integration tests
  • Bump connector version
  • Add changelog
  • Publish the new version

⚠ Sources (24)

Connector Version Changelog Publish
source-alloydb 1.0.17
source-alloydb-strict-encrypt 1.0.17
(not in seed)
source-bigquery 0.2.3
source-clickhouse 0.1.14
source-clickhouse-strict-encrypt 0.1.14
(not in seed)
source-cockroachdb 0.1.18
source-cockroachdb-strict-encrypt 0.1.18
(not in seed)
source-db2 0.1.16
source-db2-strict-encrypt 0.1.16
(not in seed)
source-jdbc 0.3.5
(doc not found)

(not in seed)
source-mongodb-strict-encrypt 0.1.19
(doc not found)

(not in seed)
source-mongodb-v2 0.1.19
source-mssql 0.4.25
source-mssql-strict-encrypt 0.4.25
(not in seed)
source-mysql 1.0.11
source-mysql-strict-encrypt 1.0.11
(not in seed)
source-oracle 0.3.21
source-oracle-strict-encrypt 0.3.21
(not in seed)
source-postgres 1.0.22
source-postgres-strict-encrypt 1.0.22
(not in seed)
source-redshift 0.3.15
source-scaffold-java-jdbc 0.1.0
(doc not found)

(not in seed)
source-snowflake 0.1.24
source-tidb 0.2.1
  • See "Actionable Items" below for how to resolve warnings and errors.

⚠ Destinations (2)

Connector Version Changelog Publish
destination-mongodb-strict-encrypt 0.1.9
(not in seed)
destination-redis 0.1.4
  • See "Actionable Items" below for how to resolve warnings and errors.

Actionable Items

(click to expand)

Category Status Actionable Item
Version
mismatch
The version of the connector is different from its normal variant. Please bump the version of the connector.

doc not found
The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like source-jdbc is not published or documented). Please double-check to make sure that it is not a bug.
Changelog
doc not found
The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like source-jdbc is not published or documented). Please double-check to make sure that it is not a bug.

changelog missing
There is no chnagelog for the current version of the connector. If you are the author of the current version, please add a changelog.
Publish
not in seed
The connector is not in the seed file (e.g. source_definitions.yaml), so its publication status cannot be checked. This can be normal (e.g. some connectors are cloud-specific, and only listed in the cloud seed file). Please double-check to make sure that it is not a bug.

diff seed version
The connector exists in the seed file, but the latest version is not listed there. This usually means that the latest version is not published. Please use the /publish command to publish the latest version.

@etsybaev etsybaev temporarily deployed to more-secrets November 9, 2022 15:31 Inactive
@etsybaev etsybaev temporarily deployed to more-secrets November 9, 2022 15:37 Inactive
Copy link
Contributor

@edgao edgao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, no idea what's up with the unit test failure but we can always pull in connectors extensibility folks if merging master doesn't fix it

@etsybaev etsybaev temporarily deployed to more-secrets November 9, 2022 16:12 Inactive
@edgao
Copy link
Contributor

edgao commented Nov 9, 2022

fyi there's two files that need to be chmod +x: (https://github.com/airbytehq/airbyte/actions/runs/3429536249/jobs/5715379906#step:14:11)

diff --git a/airbyte-integrations/connectors/source-scaffold-source-http/acceptance-test-docker.sh b/airbyte-integrations/connectors/source-scaffold-source-http/acceptance-test-docker.sh
old mode 100644
new mode 100755
diff --git a/airbyte-integrations/connectors/source-scaffold-source-python/acceptance-test-docker.sh b/airbyte-integrations/connectors/source-scaffold-source-python/acceptance-test-docker.sh
old mode 100644
new mode 100755

@etsybaev
Copy link
Contributor Author

etsybaev commented Nov 9, 2022

Selection_054

@etsybaev etsybaev merged commit a4ea907 into master Nov 9, 2022
@etsybaev etsybaev deleted the etsybaev/fixed-ensure-no-change-build-error branch November 9, 2022 17:36
akashkulk pushed a commit that referenced this pull request Dec 2, 2022
…. NO changes in logic (#19214)

* Fixed checkstyle by running the "./gradlew --no-daemon format --scan". NO changes in logic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment