don't update cursor for log messages and and default schema path coming from connector builder #19271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng from connector builder
girarda
approved these changes
Nov 10, 2022
sherifnada
suggested changes
Nov 10, 2022
airbyte-cdk/python/airbyte_cdk/sources/declarative/schema/json_file_schema_loader.py
Outdated
Show resolved
Hide resolved
brianjlai
commented
Nov 11, 2022
|
|
||
| # If we are not in a source_ module, the most likely scenario is we're processing a manifest from the connector builder | ||
| # server which does not require a json schema to be defined. | ||
| return "./{{options['name']}}.json" |
There was a problem hiding this comment.
replaced the module check w/ a basic default. @sherifnada do you still need the changes r equested?
There was a problem hiding this comment.
I think over time we should probably just consolidate schemas into the YAML file. So this is a fine workaround.
sherifnada
approved these changes
Nov 11, 2022
|
|
||
| # If we are not in a source_ module, the most likely scenario is we're processing a manifest from the connector builder | ||
| # server which does not require a json schema to be defined. | ||
| return "./{{options['name']}}.json" |
There was a problem hiding this comment.
I think over time we should probably just consolidate schemas into the YAML file. So this is a fine workaround.
akashkulk
pushed a commit
that referenced
this pull request
Dec 2, 2022
…ng from connector builder (#19271) * don't update cursor for log messages and and default schema path coming from connector builder * replace check for connector_builder module with a basic default file path * update changelog and patch version * catch the correct exception when pkgutil can't load json file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
While connecting the wires for the connector builder server I found a few small issues when trying to make requests coming from the connector builder server that aren't present for real low code connectors.
How
The two fixes required are:
read()from the connector builder, we don't have any modules prefixed bysource_which makes sense because the builder server module is calledconnector_builder. Simplest path forward is to allow that caveat in the default logic.read_recordswe should only attempt to update the cursor on record messages and notAirbyteLogMessageorAirbyteTraceMessagewhich are now valid messages from the generator. They don't have any relevant fields to update state so we should just skip over these.